Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51327/?format=api
https://patches.dpdk.org/api/patches/51327/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190319064312.13743-11-tiwei.bie@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190319064312.13743-11-tiwei.bie@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190319064312.13743-11-tiwei.bie@intel.com", "date": "2019-03-19T06:43:12", "name": "[10/10] net/virtio: improve batching in standard Rx path", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8756e0a4068a20b2fd9e37d2773fb9f5c09c934a", "submitter": { "id": 617, "url": "https://patches.dpdk.org/api/people/617/?format=api", "name": "Tiwei Bie", "email": "tiwei.bie@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190319064312.13743-11-tiwei.bie@intel.com/mbox/", "series": [ { "id": 3795, "url": "https://patches.dpdk.org/api/series/3795/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3795", "date": "2019-03-19T06:43:02", "name": "net/virtio: cleanups and fixes for packed/split ring", "version": 1, "mbox": "https://patches.dpdk.org/series/3795/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51327/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/51327/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5624058C6;\n\tTue, 19 Mar 2019 07:44:02 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n\tby dpdk.org (Postfix) with ESMTP id 869AF4C9C\n\tfor <dev@dpdk.org>; Tue, 19 Mar 2019 07:43:45 +0100 (CET)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Mar 2019 23:43:45 -0700", "from dpdk-tbie.sh.intel.com ([10.67.104.173])\n\tby orsmga007.jf.intel.com with ESMTP; 18 Mar 2019 23:43:44 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,496,1544515200\"; d=\"scan'208\";a=\"123847079\"", "From": "Tiwei Bie <tiwei.bie@intel.com>", "To": "maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com,\n\tdev@dpdk.org", "Date": "Tue, 19 Mar 2019 14:43:12 +0800", "Message-Id": "<20190319064312.13743-11-tiwei.bie@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190319064312.13743-1-tiwei.bie@intel.com>", "References": "<20190319064312.13743-1-tiwei.bie@intel.com>", "Subject": "[dpdk-dev] [PATCH 10/10] net/virtio: improve batching in standard\n\tRx path", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch improves descriptors refill by using the same\nbatching strategy as done in in-order and mergeable path.\n\nSigned-off-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n drivers/net/virtio/virtio_rxtx.c | 60 ++++++++++++++++++--------------\n 1 file changed, 34 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c\nindex 42d0f533c..5f6796bdb 100644\n--- a/drivers/net/virtio/virtio_rxtx.c\n+++ b/drivers/net/virtio/virtio_rxtx.c\n@@ -1211,7 +1211,7 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \tstruct virtnet_rx *rxvq = rx_queue;\n \tstruct virtqueue *vq = rxvq->vq;\n \tstruct virtio_hw *hw = vq->hw;\n-\tstruct rte_mbuf *rxm, *new_mbuf;\n+\tstruct rte_mbuf *rxm;\n \tuint16_t nb_used, num, nb_rx;\n \tuint32_t len[VIRTIO_MBUF_BURST_SZ];\n \tstruct rte_mbuf *rcv_pkts[VIRTIO_MBUF_BURST_SZ];\n@@ -1281,20 +1281,24 @@ virtio_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \trxvq->stats.packets += nb_rx;\n \n \t/* Allocate new mbuf for the used descriptor */\n-\twhile (likely(!virtqueue_full(vq))) {\n-\t\tnew_mbuf = rte_mbuf_raw_alloc(rxvq->mpool);\n-\t\tif (unlikely(new_mbuf == NULL)) {\n-\t\t\tstruct rte_eth_dev *dev\n-\t\t\t\t= &rte_eth_devices[rxvq->port_id];\n-\t\t\tdev->data->rx_mbuf_alloc_failed++;\n-\t\t\tbreak;\n+\tif (likely(!virtqueue_full(vq))) {\n+\t\tuint16_t free_cnt = vq->vq_free_cnt;\n+\t\tstruct rte_mbuf *new_pkts[free_cnt];\n+\n+\t\tif (likely(rte_pktmbuf_alloc_bulk(rxvq->mpool, new_pkts,\n+\t\t\t\t\t\tfree_cnt) == 0)) {\n+\t\t\terror = virtqueue_enqueue_recv_refill(vq, new_pkts,\n+\t\t\t\t\tfree_cnt);\n+\t\t\tif (unlikely(error)) {\n+\t\t\t\tfor (i = 0; i < free_cnt; i++)\n+\t\t\t\t\trte_pktmbuf_free(new_pkts[i]);\n+\t\t\t}\n+\t\t\tnb_enqueued += free_cnt;\n+\t\t} else {\n+\t\t\tstruct rte_eth_dev *dev =\n+\t\t\t\t&rte_eth_devices[rxvq->port_id];\n+\t\t\tdev->data->rx_mbuf_alloc_failed += free_cnt;\n \t\t}\n-\t\terror = virtqueue_enqueue_recv_refill(vq, &new_mbuf, 1);\n-\t\tif (unlikely(error)) {\n-\t\t\trte_pktmbuf_free(new_mbuf);\n-\t\t\tbreak;\n-\t\t}\n-\t\tnb_enqueued++;\n \t}\n \n \tif (likely(nb_enqueued)) {\n@@ -1316,7 +1320,7 @@ virtio_recv_pkts_packed(void *rx_queue, struct rte_mbuf **rx_pkts,\n \tstruct virtnet_rx *rxvq = rx_queue;\n \tstruct virtqueue *vq = rxvq->vq;\n \tstruct virtio_hw *hw = vq->hw;\n-\tstruct rte_mbuf *rxm, *new_mbuf;\n+\tstruct rte_mbuf *rxm;\n \tuint16_t num, nb_rx;\n \tuint32_t len[VIRTIO_MBUF_BURST_SZ];\n \tstruct rte_mbuf *rcv_pkts[VIRTIO_MBUF_BURST_SZ];\n@@ -1380,20 +1384,24 @@ virtio_recv_pkts_packed(void *rx_queue, struct rte_mbuf **rx_pkts,\n \trxvq->stats.packets += nb_rx;\n \n \t/* Allocate new mbuf for the used descriptor */\n-\twhile (likely(!virtqueue_full(vq))) {\n-\t\tnew_mbuf = rte_mbuf_raw_alloc(rxvq->mpool);\n-\t\tif (unlikely(new_mbuf == NULL)) {\n+\tif (likely(!virtqueue_full(vq))) {\n+\t\tuint16_t free_cnt = vq->vq_free_cnt;\n+\t\tstruct rte_mbuf *new_pkts[free_cnt];\n+\n+\t\tif (likely(rte_pktmbuf_alloc_bulk(rxvq->mpool, new_pkts,\n+\t\t\t\t\t\tfree_cnt) == 0)) {\n+\t\t\terror = virtqueue_enqueue_recv_refill_packed(vq,\n+\t\t\t\t\tnew_pkts, free_cnt);\n+\t\t\tif (unlikely(error)) {\n+\t\t\t\tfor (i = 0; i < free_cnt; i++)\n+\t\t\t\t\trte_pktmbuf_free(new_pkts[i]);\n+\t\t\t}\n+\t\t\tnb_enqueued += free_cnt;\n+\t\t} else {\n \t\t\tstruct rte_eth_dev *dev =\n \t\t\t\t&rte_eth_devices[rxvq->port_id];\n-\t\t\tdev->data->rx_mbuf_alloc_failed++;\n-\t\t\tbreak;\n+\t\t\tdev->data->rx_mbuf_alloc_failed += free_cnt;\n \t\t}\n-\t\terror = virtqueue_enqueue_recv_refill_packed(vq, &new_mbuf, 1);\n-\t\tif (unlikely(error)) {\n-\t\t\trte_pktmbuf_free(new_mbuf);\n-\t\t\tbreak;\n-\t\t}\n-\t\tnb_enqueued++;\n \t}\n \n \tif (likely(nb_enqueued)) {\n", "prefixes": [ "10/10" ] }{ "id": 51327, "url": "