Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51243/?format=api
{ "id": 51243, "url": "https://patches.dpdk.org/api/patches/51243/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190316202709.11346-1-pbhagavatula@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190316202709.11346-1-pbhagavatula@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190316202709.11346-1-pbhagavatula@marvell.com", "date": "2019-03-16T20:27:36", "name": "[1/2] eventdev: check timer adapter status before start", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6f7be85d88cc4557ca3c2d2fc6a54a0dca8b8f39", "submitter": { "id": 1183, "url": "https://patches.dpdk.org/api/people/1183/?format=api", "name": "Pavan Nikhilesh Bhagavatula", "email": "pbhagavatula@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190316202709.11346-1-pbhagavatula@marvell.com/mbox/", "series": [ { "id": 3766, "url": "https://patches.dpdk.org/api/series/3766/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3766", "date": "2019-03-16T20:27:36", "name": "[1/2] eventdev: check timer adapter status before start", "version": 1, "mbox": "https://patches.dpdk.org/series/3766/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51243/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/51243/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6DCDA11A4;\n\tSat, 16 Mar 2019 21:27:46 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 08561201\n\tfor <dev@dpdk.org>; Sat, 16 Mar 2019 21:27:44 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx2GKKNkU022067; Sat, 16 Mar 2019 13:27:44 -0700", "from sc-exch02.marvell.com ([199.233.58.182])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2r90njgwbg-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tSat, 16 Mar 2019 13:27:44 -0700", "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH02.marvell.com\n\t(10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSat, 16 Mar 2019 13:27:42 -0700", "from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.54)\n\tby SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1367.3 via Frontend Transport; Sat, 16 Mar 2019 13:27:42 -0700", "from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by\n\tCY4PR1801MB2008.namprd18.prod.outlook.com (10.171.255.149) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1686.22; Sat, 16 Mar 2019 20:27:36 +0000", "from CY4PR1801MB1863.namprd18.prod.outlook.com\n\t([fe80::286d:5e93:974e:8bfa]) by\n\tCY4PR1801MB1863.namprd18.prod.outlook.com\n\t([fe80::286d:5e93:974e:8bfa%2]) with mapi id 15.20.1709.011;\n\tSat, 16 Mar 2019 20:27:36 +0000" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : content-type :\n\tcontent-transfer-encoding : mime-version; s=pfpt0818;\n\tbh=e90M+ecDm37uqcnqlgVl2bc2BUSN9qHZNhntdy8tQfk=; \n\tb=qFVtxwLH99vlWjlu9Z6TjT5WPIP73TyrGvZsHTMenC8UN+VMOYHpFa+GDjHhcj2DdV8u\n\trKiRX7OYXeWEw52dummsQYmlOhhshSjW9ctNn6gLTEyRj+Vfd4vg91P1EMs1VilGWLtO\n\t+mZqVV+xTQgiVQ6HIpSJtAXk7myxJn14pJ1UR/nj+Hiynxu+9i540BmUeSNZXZ17iaA7\n\tiTzmrMcwYVYJ6j+6OFVFGsqrINFQq7qQOAL/+3qAzjDf7WHcH0CjAnnNJ1k/kZvxzT4Z\n\tMeR5ZjNzQ1ivWkFurF/63MLBy/I7E3yk8O+JLuJckQy+R8utgY3iow2nkT3Q6e3CH2al\n\t5A== ", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=marvell.onmicrosoft.com; s=selector1-marvell-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=e90M+ecDm37uqcnqlgVl2bc2BUSN9qHZNhntdy8tQfk=;\n\tb=e67OMK1NhQTxHDx79LqxFALVKlKYwwD/pIRnRN5bUHkIRLFLGep6fzS8nSb1Z/FoDy0VaydAXuG4CjF0xOj+JCYGuN/dj6hAR66GPdfeQl8fHcgLJUWjqLhHffrT6w3kdYx6NE1rPA8pLEPVaNW8XkIRGfphqma7zE5EWzLpxVc=" ], "From": "Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>", "To": "Jerin Jacob Kollanukkaran <jerinj@marvell.com>,\n\t\"erik.g.carrillo@intel.com\" <erik.g.carrillo@intel.com>", "CC": "\"dev@dpdk.org\" <dev@dpdk.org>, Pavan Nikhilesh Bhagavatula\n\t<pbhagavatula@marvell.com>", "Thread-Topic": "[dpdk-dev] [PATCH 1/2] eventdev: check timer adapter status\n\tbefore start", "Thread-Index": "AQHU3DaxKTqc3GIuyUG5w6OO5kz3/w==", "Date": "Sat, 16 Mar 2019 20:27:36 +0000", "Message-ID": "<20190316202709.11346-1-pbhagavatula@marvell.com>", "Accept-Language": "en-IN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BMXPR01CA0026.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:c::12) To CY4PR1801MB1863.namprd18.prod.outlook.com\n\t(2603:10b6:910:7a::14)", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.21.0", "x-originating-ip": "[115.113.156.3]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "c53964da-a412-4629-d2fa-08d6aa4dd3df", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:CY4PR1801MB2008; ", "x-ms-traffictypediagnostic": "CY4PR1801MB2008:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; CY4PR1801MB2008;\n\t23:tjWHUUSF4094WzwewCorP5QlPy2mJbG6ss2R2?=\n\t=?iso-8859-1?q?EkPC46VKYvTZXpVbkaeU6GkzT?=\n\t=?iso-8859-1?q?0uKLC3weYRJ+/UO6YdUkgDTMFQEcutttKMvA0HIwwF44fkDoiPw?=\n\t=?iso-8859-1?q?dbD45j5sKnr5ugpiPeN8IYkMw+EMDeIQ1OfuxmqmEWxxidpMDr6?=\n\t=?iso-8859-1?q?hhuUFvvR9bVMpfmiuJSpkNA22tE5YzjmzWq16iZ6ofiYvLKCFzA?=\n\t=?iso-8859-1?q?DutFuLx9smlwzZRDpOj0sB9OoWiBobevXPnNilyNEoF6vpSlAN/?=\n\t=?iso-8859-1?q?2QR1LZ6WSoq3IWuK1u2Wvkm/KzngA1kaxq42uAquCDLViY52RbS?=\n\t=?iso-8859-1?q?rLktFjUVpxrIfn/HJcNs6Qw2JL9UlX6HR8u+U30nH45D+33aaQU?=\n\t=?iso-8859-1?q?ii/DV8oFtadkLZeK1cuWagT042Trur741LrWhaWMNVQnosY23Ub?=\n\t=?iso-8859-1?q?UfL0SKRPgXFKJCT3WJpfw4wzlfvoWCw+ZOkf4UIPZ+92usg5DLs?=\n\t=?iso-8859-1?q?sEjaeuYW3yi9gLrAp+8hO4oSseAjUOKwKADolzpITVi6ePxxBNs?=\n\t=?iso-8859-1?q?QeJuTFV8EJ6cVbnDdnhK9yBHlWlrP65RmEMiy1MoEXtSqh1esIL?=\n\t=?iso-8859-1?q?Z7v+7RYBJQWAxDbrbGkLqLjjeqPL9ripvy3fp730yX0k0nBsEQL?=\n\t=?iso-8859-1?q?eE3fKBqMNPJRPR37QzSaa5Ef7O7IXOiN3kIAyt1yzX4vvCfw9Kx?=\n\t=?iso-8859-1?q?pqlNi0PbUy1BmwIz23KNPIy8yUbGLCb8B+dgOJ6MOLmZJDcMKmi?=\n\t=?iso-8859-1?q?sgbzpkt4tOyw578S4VHRJwBJ6gT7DXdeLCiOf6WgRW3EOx/mW2w?=\n\t=?iso-8859-1?q?/AaFbEmUGyPe4S2qWSLgYrL3OE6DZr4Ah1odqNnnvQ+YYtmmKLr?=\n\t=?iso-8859-1?q?QAYtJ56m7gkXZCsoFT3ehq4czu/kn4DWzLUe9FOZnLBm/qP3poV?=\n\t=?iso-8859-1?q?QPTjiceeXOr6tt1r+GyP1HerLc8KzlfJxdyzPnyKU5cqxXkISox?=\n\t=?iso-8859-1?q?FvDlJ/tOV9RyipSVCBwoBb4gMqB2sOxM1vCtL0XK/G3rBdV3u0i?=\n\t=?iso-8859-1?q?usIh4skP4HHoTxd6FtpDbriXihMbCbq5DsKC2CGcs/K+Bb2GOXR?=\n\t=?iso-8859-1?q?pEKa7eE9u9HBCs/DcKif12hLezCzqmS2bxfrZE84W+FLHaDwdBJ?=\n\t=?iso-8859-1?q?ph0p9m3gxE02lDjcO5dt5C6ehEkJyX3NetsQ5Ebqm7is6hQfpW7?=\n\t=?iso-8859-1?q?Ooh29W3W3qxEen0yvjA5tEqh++DAQCfq5DBzkNEsK/h0WIw4oKZ?=\n\t=?iso-8859-1?q?qwh57gMxT+YusZVGZb85nVYno4DkWzhl/qzzr7s/CARy8eARDbM?=\n\t=?iso-8859-1?q?iuQ=3D=3D?=", "x-microsoft-antispam-prvs": "<CY4PR1801MB2008906AFAFBC717A2AFFAEFDE450@CY4PR1801MB2008.namprd18.prod.outlook.com>", "x-forefront-prvs": "09781D4C35", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(346002)(396003)(136003)(39830400003)(376002)(366004)(199004)(189003)(476003)(102836004)(305945005)(36756003)(4326008)(55236004)(54906003)(66066001)(6512007)(52116002)(8936002)(386003)(99286004)(256004)(26005)(110136005)(2906002)(14454004)(5660300002)(14444005)(81156014)(478600001)(81166006)(107886003)(1076003)(6486002)(25786009)(2501003)(8676002)(7736002)(6506007)(105586002)(2616005)(316002)(486006)(6116002)(97736004)(53936002)(68736007)(71200400001)(6436002)(71190400001)(3846002)(86362001)(186003)(50226002)(106356001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB2008;\n\tH:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; \n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: marvell.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "If3u4rcwmr0sTVVqRhnOeqb+PS/gud6d75xLjKXj3YwpF+0iWnA7BHGPRNf5o6lxh3yRgfXUkwwVqbt9FyM50zk9gphsytVGDeqUcQPyssOBfgXd4eDlBT70mazA974vzc87LwGB7Vp7wIUvDrimr90H6NwEjWD9Hc/1e8bqdFyXkEuy7NSkpU9eDN50gLRgQX7G3lfcgNPFMko5zV2j08ZxqHxvAB0lqaRMjeV0A6j8oJMtQ06WxQd0SdGE2QI9BWZD94gwoaY4tk1x6zh5Z52oh3mMlj0HYtggU8yRIvWdVQ7+nQw/TOuHPUxlANLrjSPUbSqXjVmJbfpDSTJrnMi2M02uJ1IHgRT/DrWRRjvyPZmVAQnJE/ecJ9BjW7Rk3Ej1EXpyXtLdDrwIN6ieSyGrk09PGdXvYZnUHpG/bPQ=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-MS-Exchange-CrossTenant-Network-Message-Id": "c53964da-a412-4629-d2fa-08d6aa4dd3df", "X-MS-Exchange-CrossTenant-originalarrivaltime": "16 Mar 2019 20:27:36.7391\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "70e1fb47-1155-421d-87fc-2e58f638b6e0", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR1801MB2008", "X-OriginatorOrg": "marvell.com", "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-03-16_16:, , signatures=0", "Subject": "[dpdk-dev] [PATCH 1/2] eventdev: check timer adapter status before\n\tstart", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nCheck if timer adapter is already started before starting it.\nUpdate the unit test accordingly.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\n---\n app/test/test_event_timer_adapter.c | 4 ++--\n lib/librte_eventdev/rte_event_timer_adapter.c | 6 ++++++\n lib/librte_eventdev/rte_event_timer_adapter.h | 1 +\n 3 files changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/app/test/test_event_timer_adapter.c b/app/test/test_event_timer_adapter.c\nindex a45b7d195..d4b78e093 100644\n--- a/app/test/test_event_timer_adapter.c\n+++ b/app/test/test_event_timer_adapter.c\n@@ -1015,8 +1015,8 @@ adapter_start(void)\n \tTEST_ASSERT_SUCCESS(_timdev_setup(180 * NSECPERSEC,\n \t\t\tNSECPERSEC / 10),\n \t\t\t\"Failed to start adapter\");\n-\tTEST_ASSERT_SUCCESS(rte_event_timer_adapter_start(timdev),\n-\t\t\t\"Failed to repeatedly start adapter\");\n+\tTEST_ASSERT_EQUAL(rte_event_timer_adapter_start(timdev), -EALREADY,\n+\t\t\t\"Timer adapter started without call to stop.\");\n \n \treturn TEST_SUCCESS;\n }\ndiff --git a/lib/librte_eventdev/rte_event_timer_adapter.c b/lib/librte_eventdev/rte_event_timer_adapter.c\nindex 79070d484..575da041b 100644\n--- a/lib/librte_eventdev/rte_event_timer_adapter.c\n+++ b/lib/librte_eventdev/rte_event_timer_adapter.c\n@@ -261,6 +261,12 @@ rte_event_timer_adapter_start(const struct rte_event_timer_adapter *adapter)\n \tADAPTER_VALID_OR_ERR_RET(adapter, -EINVAL);\n \tFUNC_PTR_OR_ERR_RET(adapter->ops->start, -EINVAL);\n \n+\tif (adapter->data->started) {\n+\t\tEVTIM_LOG_ERR(\"event timer adapter %\"PRIu8\" already started\",\n+\t\t\t adapter->data->id);\n+\t\treturn -EALREADY;\n+\t}\n+\n \tret = adapter->ops->start(adapter);\n \tif (ret < 0)\n \t\treturn ret;\ndiff --git a/lib/librte_eventdev/rte_event_timer_adapter.h b/lib/librte_eventdev/rte_event_timer_adapter.h\nindex db98dec46..0b10a7ab3 100644\n--- a/lib/librte_eventdev/rte_event_timer_adapter.h\n+++ b/lib/librte_eventdev/rte_event_timer_adapter.h\n@@ -339,6 +339,7 @@ rte_event_timer_adapter_get_info(\n * - -EINVAL if adapter identifier invalid\n * - -ENOENT if software adapter but no service core mapped\n * - -ENOTSUP if software adapter and more than one service core mapped\n+ * - -EALREADY if adapter has already been started\n */\n int __rte_experimental\n rte_event_timer_adapter_start(\n", "prefixes": [ "1/2" ] }