Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51198/?format=api
{ "id": 51198, "url": "https://patches.dpdk.org/api/patches/51198/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1552576396-19906-1-git-send-email-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1552576396-19906-1-git-send-email-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1552576396-19906-1-git-send-email-david.marchand@redhat.com", "date": "2019-03-14T15:13:15", "name": "[RFC,1/2] ethdev: introduce internal rxq/txq stats API", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "78c7e064b3432d97c27f1d5f644adfafb11d1036", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1552576396-19906-1-git-send-email-david.marchand@redhat.com/mbox/", "series": [ { "id": 3747, "url": "https://patches.dpdk.org/api/series/3747/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3747", "date": "2019-03-14T15:13:15", "name": "[RFC,1/2] ethdev: introduce internal rxq/txq stats API", "version": 1, "mbox": "https://patches.dpdk.org/series/3747/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51198/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/51198/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 770E0374E;\n\tThu, 14 Mar 2019 16:13:30 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id CC5E63572\n\tfor <dev@dpdk.org>; Thu, 14 Mar 2019 16:13:28 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id DEC9B30B9302;\n\tThu, 14 Mar 2019 15:13:27 +0000 (UTC)", "from dmarchan.remote.csb (unknown [10.40.205.228])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 66ABA17DCF;\n\tThu, 14 Mar 2019 15:13:25 +0000 (UTC)" ], "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, thomas@monjalon.net, arybchenko@solarflare.com", "Date": "Thu, 14 Mar 2019 16:13:15 +0100", "Message-Id": "<1552576396-19906-1-git-send-email-david.marchand@redhat.com>", "In-Reply-To": "<CAJFAV8wAM-k7mvzwo6fe1P5x=fM5s2-qyHvayJhZ_y2E=Hy6Jg@mail.gmail.com>", "References": "<CAJFAV8wAM-k7mvzwo6fe1P5x=fM5s2-qyHvayJhZ_y2E=Hy6Jg@mail.gmail.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.49]); Thu, 14 Mar 2019 15:13:28 +0000 (UTC)", "Subject": "[dpdk-dev] [RFC PATCH 1/2] ethdev: introduce internal rxq/txq stats\n\tAPI", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Introduce a new api to retrieve per queue statistics from the drivers.\nThe api objectives:\n- easily add some common per queue statistics and have it exposed\n through the user xstats api while the user stats api is left untouched\n- remove the limitations on the per queue statistics count (inherited\n from ixgbe) and avoid recurrent bugs on stats array overflow\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n lib/librte_ethdev/rte_ethdev.c | 191 ++++++++++++++++++++++++++++------\n lib/librte_ethdev/rte_ethdev_core.h | 13 +++\n lib/librte_ethdev/rte_ethdev_driver.h | 18 ++++\n 3 files changed, 192 insertions(+), 30 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 85c1794..058fbd1 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -88,21 +88,30 @@ struct rte_eth_xstats_name_off {\n \n #define RTE_NB_STATS (sizeof(rte_stats_strings) / sizeof(rte_stats_strings[0]))\n \n-static const struct rte_eth_xstats_name_off rte_rxq_stats_strings[] = {\n+static const struct rte_eth_xstats_name_off legacy_rxq_stats_map[] = {\n \t{\"packets\", offsetof(struct rte_eth_stats, q_ipackets)},\n \t{\"bytes\", offsetof(struct rte_eth_stats, q_ibytes)},\n \t{\"errors\", offsetof(struct rte_eth_stats, q_errors)},\n };\n+#define RTE_NB_LEGACY_RXQ_STATS RTE_DIM(legacy_rxq_stats_map)\n+static const struct rte_eth_xstats_name_off rxq_stats_map[] = {\n+\t{\"packets\", offsetof(struct pmd_eth_rxq_stats, packets)},\n+\t{\"bytes\", offsetof(struct pmd_eth_rxq_stats, bytes)},\n+\t{\"errors\", offsetof(struct pmd_eth_rxq_stats, errors)},\n+};\n+#define RTE_NB_RXQ_STATS RTE_DIM(rxq_stats_map)\n \n-#define RTE_NB_RXQ_STATS (sizeof(rte_rxq_stats_strings) /\t\\\n-\t\tsizeof(rte_rxq_stats_strings[0]))\n-\n-static const struct rte_eth_xstats_name_off rte_txq_stats_strings[] = {\n+static const struct rte_eth_xstats_name_off legacy_txq_stats_map[] = {\n \t{\"packets\", offsetof(struct rte_eth_stats, q_opackets)},\n \t{\"bytes\", offsetof(struct rte_eth_stats, q_obytes)},\n };\n-#define RTE_NB_TXQ_STATS (sizeof(rte_txq_stats_strings) /\t\\\n-\t\tsizeof(rte_txq_stats_strings[0]))\n+#define RTE_NB_LEGACY_TXQ_STATS RTE_DIM(legacy_txq_stats_map)\n+static const struct rte_eth_xstats_name_off txq_stats_map[] = {\n+\t{\"packets\", offsetof(struct pmd_eth_txq_stats, packets)},\n+\t{\"bytes\", offsetof(struct pmd_eth_txq_stats, bytes)},\n+\t{\"errors\", offsetof(struct pmd_eth_txq_stats, errors)},\n+};\n+#define RTE_NB_TXQ_STATS RTE_DIM(txq_stats_map)\n \n #define RTE_RX_OFFLOAD_BIT2STR(_name)\t\\\n \t{ DEV_RX_OFFLOAD_##_name, #_name }\n@@ -1937,6 +1946,10 @@ struct rte_eth_dev *\n rte_eth_stats_get(uint16_t port_id, struct rte_eth_stats *stats)\n {\n \tstruct rte_eth_dev *dev;\n+\tunsigned int nb_rxqs;\n+\tunsigned int nb_txqs;\n+\tunsigned int qid;\n+\tint ret;\n \n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);\n \n@@ -1945,7 +1958,44 @@ struct rte_eth_dev *\n \n \tRTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->stats_get, -ENOTSUP);\n \tstats->rx_nombuf = dev->data->rx_mbuf_alloc_failed;\n-\treturn eth_err(port_id, (*dev->dev_ops->stats_get)(dev, stats));\n+\tret = eth_err(port_id, (*dev->dev_ops->stats_get)(dev, stats));\n+\tif (ret)\n+\t\tgoto out;\n+\n+\tif (!dev->dev_ops->rxq_stats_get)\n+\t\tgoto skip_rxq;\n+\tnb_rxqs = RTE_MIN(dev->data->nb_rx_queues,\n+\t\t\t RTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\tfor (qid = 0; qid < nb_rxqs; qid++) {\n+\t\tstruct pmd_eth_rxq_stats rxq_stats;\n+\n+\t\tmemset(&rxq_stats, 0, sizeof(rxq_stats));\n+\t\tif (dev->dev_ops->rxq_stats_get(dev, qid, &rxq_stats))\n+\t\t\tcontinue;\n+\n+\t\tstats->q_ipackets[qid] = rxq_stats.packets;\n+\t\tstats->q_ibytes[qid] = rxq_stats.bytes;\n+\t\tstats->q_errors[qid] = rxq_stats.errors;\n+\t}\n+\n+skip_rxq:\n+\tif (!dev->dev_ops->txq_stats_get)\n+\t\tgoto out;\n+\tnb_txqs = RTE_MIN(dev->data->nb_tx_queues,\n+\t\t\t RTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\tfor (qid = 0; qid < nb_txqs; qid++) {\n+\t\tstruct pmd_eth_txq_stats txq_stats;\n+\n+\t\tmemset(&txq_stats, 0, sizeof(txq_stats));\n+\t\tif (dev->dev_ops->txq_stats_get(dev, qid, &txq_stats))\n+\t\t\tcontinue;\n+\n+\t\tstats->q_opackets[qid] = txq_stats.packets;\n+\t\tstats->q_obytes[qid] = txq_stats.bytes;\n+\t}\n+\n+out:\n+\treturn ret;\n }\n \n int\n@@ -1969,12 +2019,24 @@ struct rte_eth_dev *\n \tuint16_t nb_rxqs, nb_txqs;\n \tint count;\n \n-\tnb_rxqs = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\tnb_txqs = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\n \tcount = RTE_NB_STATS;\n-\tcount += nb_rxqs * RTE_NB_RXQ_STATS;\n-\tcount += nb_txqs * RTE_NB_TXQ_STATS;\n+\tif (dev->dev_ops->rxq_stats_get) {\n+\t\tnb_rxqs = dev->data->nb_rx_queues;\n+\t\tcount += nb_rxqs * RTE_NB_RXQ_STATS;\n+\t} else {\n+\t\tnb_rxqs = RTE_MIN(dev->data->nb_rx_queues,\n+\t\t\t\t RTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\t\tcount += nb_rxqs * RTE_NB_LEGACY_RXQ_STATS;\n+\t}\n+\n+\tif (dev->dev_ops->txq_stats_get) {\n+\t\tnb_txqs = dev->data->nb_tx_queues;\n+\t\tcount += nb_txqs * RTE_NB_TXQ_STATS;\n+\t} else {\n+\t\tnb_txqs = RTE_MIN(dev->data->nb_tx_queues,\n+\t\t\t\t RTE_ETHDEV_QUEUE_STAT_CNTRS);\n+\t\tcount += nb_txqs * RTE_NB_LEGACY_TXQ_STATS;\n+\t}\n \n \treturn count;\n }\n@@ -2065,27 +2127,59 @@ struct rte_eth_dev *\n \t\t\t\"%s\", rte_stats_strings[idx].name);\n \t\tcnt_used_entries++;\n \t}\n+\n+\tif (dev->dev_ops->rxq_stats_get) {\n+\t\tnum_q = dev->data->nb_rx_queues;\n+\t\tfor (id_queue = 0; id_queue < num_q; id_queue++) {\n+\t\t\tfor (idx = 0; idx < RTE_NB_RXQ_STATS; idx++) {\n+\t\t\t\tsnprintf(xstats_names[cnt_used_entries].name,\n+\t\t\t\t\tsizeof(xstats_names[0].name),\n+\t\t\t\t\t\"rx_q%u%s\",\n+\t\t\t\t\tid_queue, rxq_stats_map[idx].name);\n+\t\t\t\tcnt_used_entries++;\n+\t\t\t}\n+\t\t}\n+\t\tgoto skip_legacy_rxq;\n+\t}\n+\n \tnum_q = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \tfor (id_queue = 0; id_queue < num_q; id_queue++) {\n-\t\tfor (idx = 0; idx < RTE_NB_RXQ_STATS; idx++) {\n+\t\tfor (idx = 0; idx < RTE_NB_LEGACY_RXQ_STATS; idx++) {\n \t\t\tsnprintf(xstats_names[cnt_used_entries].name,\n \t\t\t\tsizeof(xstats_names[0].name),\n \t\t\t\t\"rx_q%u%s\",\n-\t\t\t\tid_queue, rte_rxq_stats_strings[idx].name);\n+\t\t\t\tid_queue, legacy_rxq_stats_map[idx].name);\n \t\t\tcnt_used_entries++;\n \t\t}\n+\t}\n \n+skip_legacy_rxq:\n+\tif (dev->dev_ops->txq_stats_get) {\n+\t\tnum_q = dev->data->nb_tx_queues;\n+\t\tfor (id_queue = 0; id_queue < num_q; id_queue++) {\n+\t\t\tfor (idx = 0; idx < RTE_NB_TXQ_STATS; idx++) {\n+\t\t\t\tsnprintf(xstats_names[cnt_used_entries].name,\n+\t\t\t\t\tsizeof(xstats_names[0].name),\n+\t\t\t\t\t\"tx_q%u%s\",\n+\t\t\t\t\tid_queue, txq_stats_map[idx].name);\n+\t\t\t\tcnt_used_entries++;\n+\t\t\t}\n+\t\t}\n+\t\tgoto skip_legacy_txq;\n \t}\n+\n \tnum_q = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \tfor (id_queue = 0; id_queue < num_q; id_queue++) {\n-\t\tfor (idx = 0; idx < RTE_NB_TXQ_STATS; idx++) {\n+\t\tfor (idx = 0; idx < RTE_NB_LEGACY_TXQ_STATS; idx++) {\n \t\t\tsnprintf(xstats_names[cnt_used_entries].name,\n \t\t\t\tsizeof(xstats_names[0].name),\n \t\t\t\t\"tx_q%u%s\",\n-\t\t\t\tid_queue, rte_txq_stats_strings[idx].name);\n+\t\t\t\tid_queue, legacy_txq_stats_map[idx].name);\n \t\t\tcnt_used_entries++;\n \t\t}\n \t}\n+\n+skip_legacy_txq:\n \treturn cnt_used_entries;\n }\n \n@@ -2252,9 +2346,6 @@ struct rte_eth_dev *\n \n \tdev = &rte_eth_devices[port_id];\n \n-\tnb_rxqs = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\tnb_txqs = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\n \t/* global stats */\n \tfor (i = 0; i < RTE_NB_STATS; i++) {\n \t\tstats_ptr = RTE_PTR_ADD(ð_stats,\n@@ -2264,26 +2355,71 @@ struct rte_eth_dev *\n \t}\n \n \t/* per-rxq stats */\n+\tif (dev->dev_ops->rxq_stats_get) {\n+\t\tnb_rxqs = dev->data->nb_rx_queues;\n+\t\tfor (q = 0; q < nb_rxqs; q++) {\n+\t\t\tstruct pmd_eth_rxq_stats rxq_stats;\n+\n+\t\t\tmemset(&rxq_stats, 0, sizeof(rxq_stats));\n+\t\t\tif (dev->dev_ops->rxq_stats_get(dev, q, &rxq_stats)) {\n+\t\t\t\tcount += RTE_NB_RXQ_STATS;\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\t\t\tfor (i = 0; i < RTE_NB_RXQ_STATS; i++) {\n+\t\t\t\tstats_ptr = RTE_PTR_ADD(&rxq_stats,\n+\t\t\t\t\t\trxq_stats_map[i].offset);\n+\t\t\t\tval = *stats_ptr;\n+\t\t\t\txstats[count++].value = val;\n+\t\t\t}\n+\t\t}\n+\t\tgoto skip_legacy_rxq;\n+\t}\n+\n+\tnb_rxqs = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \tfor (q = 0; q < nb_rxqs; q++) {\n-\t\tfor (i = 0; i < RTE_NB_RXQ_STATS; i++) {\n+\t\tfor (i = 0; i < RTE_NB_LEGACY_RXQ_STATS; i++) {\n \t\t\tstats_ptr = RTE_PTR_ADD(ð_stats,\n-\t\t\t\t\trte_rxq_stats_strings[i].offset +\n+\t\t\t\t\tlegacy_rxq_stats_map[i].offset +\n \t\t\t\t\tq * sizeof(uint64_t));\n \t\t\tval = *stats_ptr;\n \t\t\txstats[count++].value = val;\n \t\t}\n \t}\n \n+skip_legacy_rxq:\n \t/* per-txq stats */\n+\tif (dev->dev_ops->txq_stats_get) {\n+\t\tnb_txqs = dev->data->nb_tx_queues;\n+\t\tfor (q = 0; q < nb_txqs; q++) {\n+\t\t\tstruct pmd_eth_txq_stats txq_stats;\n+\n+\t\t\tmemset(&txq_stats, 0, sizeof(txq_stats));\n+\t\t\tif (dev->dev_ops->txq_stats_get(dev, q, &txq_stats)) {\n+\t\t\t\tcount += RTE_NB_TXQ_STATS;\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\t\t\tfor (i = 0; i < RTE_NB_TXQ_STATS; i++) {\n+\t\t\t\tstats_ptr = RTE_PTR_ADD(&txq_stats,\n+\t\t\t\t\t\ttxq_stats_map[i].offset);\n+\t\t\t\tval = *stats_ptr;\n+\t\t\t\txstats[count++].value = val;\n+\t\t\t}\n+\t\t}\n+\t\tgoto skip_legacy_txq;\n+\t}\n+\n+\tnb_txqs = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n \tfor (q = 0; q < nb_txqs; q++) {\n-\t\tfor (i = 0; i < RTE_NB_TXQ_STATS; i++) {\n+\t\tfor (i = 0; i < RTE_NB_LEGACY_TXQ_STATS; i++) {\n \t\t\tstats_ptr = RTE_PTR_ADD(ð_stats,\n-\t\t\t\t\trte_txq_stats_strings[i].offset +\n+\t\t\t\t\tlegacy_txq_stats_map[i].offset +\n \t\t\t\t\tq * sizeof(uint64_t));\n \t\t\tval = *stats_ptr;\n \t\t\txstats[count++].value = val;\n \t\t}\n \t}\n+\n+skip_legacy_txq:\n \treturn count;\n }\n \n@@ -2387,19 +2523,14 @@ struct rte_eth_dev *\n \tstruct rte_eth_dev *dev;\n \tunsigned int count = 0, i;\n \tsigned int xcount = 0;\n-\tuint16_t nb_rxqs, nb_txqs;\n \tint ret;\n \n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -EINVAL);\n \n \tdev = &rte_eth_devices[port_id];\n \n-\tnb_rxqs = RTE_MIN(dev->data->nb_rx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\tnb_txqs = RTE_MIN(dev->data->nb_tx_queues, RTE_ETHDEV_QUEUE_STAT_CNTRS);\n-\n \t/* Return generic statistics */\n-\tcount = RTE_NB_STATS + (nb_rxqs * RTE_NB_RXQ_STATS) +\n-\t\t(nb_txqs * RTE_NB_TXQ_STATS);\n+\tcount = get_xstats_basic_count(dev);\n \n \t/* implemented by the driver */\n \tif (dev->dev_ops->xstats_get != NULL) {\ndiff --git a/lib/librte_ethdev/rte_ethdev_core.h b/lib/librte_ethdev/rte_ethdev_core.h\nindex 8f03f83..63375fe 100644\n--- a/lib/librte_ethdev/rte_ethdev_core.h\n+++ b/lib/librte_ethdev/rte_ethdev_core.h\n@@ -97,6 +97,16 @@ typedef int (*eth_xstats_get_names_by_id_t)(struct rte_eth_dev *dev,\n \tunsigned int size);\n /**< @internal Get names of extended stats of an Ethernet device. */\n \n+struct pmd_eth_rxq_stats;\n+typedef int (*eth_rxq_stats_get)(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n+\tstruct pmd_eth_rxq_stats *rx_queue_stats);\n+/**< @internal Get statistics for a rx queue of an Ethernet device. */\n+\n+struct pmd_eth_txq_stats;\n+typedef int (*eth_txq_stats_get)(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n+\tstruct pmd_eth_txq_stats *tx_queue_stats);\n+/**< @internal Get statistics for a tx queue of an Ethernet device. */\n+\n typedef int (*eth_queue_stats_mapping_set_t)(struct rte_eth_dev *dev,\n \t\t\t\t\t uint16_t queue_id,\n \t\t\t\t\t uint8_t stat_idx,\n@@ -501,6 +511,9 @@ struct eth_dev_ops {\n \teth_xstats_get_names_by_id_t xstats_get_names_by_id;\n \t/**< Get name of extended device statistics by ID. */\n \n+\teth_rxq_stats_get rxq_stats_get; /**< Stats per rxq */\n+\teth_txq_stats_get txq_stats_get; /**< Stats per txq */\n+\n \teth_tm_ops_get_t tm_ops_get;\n \t/**< Get Traffic Management (TM) operations. */\n \ndiff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h\nindex c2ac263..33a4b22 100644\n--- a/lib/librte_ethdev/rte_ethdev_driver.h\n+++ b/lib/librte_ethdev/rte_ethdev_driver.h\n@@ -331,6 +331,24 @@ typedef int (*ethdev_bus_specific_init)(struct rte_eth_dev *ethdev,\n int __rte_experimental\n rte_eth_dev_destroy(struct rte_eth_dev *ethdev, ethdev_uninit_t ethdev_uninit);\n \n+/**\n+ * @internal\n+ *\n+ * Internal structures used by PMD to provide the per rx/tx queues to the\n+ * ethdev layer.\n+ */\n+struct pmd_eth_rxq_stats {\n+\tuint64_t packets;\n+\tuint64_t bytes;\n+\tuint64_t errors;\n+};\n+\n+struct pmd_eth_txq_stats {\n+\tuint64_t packets;\n+\tuint64_t bytes;\n+\tuint64_t errors;\n+};\n+\n #ifdef __cplusplus\n }\n #endif\n", "prefixes": [ "RFC", "1/2" ] }