Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51156/?format=api
{ "id": 51156, "url": "https://patches.dpdk.org/api/patches/51156/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190313151858.2175-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190313151858.2175-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190313151858.2175-1-stephen@networkplumber.org", "date": "2019-03-13T15:18:58", "name": "[RFC] net/vdev_netvsc: check for required related drivers", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "c938f5707003cf367a597d6f7775f982bd14ae5a", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190313151858.2175-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 3733, "url": "https://patches.dpdk.org/api/series/3733/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3733", "date": "2019-03-13T15:18:58", "name": "[RFC] net/vdev_netvsc: check for required related drivers", "version": 1, "mbox": "https://patches.dpdk.org/series/3733/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51156/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/51156/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ED1994C9C;\n\tWed, 13 Mar 2019 16:19:04 +0100 (CET)", "from mail-pg1-f171.google.com (mail-pg1-f171.google.com\n\t[209.85.215.171]) by dpdk.org (Postfix) with ESMTP id 92966239\n\tfor <dev@dpdk.org>; Wed, 13 Mar 2019 16:19:03 +0100 (CET)", "by mail-pg1-f171.google.com with SMTP id u9so1746853pgo.7\n\tfor <dev@dpdk.org>; Wed, 13 Mar 2019 08:19:03 -0700 (PDT)", "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\ta20sm27353019pfj.5.2019.03.13.08.19.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 13 Mar 2019 08:19:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=79ASHhtowW6RpqVT0qdxBZiZqnKpSFBdYVwsbs2tOxE=;\n\tb=ecn2TA6N4/SyCAzvRbpxiO7zYoSQVCY93dUTm58qLhowWEflGdqFnaTKyaEsLL7SKi\n\tmm18oKqZtzf2TDjeO2WgvvF2wXfdQ+xVRCmdXAkqFFstP0SzcO23xm/F6Xb85S+faPpG\n\t4VvPWvJbMk4OWH/S+3fzhoXHvL5zgXjC1rjMdahHHowio1yMPTi+qwkoBYVGi0fwvaqL\n\thEBHMuXQ3XiDIhk8ZdjjuL0JbFQX4Ld8W777kDWgDSY3Pn5JkMxbOX8O4NKlJAYDgmzs\n\t9i63nzMGi0WUlFIYrjCsosq7c6/6j+ytmeXtfATBEOgK10mi89umL9MQPZYs3ahxt0Cy\n\t5blA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=79ASHhtowW6RpqVT0qdxBZiZqnKpSFBdYVwsbs2tOxE=;\n\tb=s8pNbgZTzslpMBgOnYcXzVlsBMMhQ+R9qO648Xw6b41D44s1/hbTrAg8/ITv7OVE/V\n\tbRi0iN8crxSNugJTwBslaqSetA81sGQE+6mpikYJwqBO54M10Sqr7yqhTSDVzcbHLUD6\n\t4OxwYPird5vagTq1fXQ5aE2OpijzzyPip4kgT1N+yIV1R4yJwu6Us/HE8P8YW1WFlIYi\n\tB/MItLuEtaMEHUEdvaD/9uLgmS8lK4+jc6+gJzbvohMugRdUqWDqC8Yf42TitznOrT4j\n\tlL9m1PFaNB5q1mvJxIyMAqriXdim9eWSRqApdnP/3xlinH19u+3pySXXtexEzRVEOPxw\n\tzUBA==", "X-Gm-Message-State": "APjAAAV3Uxr6G255reLYAnPUvp2L0hOXVpHt9wTrSmeRbuabvslM4sW1\n\tHaY7x8QAqF02XBSQ8WA07/zuo6utXOMIdQ==", "X-Google-Smtp-Source": "APXvYqwW2L65cywn8evFHjn4EgfdeOUC2GmLm67Ziproya1cldmpYjhGwNN9eccA1c2527wcEIvfPQ==", "X-Received": "by 2002:a65:510c:: with SMTP id\n\tf12mr41326666pgq.40.1552490341595; \n\tWed, 13 Mar 2019 08:19:01 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org,\n\tvpp-dev@lists.fd.io", "Cc": "Stephen Hemminger <stephen@networkplumber.org>", "Date": "Wed, 13 Mar 2019 08:18:58 -0700", "Message-Id": "<20190313151858.2175-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [RFC] net/vdev_netvsc: check for required related drivers", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The vdev_netvsc virtual driver that is used to do initialization\non Hyper-V/Azure won't work without failsafe and tap device.\nIf the related devices aren't present, it causes confusing errors\nlater in initialization when it crafts devargs and attempts to\nsend them to a device driver that isn't there.\n\nUnfortunately, this is common with VPP where the TAP and FAILSAFE\nPMD's are both optional. The suggestion here is to detect this\nin the startup phase earlier.\n\nAlternative would be to use RTE_BUILD_BUG_ON(!defined(...))\nbut that would break people doing normal VPP build.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/vdev_netvsc/vdev_netvsc.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)", "diff": "diff --git a/drivers/net/vdev_netvsc/vdev_netvsc.c b/drivers/net/vdev_netvsc/vdev_netvsc.c\nindex 801f54c96e01..9c262358b5ee 100644\n--- a/drivers/net/vdev_netvsc/vdev_netvsc.c\n+++ b/drivers/net/vdev_netvsc/vdev_netvsc.c\n@@ -812,6 +812,20 @@ vdev_netvsc_scan_callback(__rte_unused void *arg)\n \tstruct rte_devargs *devargs;\n \tstruct rte_bus *vbus = rte_bus_find_by_name(\"vdev\");\n \n+\tdev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,\n+\t\t\t\t\"net_failsafe\");\n+\tif (!dev) {\n+\t\tDRV_LOG(ERR, \"failsafe network device not present\");\n+\t\treturn;\n+\t}\n+\n+\tdev = vbus->find_device(NULL, vdev_netvsc_cmp_rte_device,\n+\t\t\t\t\"net_tap\");\n+\tif (!dev) {\n+\t\tDRV_LOG(ERR, \"tap network device driver not present\");\n+\t\treturn;\n+\t}\n+\n \tRTE_EAL_DEVARGS_FOREACH(\"vdev\", devargs)\n \t\tif (!strncmp(devargs->name, VDEV_NETVSC_DRIVER_NAME,\n \t\t\t VDEV_NETVSC_DRIVER_NAME_LEN))\n", "prefixes": [ "RFC" ] }