Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51139/?format=api
{ "id": 51139, "url": "https://patches.dpdk.org/api/patches/51139/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190312171152.28637-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190312171152.28637-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190312171152.28637-3-stephen@networkplumber.org", "date": "2019-03-12T17:11:52", "name": "[v2,2/2] bus/fslmc: remove unneeded strdup", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2a0922111973aaf703392fe13bc5ce0ca19d132a", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190312171152.28637-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 3723, "url": "https://patches.dpdk.org/api/series/3723/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3723", "date": "2019-03-12T17:11:50", "name": "bus/fslmc: logging fixes", "version": 2, "mbox": "https://patches.dpdk.org/series/3723/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51139/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/51139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BB8CF4CAB;\n\tTue, 12 Mar 2019 18:12:02 +0100 (CET)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 302A14C99\n\tfor <dev@dpdk.org>; Tue, 12 Mar 2019 18:12:01 +0100 (CET)", "by mail-pf1-f194.google.com with SMTP id a3so2265688pff.11\n\tfor <dev@dpdk.org>; Tue, 12 Mar 2019 10:12:01 -0700 (PDT)", "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\ta66sm25246593pfj.153.2019.03.12.10.11.58\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 12 Mar 2019 10:11:58 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=4WbF4IlsAiN2XTrgtStKuRV3mtpQWNnd0gVRKkatbYM=;\n\tb=RlffI/H06/6NpIOa6LiT478PTwLSqURQIwl8JyPKYCjTK28G3O/1NQRMjRg7WdJAOc\n\tfcKIlihQFI8ju2A9z6c7jAAbn6T0Ukz8r7YTUq4MhLkZio8kzW48KMmzngLzC1tkpkxL\n\tqp11GYmEuKm4jotrZbIFmMXOkPex0usL0/XawcDYZAHTWOSA4eTFyACldaRA0XdTgb96\n\tohoAveJN4dCNirS8oYOT/MLLH1777855IRy/Zr3miz4wphsO2Loz/vYHtMXW0Ap+cD5D\n\tE221DFSyXVhIiihZW5Df8GBwuzsN/1JV2BzYEaz0AhBNIH6fRWt+pu6M2EmQUPUJrkxe\n\tIzhQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=4WbF4IlsAiN2XTrgtStKuRV3mtpQWNnd0gVRKkatbYM=;\n\tb=reYw7+fW96uiETYB4rZnDL5pP3ryNVSOgzZh62DxX9XEAS1yTTE2AqQLBdNeScO8xk\n\tvv8grI65aQMkqYH4OM6eKVvKwoKTEXLwLDClrs9J9AENMzcfoVHpaPsJ9pLJecq9d48b\n\tu9wyC3F6LO7o7Ofppf9AOJjfouKB4W6FzpnXNJsYPb5J3tBWMJVsNyFiL2JQ4Ki7iRRQ\n\tcucv534/Xs0bDbhczo6NTQMLSK4O/RDVEesZmmXGCggIAXF8mTg1ryTxDlTnP9Jrpj11\n\tJOaZtVVq45BmRPt135shZZwKMaub8y7qeEs0Ife/6qGa2gae7HvfkmVVazmn7+y3AWmT\n\tsWxg==", "X-Gm-Message-State": "APjAAAWiWFUQf8C3ooPbfnr5ga6NKrgAxBDDf1GTBUH38iNruQ3PIfbA\n\twbsF4APS07MU++FV1iSWyhq+BuAk4H0iXA==", "X-Google-Smtp-Source": "APXvYqxuIWvofjImwJJ2S3szuPpzHg/BJiPXuFykwrLz0th6kwABjYWa2f0w9zNOABVLhktghwUFCg==", "X-Received": "by 2002:a17:902:9f94:: with SMTP id\n\tg20mr41456187plq.0.1552410720339; \n\tTue, 12 Mar 2019 10:12:00 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "hemant.agrawal@nxp.com,\n\tshreyansh.jain@nxp.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 12 Mar 2019 10:11:52 -0700", "Message-Id": "<20190312171152.28637-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190312171152.28637-1-stephen@networkplumber.org>", "References": "<20190312171152.28637-1-stephen@networkplumber.org>", "Subject": "[dpdk-dev] [PATCH v2 2/2] bus/fslmc: remove unneeded strdup", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The fslmc bus code was duplicating the device name and\ndoing extra initialization. The code can be simplified\nto just use the device name directly.\n\nCompile tested only; do not have this hardware.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/bus/fslmc/fslmc_bus.c | 38 +++++++++++------------------------\n 1 file changed, 12 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c\nindex a2525780cd08..eaa39a2093e0 100644\n--- a/drivers/bus/fslmc/fslmc_bus.c\n+++ b/drivers/bus/fslmc/fslmc_bus.c\n@@ -229,49 +229,35 @@ static int\n rte_fslmc_parse(const char *name, void *addr)\n {\n \tuint16_t dev_id;\n-\tchar *t_ptr = NULL, *dname = NULL;\n+\tchar *t_ptr;\n \n \t/* 'name' is expected to contain name of device, for example, dpio.1,\n \t * dpni.2, etc.\n \t */\n-\n-\tdname = strdup(name);\n-\tif (!dname)\n-\t\treturn -EINVAL;\n-\tt_ptr = dname;\n-\n-\tif (strncmp(\"dpni\", t_ptr, 4) &&\n-\t strncmp(\"dpseci\", t_ptr, 6) &&\n-\t strncmp(\"dpcon\", t_ptr, 5) &&\n-\t strncmp(\"dpbp\", t_ptr, 4) &&\n-\t strncmp(\"dpio\", t_ptr, 4) &&\n-\t strncmp(\"dpci\", t_ptr, 4) &&\n-\t strncmp(\"dpmcp\", t_ptr, 5) &&\n-\t strncmp(\"dpdmai\", t_ptr, 6) &&\n-\t strncmp(\"dpdmux\", t_ptr, 6)) {\n+\tif (strncmp(\"dpni\", name, 4) &&\n+\t strncmp(\"dpseci\", name, 6) &&\n+\t strncmp(\"dpcon\", name, 5) &&\n+\t strncmp(\"dpbp\", name, 4) &&\n+\t strncmp(\"dpio\", name, 4) &&\n+\t strncmp(\"dpci\", name, 4) &&\n+\t strncmp(\"dpmcp\", name, 5) &&\n+\t strncmp(\"dpdmai\", name, 6) &&\n+\t strncmp(\"dpdmux\", name, 6)) {\n \t\tDPAA2_BUS_DEBUG(\"Unknown or unsupported device (%s)\", name);\n \t\tgoto err_out;\n \t}\n \n \tt_ptr = strchr(name, '.');\n-\tif (!t_ptr) {\n-\t\tDPAA2_BUS_ERR(\"Incorrect device string observed (%s)\", t_ptr);\n-\t\tgoto err_out;\n-\t}\n-\n-\tt_ptr = (char *)(t_ptr + 1);\n-\tif (sscanf(t_ptr, \"%hu\", &dev_id) <= 0) {\n-\t\tDPAA2_BUS_ERR(\"Incorrect device string observed (%s)\", t_ptr);\n+\tif (!t_ptr || sscanf(t_ptr + 1, \"%hu\", &dev_id) != 1) {\n+\t\tDPAA2_BUS_ERR(\"Missing device id in device name (%s)\", name);\n \t\tgoto err_out;\n \t}\n-\tfree(dname);\n \n \tif (addr)\n \t\tstrcpy(addr, name);\n \n \treturn 0;\n err_out:\n-\tfree(dname);\n \treturn -EINVAL;\n }\n \n", "prefixes": [ "v2", "2/2" ] }