Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/51115/?format=api
{ "id": 51115, "url": "https://patches.dpdk.org/api/patches/51115/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190312101836.18447-1-ncopa@alpinelinux.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190312101836.18447-1-ncopa@alpinelinux.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190312101836.18447-1-ncopa@alpinelinux.org", "date": "2019-03-12T10:18:36", "name": "[v2,04/15] bus/pci: factor out various ifdefs in pci_uio_ioport_{read, write}", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "2bd7418d6f787ca8915e6cfb377118e6a860eb72", "submitter": { "id": 1242, "url": "https://patches.dpdk.org/api/people/1242/?format=api", "name": "Natanael Copa", "email": "ncopa@alpinelinux.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190312101836.18447-1-ncopa@alpinelinux.org/mbox/", "series": [ { "id": 3715, "url": "https://patches.dpdk.org/api/series/3715/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3715", "date": "2019-03-12T10:16:30", "name": null, "version": 2, "mbox": "https://patches.dpdk.org/series/3715/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/51115/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/51115/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 90BE24C9D;\n\tTue, 12 Mar 2019 11:18:51 +0100 (CET)", "from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25])\n\tby dpdk.org (Postfix) with ESMTP id 7CCA8239\n\tfor <dev@dpdk.org>; Tue, 12 Mar 2019 11:18:49 +0100 (CET)", "from mx1.tetrasec.net (mail.local [127.0.0.1])\n\tby mx1.tetrasec.net (Postfix) with ESMTP id 839479E0455;\n\tTue, 12 Mar 2019 10:18:48 +0000 (UTC)", "from ncopa-desktop.lan (67.63.200.37.customer.cdi.no\n\t[37.200.63.67])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\t(Authenticated sender: n@tanael.org)\n\tby mx1.tetrasec.net (Postfix) with ESMTPSA id A787E9E0026;\n\tTue, 12 Mar 2019 10:18:47 +0000 (UTC)" ], "From": "Natanael Copa <ncopa@alpinelinux.org>", "To": "dev@dpdk.org", "Cc": "Natanael Copa <ncopa@alpinelinux.org>", "Date": "Tue, 12 Mar 2019 11:18:36 +0100", "Message-Id": "<20190312101836.18447-1-ncopa@alpinelinux.org>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190311173702.24471-5-ncopa@alpinelinux.org>", "References": "<20190311173702.24471-5-ncopa@alpinelinux.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "Subject": "[dpdk-dev] [PATCH v2 04/15] bus/pci: factor out various ifdefs in\n\tpci_uio_ioport_{read, write}", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "define the macros so we can remove various #if defined(RTE_ARCH_X86)\n\nRef: https://bugs.dpdk.org/show_bug.cgi?id=35#c6\n\nSigned-off-by: Natanael Copa <ncopa@alpinelinux.org>\n---\n\nv1 -> v2 fixed coding style issues reported by checkpatch\n\n drivers/bus/pci/linux/pci_uio.c | 54 +++++++++++++++------------------\n 1 file changed, 24 insertions(+), 30 deletions(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci_uio.c b/drivers/bus/pci/linux/pci_uio.c\nindex e1dd8c875..b0470358d 100644\n--- a/drivers/bus/pci/linux/pci_uio.c\n+++ b/drivers/bus/pci/linux/pci_uio.c\n@@ -14,11 +14,18 @@\n \n #if defined(RTE_ARCH_X86)\n #include <sys/io.h>\n+\n+#define pci_uio_inl(reg) inl(reg)\n+#define pci_uio_inw(reg) inw(reg)\n+#define pci_uio_inb(reg) inb(reg)\n+\n #if defined(__GLIBC__)\n+\n #define pci_uio_outl_p outl_p\n #define pci_uio_outw_p outw_p\n #define pci_uio_outb_p outb_p\n-#else\n+\n+#else /* defined(__GLIBC__) */\n static inline void\n pci_uio_outl_p(unsigned int value, unsigned short int port)\n {\n@@ -39,8 +46,19 @@ pci_uio_outb_p(unsigned char value, unsigned short int port)\n \t__asm__ __volatile__ (\"outb %b0,%w1\\noutb %%al,$0x80\" : : \"a\" (value),\n \t\t\t \"Nd\" (port));\n }\n-#endif\n-#endif\n+#endif /* defined(__GLIBC__) */\n+\n+#else /* RTE_ARCH_X86 */\n+\n+#define pci_uio_inl(reg) (*(volatile uint32_t *)(reg))\n+#define pci_uio_inw(reg) (*(volatile uint16_t *)(reg))\n+#define pci_uio_inb(reg) (*(volatile uint8_t *)(reg))\n+\n+#define pci_uio_outl_p(value, reg) (*(volatile uint32_t *)(reg) = (value))\n+#define pci_uio_outw_p(value, reg) (*(volatile uint16_t *)(reg) = (value))\n+#define pci_uio_outb_p(value, reg) (*(volatile uint8_t *)(reg) = (value))\n+\n+#endif /* RTE_ARCH_X86 */\n \n #include <rte_log.h>\n #include <rte_pci.h>\n@@ -518,25 +536,13 @@ pci_uio_ioport_read(struct rte_pci_ioport *p,\n \tfor (d = data; len > 0; d += size, reg += size, len -= size) {\n \t\tif (len >= 4) {\n \t\t\tsize = 4;\n-#if defined(RTE_ARCH_X86)\n-\t\t\t*(uint32_t *)d = inl(reg);\n-#else\n-\t\t\t*(uint32_t *)d = *(volatile uint32_t *)reg;\n-#endif\n+\t\t\t*(uint32_t *)d = pci_uio_inl(reg);\n \t\t} else if (len >= 2) {\n \t\t\tsize = 2;\n-#if defined(RTE_ARCH_X86)\n-\t\t\t*(uint16_t *)d = inw(reg);\n-#else\n-\t\t\t*(uint16_t *)d = *(volatile uint16_t *)reg;\n-#endif\n+\t\t\t*(uint16_t *)d = pci_uio_inw(reg);\n \t\t} else {\n \t\t\tsize = 1;\n-#if defined(RTE_ARCH_X86)\n-\t\t\t*d = inb(reg);\n-#else\n-\t\t\t*d = *(volatile uint8_t *)reg;\n-#endif\n+\t\t\t*d = pci_uio_inb(reg);\n \t\t}\n \t}\n }\n@@ -552,25 +558,13 @@ pci_uio_ioport_write(struct rte_pci_ioport *p,\n \tfor (s = data; len > 0; s += size, reg += size, len -= size) {\n \t\tif (len >= 4) {\n \t\t\tsize = 4;\n-#if defined(RTE_ARCH_X86)\n \t\t\tpci_uio_outl_p(*(const uint32_t *)s, reg);\n-#else\n-\t\t\t*(volatile uint32_t *)reg = *(const uint32_t *)s;\n-#endif\n \t\t} else if (len >= 2) {\n \t\t\tsize = 2;\n-#if defined(RTE_ARCH_X86)\n \t\t\tpci_uio_outw_p(*(const uint16_t *)s, reg);\n-#else\n-\t\t\t*(volatile uint16_t *)reg = *(const uint16_t *)s;\n-#endif\n \t\t} else {\n \t\t\tsize = 1;\n-#if defined(RTE_ARCH_X86)\n \t\t\tpci_uio_outb_p(*s, reg);\n-#else\n-\t\t\t*(volatile uint8_t *)reg = *s;\n-#endif\n \t\t}\n \t}\n }\n", "prefixes": [ "v2", "04/15" ] }