Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5088,
    "url": "https://patches.dpdk.org/api/patches/5088/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1433255928-11461-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1433255928-11461-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1433255928-11461-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2015-06-02T14:38:48",
    "name": "[dpdk-dev] examples/load_balancer: fix build with gcc 5.1",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2ff5701dabc7de538e785caa92b19b0795878984",
    "submitter": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1433255928-11461-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/5088/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/5088/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D2A51C350;\n\tTue,  2 Jun 2015 16:39:42 +0200 (CEST)",
            "from mail-wi0-f169.google.com (mail-wi0-f169.google.com\n\t[209.85.212.169]) by dpdk.org (Postfix) with ESMTP id B2E5EC34A\n\tfor <dev@dpdk.org>; Tue,  2 Jun 2015 16:39:41 +0200 (CEST)",
            "by wikd7 with SMTP id d7so15757845wik.0\n\tfor <dev@dpdk.org>; Tue, 02 Jun 2015 07:39:41 -0700 (PDT)",
            "from localhost.localdomain (136-92-190-109.dsl.ovh.fr.\n\t[109.190.92.136])\n\tby mx.google.com with ESMTPSA id d3sm9148173wic.1.2015.06.02.07.39.40\n\tfor <dev@dpdk.org>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 02 Jun 2015 07:39:40 -0700 (PDT)"
        ],
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id;\n\tbh=/kXyq120++9OzsGPUM4xdv1on9G85XEULK07aSOkIsI=;\n\tb=b6jf4D0rFLJXEGNW5ouGs6geshBiuWxstOIIZ5JLUWSohgIOuuYUJ1zfOLIGEqoKJa\n\tBQEEkUy/QLyE04F35W7KNW2sICm2BMP2UY91SA7r9ElB1Xy/qy9zlNZHMI7KdUXibmVp\n\tmKjwPHX0U7u9vydqhl4Oks4BpXVXbbNifTFEY889A48EeRIFEjSv5gyaynh+uTfFKHSO\n\tcdENAAfLm/XncH2FgZxsAASf3GxlA4PfuIlfvIMYlB2WXfx4TD+GQhbTp7bcXXDu2Urq\n\tjGwQyXnaPU/3SgvH7/PjigNrD3dSWNAmr2eMRdNkgmbneDpZvGHpQYT5MGjz/hEy1Dgk\n\tblxg==",
        "X-Gm-Message-State": "ALoCoQlKvimnQr26ShEnwqtl67PxObeyYvP0BOAcfmckWCTfWWhTQ9TpHHJmRaCe+fzXj3iAcUiy",
        "X-Received": "by 10.194.5.135 with SMTP id s7mr52429142wjs.115.1433255981567; \n\tTue, 02 Jun 2015 07:39:41 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue,  2 Jun 2015 16:38:48 +0200",
        "Message-Id": "<1433255928-11461-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.4.2",
        "Subject": "[dpdk-dev] [PATCH] examples/load_balancer: fix build with gcc 5.1",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "GCC 5.1 detects more out-of-bounds accesses:\n\terror: array subscript is above array bounds [-Werror=array-bounds]\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n examples/load_balancer/config.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/examples/load_balancer/config.c b/examples/load_balancer/config.c\nindex 35f1441..3f6ddee 100644\n--- a/examples/load_balancer/config.c\n+++ b/examples/load_balancer/config.c\n@@ -231,7 +231,9 @@ parse_arg_rx(const char *arg)\n \t\t\treturn -7;\n \t\t}\n \t\tlp->type = e_APP_LCORE_IO;\n-\t\tfor (i = 0; i < lp->io.rx.n_nic_queues; i ++) {\n+\t\tconst size_t n_queues = RTE_MIN(lp->io.rx.n_nic_queues,\n+\t\t                                RTE_DIM(lp->io.rx.nic_queues));\n+\t\tfor (i = 0; i < n_queues; i ++) {\n \t\t\tif ((lp->io.rx.nic_queues[i].port == port) &&\n \t\t\t    (lp->io.rx.nic_queues[i].queue == queue)) {\n \t\t\t\treturn -8;\n@@ -308,7 +310,9 @@ parse_arg_tx(const char *arg)\n \t\t\treturn -7;\n \t\t}\n \t\tlp->type = e_APP_LCORE_IO;\n-\t\tfor (i = 0; i < lp->io.tx.n_nic_ports; i ++) {\n+\t\tconst size_t n_ports = RTE_MIN(lp->io.tx.n_nic_ports,\n+\t\t                               RTE_DIM(lp->io.tx.nic_ports));\n+\t\tfor (i = 0; i < n_ports; i ++) {\n \t\t\tif (lp->io.tx.nic_ports[i] == port) {\n \t\t\t\treturn -8;\n \t\t\t}\n@@ -791,7 +795,9 @@ app_get_lcore_for_nic_rx(uint8_t port, uint8_t queue, uint32_t *lcore_out)\n \t\t\tcontinue;\n \t\t}\n \n-\t\tfor (i = 0; i < lp->rx.n_nic_queues; i ++) {\n+\t\tconst size_t n_queues = RTE_MIN(lp->rx.n_nic_queues,\n+\t\t                                RTE_DIM(lp->rx.nic_queues));\n+\t\tfor (i = 0; i < n_queues; i ++) {\n \t\t\tif ((lp->rx.nic_queues[i].port == port) &&\n \t\t\t    (lp->rx.nic_queues[i].queue == queue)) {\n \t\t\t\t*lcore_out = lcore;\n@@ -816,7 +822,9 @@ app_get_lcore_for_nic_tx(uint8_t port, uint32_t *lcore_out)\n \t\t\tcontinue;\n \t\t}\n \n-\t\tfor (i = 0; i < lp->tx.n_nic_ports; i ++) {\n+\t\tconst size_t n_ports = RTE_MIN(lp->tx.n_nic_ports,\n+\t\t                               RTE_DIM(lp->tx.nic_ports));\n+\t\tfor (i = 0; i < n_ports; i ++) {\n \t\t\tif (lp->tx.nic_ports[i] == port) {\n \t\t\t\t*lcore_out = lcore;\n \t\t\t\treturn 0;\n",
    "prefixes": [
        "dpdk-dev"
    ]
}