Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50764/?format=api
{ "id": 50764, "url": "https://patches.dpdk.org/api/patches/50764/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com", "date": "2019-03-02T12:10:49", "name": "[04/10] net/atlantic: fix buffer overflow", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "083c00efd7920ddbd6ab08f505e67f5ac73d405c", "submitter": { "id": 1124, "url": "https://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 3614, "url": "https://patches.dpdk.org/api/series/3614/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3614", "date": "2019-03-02T12:10:41", "name": "net/atlantic: bugfixes and code cleanup", "version": 1, "mbox": "https://patches.dpdk.org/series/3614/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50764/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50764/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id DFF864C9C;\n\tSat, 2 Mar 2019 13:10:52 +0100 (CET)", "from NAM04-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr690066.outbound.protection.outlook.com [40.107.69.66])\n\tby dpdk.org (Postfix) with ESMTP id C687F4C77\n\tfor <dev@dpdk.org>; Sat, 2 Mar 2019 13:10:50 +0100 (CET)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB3867.namprd11.prod.outlook.com (10.255.61.12) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1665.16; Sat, 2 Mar 2019 12:10:49 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::319e:4e9b:b376:5588]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::319e:4e9b:b376:5588%4]) with mapi id 15.20.1643.019;\n\tSat, 2 Mar 2019 12:10:49 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=SvPEK4Eb4qMDLYM48W+EsAFuwd3aJ/PppFcjoX9tqTo=;\n\tb=O/3otVvuFCVXkywFaWPP9w0AYwuuMqSCBUmMJhF5nR6pfFKl63z4PhzyOzvQtBPizsNccuz9MOvXBerj0jYS1Y3E+w0tZP3KL77VTZlCDmt3m0OmTkuVOgB40Lefuv9lUWdM0xUYT+UtVm6yS0tQzod2qDwknW4m8Nvj2Aq01LY=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH 04/10] net/atlantic: fix buffer overflow", "Thread-Index": "AQHU0PD5MQDVHQCc1kussJ9nhQqUJg==", "Date": "Sat, 2 Mar 2019 12:10:49 +0000", "Message-ID": "<98bd8e1bae4b53c5d2231faf8ac45edc44a81a7c.1551528549.git.igor.russkikh@aquantia.com>", "References": "<cover.1551528549.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1551528549.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1P190CA0057.EURP190.PROD.OUTLOOK.COM\n\t(2603:10a6:7:52::46)\n\tTo DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "dd96e484-8d5c-4982-4d7d-08d69f081b7f", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(2017052603328)(7153060)(7193020);\n\tSRVR:DM6PR11MB3867; ", "x-ms-traffictypediagnostic": "DM6PR11MB3867:", "x-microsoft-exchange-diagnostics": "=?iso-8859-1?Q?1; DM6PR11MB3867;\n\t23:Dc4fJBuQ7nX9V77jeb+V7+KL0vXakZbvCF+qtv3?=\n\t=?iso-8859-1?q?Bs58U1HyrIEOSLqXvFveEjmGE?=\n\t=?iso-8859-1?q?WttJc/ewYozwF09Di2zeqKqHgNMgh0ECzWg0rexwHX7ejS2L8A9?=\n\t=?iso-8859-1?q?xeBajRbRyBtvoVp8DwYClV7LsjexbR4Y76yhlCse3cTexaxtZ2+?=\n\t=?iso-8859-1?q?ayCfis+2Mkq1bucV0eZJyWPaW/hnOOxiErUzAJ43r0sqVheOESf?=\n\t=?iso-8859-1?q?m98vwggOLT2Usw2OmmBTw7gg+dVRVFvoDjS+bZnTnoCFaZoUWUa?=\n\t=?iso-8859-1?q?nRyWBxT/alr2imyOxtIJSvMtd32z528guPOn8RPon765Tbz2GHJ?=\n\t=?iso-8859-1?q?bhhsW1V+oqmpMSUW/zn6JQwD5NUN+Evs6qUwJyy5qdlNkq/+x4R?=\n\t=?iso-8859-1?q?DlPdsSx+EjUksXIZzhGlibYM5ZN8dt0st0viBSMrsHkl6l7qqmC?=\n\t=?iso-8859-1?q?y6+5IyR/c88oP2AF+V0OAlpa849727VJwLMBdaZpxnAPdY7cFvd?=\n\t=?iso-8859-1?q?Lcm+y9sOY7k16YuNIM6OWP22wBdcilla/Ah2/yTPb+Q9+E2Pf1P?=\n\t=?iso-8859-1?q?T65mg7AeE9/dLu0Qqx21VzACbZPrcmXcXKGl54gBU6ZWzDJunUE?=\n\t=?iso-8859-1?q?ENnDvuRY+NNnpsJJFJoQRHbQD1fZ428+hIuNVka4kiZVHacj2n6?=\n\t=?iso-8859-1?q?DpTaMsajRmktsd5P2zDGKHH4rc8D/T8CjMEY2/UUPk4UgPHLx5F?=\n\t=?iso-8859-1?q?VzrOR/HV0/pKiSBkM3gwWE2RtwqVmWpjwIdelyJUqS8iqAQLdHo?=\n\t=?iso-8859-1?q?RqIg3S/EeL7kB4tjqutYyaeRIPHdPH5X6mMVJTi2FHzx0VGRvwW?=\n\t=?iso-8859-1?q?Q3ebpeRB211wydz4ziG4KYi13j/I+lrsOOlMB1+Q0KUhpqX+Vbf?=\n\t=?iso-8859-1?q?N4skuCnq9q/8M2oR2VMsusD2KctCiM5EC4CI7oIO7dM+hBBxuK9?=\n\t=?iso-8859-1?q?61SSQodTo37JXkuqzz1HYC3EqZTEIj0u+8y6G2QyRSwFMgCiGEt?=\n\t=?iso-8859-1?q?g/WYxkmxgtzAzf/KN29K5hhhTJfTWq+JR/O4u2C77x3SfsaE5Dx?=\n\t=?iso-8859-1?q?oJmia2lIO/vV67OfDK1KQR88VB9Z2lqhF6dWXNr6qmEzHQBbls8?=\n\t=?iso-8859-1?q?uuvjGkM6ASdTsmVsSl64ODKd98TqFTmV3dNNNiOlF3bqxMUshNe?=\n\t=?iso-8859-1?q?sS/lzBxI4x7BeSmlDZng5cjlZyxx0vB4JPWoC7dnfPPb057u2yt?=\n\t=?iso-8859-1?q?40GpiC6jn/oJAhPUQe6iMsc8UsgPDbCi9BkX1/RhvnpJx/hPk9R?=\n\t=?iso-8859-1?q?2GqeL0CqydPcxsYiQFsdXsrg/qGtSOXqaP84h0LIBJyJ1zc8gfw?=\n\t=?iso-8859-1?q?NQr4GEuO4qDl+EmO+d+psUdLYsFpEJDJmpWlnNXlxVbtooZarKP?=\n\t=?iso-8859-1?q?5ZDWbb1ks0yPwY797ytVYZHx294zjCado2BdYEmGx8nPISmlxie?=\n\t=?iso-8859-1?q?s9j931iV1eRy7aZ6Z5tBr37D8gPQfieRFNopX2rqd/3coQc4=3D?=", "x-microsoft-antispam-prvs": "<DM6PR11MB3867ED60B87DEF24E60EC20598770@DM6PR11MB3867.namprd11.prod.outlook.com>", "x-forefront-prvs": "09645BAC66", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(366004)(346002)(136003)(396003)(39850400004)(199004)(189003)(7736002)(8936002)(36756003)(256004)(1730700003)(71200400001)(6916009)(71190400001)(14444005)(8676002)(54906003)(106356001)(186003)(105586002)(4326008)(2501003)(26005)(305945005)(316002)(5660300002)(86362001)(97736004)(2906002)(102836004)(81156014)(81166006)(53936002)(52116002)(76176011)(3846002)(6506007)(386003)(6116002)(72206003)(6512007)(6436002)(14454004)(5640700003)(66066001)(6486002)(478600001)(25786009)(68736007)(99286004)(107886003)(11346002)(476003)(2616005)(446003)(486006)(2351001)(118296001)(50226002)(44832011);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3867;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "X8pHNmX+KceIhC6gT9LPDDoSSHvTIMMwDFfqSjaBwHWg986KsLzFxr1zgPX0BY2lBqZmMd4LDvNcRQXLazJ5mAtb9vXFSTtmxCteoDcGZRJxyCem0DRpegB6D43ICDE1YLE7ODhx8UY9BCuxsNXhHYOHea4Cwl2V+P57s1ccJxpXaJ3WKfCIQtepuVpTCk3gFP8Zdu6WjkdyGcuz1nL7zSLkwMpMFumxO60AHAPr7B7Aw0VGO2N+h/HgVJdX/NrUGaVdZM9cypmPdPSxxRRDIbVuaaLlxdxgMMhRtigpLZ5LWLnwC1vJ8H/l8HDwmYgyXFTNgiZ60R4cOHrZ85c7Q2RJvRRb8PF5mTTKobMQ4Bz+Z6/zRqVO7aTjpDsF6QgP/IBqnRGN0lJd5Kh5yiyOT8KuD8OCvNIqERScjRJx+fo=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "dd96e484-8d5c-4982-4d7d-08d69f081b7f", "X-MS-Exchange-CrossTenant-originalarrivaltime": "02 Mar 2019 12:10:47.8118\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB3867", "Subject": "[dpdk-dev] [PATCH 04/10] net/atlantic: fix buffer overflow", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <Pavel.Belous@aquantia.com>\n\nFound by Coverity\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\nSigned-off-by: Pavel Belous <Pavel.Belous@aquantia.com>\n---\n drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\nindex 6841d9bce..a155d4aab 100644\n--- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\n+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\n@@ -501,7 +501,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \t/* Write SMBUS request to cfg memory */\n \terr = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr,\n \t\t\t\t(u32 *)(void *)&request,\n-\t\t\t\tRTE_ALIGN(sizeof(request), sizeof(u32)));\n+\t\t\t\tRTE_ALIGN(sizeof(request) / sizeof(u32), sizeof(u32)));\n \n \tif (err < 0)\n \t\treturn err;\n@@ -523,7 +523,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \n \terr = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32),\n \t\t\t&result,\n-\t\t\tRTE_ALIGN(sizeof(result), sizeof(u32)));\n+\t\t\tRTE_ALIGN(sizeof(result) / sizeof(u32), sizeof(u32)));\n \n \tif (err < 0)\n \t\treturn err;\n@@ -558,7 +558,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \t/* Write SMBUS request to cfg memory */\n \terr = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr,\n \t\t\t\t(u32 *)(void *)&request,\n-\t\t\t\tRTE_ALIGN(sizeof(request), sizeof(u32)));\n+\t\t\t\tRTE_ALIGN(sizeof(request) / sizeof(u32), sizeof(u32)));\n \n \tif (err < 0)\n \t\treturn err;\n@@ -589,7 +589,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, u32 *data, u32 len)\n \t/* Read status of write operation */\n \terr = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32),\n \t\t\t\t&result,\n-\t\t\t\tRTE_ALIGN(sizeof(result), sizeof(u32)));\n+\t\t\t\tRTE_ALIGN(sizeof(result) / sizeof(u32), sizeof(u32)));\n \n \tif (err < 0)\n \t\treturn err;\n", "prefixes": [ "04/10" ] }