Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50743/?format=api
{ "id": 50743, "url": "https://patches.dpdk.org/api/patches/50743/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190302024253.15594-2-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190302024253.15594-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20190302024253.15594-2-thomas@monjalon.net", "date": "2019-03-02T02:42:51", "name": "[1/3] eal: remove useless checks for already probed device", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e7a3ce381faa3d04328fa8b0017f3108eec07e6e", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190302024253.15594-2-thomas@monjalon.net/mbox/", "series": [ { "id": 3612, "url": "https://patches.dpdk.org/api/series/3612/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3612", "date": "2019-03-02T02:42:50", "name": "fix error path of multi-process probe", "version": 1, "mbox": "https://patches.dpdk.org/series/3612/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50743/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 540C837AF;\n\tSat, 2 Mar 2019 03:43:33 +0100 (CET)", "from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com\n\t[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 4B9A837A2;\n\tSat, 2 Mar 2019 03:43:31 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.nyi.internal (Postfix) with ESMTP id EC03D21DA6;\n\tFri, 1 Mar 2019 21:43:30 -0500 (EST)", "from mailfrontend1 ([10.202.2.162])\n\tby compute1.internal (MEProxy); Fri, 01 Mar 2019 21:43:30 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id D1DC0E40C1;\n\tFri, 1 Mar 2019 21:43:29 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=BCUIcygcUV\n\tPn/ftLMUSKmC2oPLjSnToBEORvOESJcB4=; b=Y83sgLs4eTJn3j3Kh3marcr4fl\n\tpbh9xLMK1WhDMu+snNixA3Azj6bsWDzXIoBc32L5avQb7svAfFMbTArkXRlxGeqJ\n\tCcA9QS7YfsW39af7QiEX131BVmceFKZuGQp0/FI0LfZq0Xn0HW6AZ/or7L378Eu5\n\te0yAx8/IhvjI4PBAo=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm2; bh=BCUIcygcUVPn/ftLMUSKmC2oPLjSnToBEORvOESJcB4=; b=qYMqVYCy\n\tZiDGVYqzYNFhNnJbPsIYXLJfYcsHlAhHVsIgfFOU4OX8wxt8wG94ULKceo4WzE4n\n\tpveLhwhjshcCIpUB6zmClevYwt5Pa2BuOXJ1T79DTWyDqePcOsZxpWYPsQaEXnBW\n\tAGOnOyu1roChEWh2HTGQm7k58puhwlvlOz/LMad27Wedffctg3Yono8HE/lkubtO\n\tHYU2CO2ZJpIPWuwuX1m/s9wL68423wWjJrJQn5r5v3CLzfSp+ZkeEBtCb7UVfH5M\n\tBU4q55PXWk1IkicMAvjauyaffvkvNM3qoG50r+DU2g6S4lZ3ffVKLx6c89N6pr5f\n\tCOusakWlwg/qFA==" ], "X-ME-Sender": "<xms:0u15XOZmX2d1RqYMewvUMbzRFcfq9t4_cloR7_ibgCH631P4tMDNlw>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgedutddrvdeigdegkecutefuodetggdotefrodftvf\n\tcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu\n\tuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffojghfggfgsedtkeertd\n\tertddtnecuhfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehm\n\tohhnjhgrlhhonhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrg\n\thrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucev\n\tlhhushhtvghrufhiiigvpedt", "X-ME-Proxy": "<xmx:0u15XLD3ZIZErLYIkxfxXoaCsxvY0SacUIlINkHyrhXKIOwFBCduKA>\n\t<xmx:0u15XMb9KhIXHhseh2gQQVUjX22CTsi_41-sKFz5gx7vuSpc-rrDHg>\n\t<xmx:0u15XHjR3XA3sxitWf3NiOYcfvgMlXd3tPaRUx2QZz-z4FblKL5RZA>\n\t<xmx:0u15XL9lS4wZZpYj_m9UfkPVoCRFVFbesPv8RAlhpQYNyHth2yIofA>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "dev@dpdk.org", "Cc": "dariusz.stojaczyk@intel.com,\n\tqi.z.zhang@intel.com,\n\tstable@dpdk.org", "Date": "Sat, 2 Mar 2019 03:42:51 +0100", "Message-Id": "<20190302024253.15594-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190302024253.15594-1-thomas@monjalon.net>", "References": "<20190302024253.15594-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] eal: remove useless checks for already\n\tprobed device", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function eal_dev_hotplug_request_to_secondary() never returns\n-EEXIST result. The case of already probed device is filtered out.\n\nThe test in __handle_secondary_request() was always true.\nThe test in rte_dev_probe() was never true, and that's fine not\nreturning -EEXIST if device is already attached in secondary processes.\n\nFixes: 494db286f37d (\"eal: fix multi-process hotplug if attached in secondary\")\nCc: dariusz.stojaczyk@intel.com\nCc: qi.z.zhang@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_eal/common/eal_common_dev.c | 9 +--------\n lib/librte_eal/common/hotplug_mp.c | 3 +--\n 2 files changed, 2 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_dev.c b/lib/librte_eal/common/eal_common_dev.c\nindex fd7f5ca7d5..048c0b025f 100644\n--- a/lib/librte_eal/common/eal_common_dev.c\n+++ b/lib/librte_eal/common/eal_common_dev.c\n@@ -247,18 +247,11 @@ rte_dev_probe(const char *devargs)\n \t\tgoto rollback;\n \t}\n \n-\t/**\n-\t * if any secondary failed to attach, we need to consider if rollback\n-\t * is necessary.\n-\t */\n+\t/* if any secondary failed to attach, need to rollback. */\n \tif (req.result != 0) {\n \t\tRTE_LOG(ERR, EAL,\n \t\t\t\"Failed to attach device on secondary process\\n\");\n \t\tret = req.result;\n-\n-\t\t/* for -EEXIST, we don't need to rollback. */\n-\t\tif (ret == -EEXIST)\n-\t\t\treturn ret;\n \t\tgoto rollback;\n \t}\n \ndiff --git a/lib/librte_eal/common/hotplug_mp.c b/lib/librte_eal/common/hotplug_mp.c\nindex 4052a5c7fb..94bd1d896e 100644\n--- a/lib/librte_eal/common/hotplug_mp.c\n+++ b/lib/librte_eal/common/hotplug_mp.c\n@@ -110,8 +110,7 @@ __handle_secondary_request(void *param)\n \t\tif (tmp_req.result != 0) {\n \t\t\tret = tmp_req.result;\n \t\t\tRTE_LOG(ERR, EAL, \"Failed to hotplug add device on secondary\\n\");\n-\t\t\tif (ret != -EEXIST)\n-\t\t\t\tgoto rollback;\n+\t\t\tgoto rollback;\n \t\t}\n \t} else if (req->t == EAL_DEV_REQ_TYPE_DETACH) {\n \t\tret = rte_devargs_parse(&da, req->devargs);\n", "prefixes": [ "1/3" ] }