Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50558/?format=api
{ "id": 50558, "url": "https://patches.dpdk.org/api/patches/50558/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1551303948-19746-7-git-send-email-ian.stokes@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1551303948-19746-7-git-send-email-ian.stokes@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1551303948-19746-7-git-send-email-ian.stokes@intel.com", "date": "2019-02-27T21:45:48", "name": "[v1,6/6] net/e1000: set min and max MTU for igb devices", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "4cd845f590608ca1884f4c1a5224188e2256abb4", "submitter": { "id": 306, "url": "https://patches.dpdk.org/api/people/306/?format=api", "name": "Ian Stokes", "email": "ian.stokes@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1551303948-19746-7-git-send-email-ian.stokes@intel.com/mbox/", "series": [ { "id": 3566, "url": "https://patches.dpdk.org/api/series/3566/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3566", "date": "2019-02-27T21:45:42", "name": "ethdev: add min/max MTU to device info", "version": 1, "mbox": "https://patches.dpdk.org/series/3566/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50558/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50558/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 04A9F4C95;\n\tWed, 27 Feb 2019 22:46:07 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 692D94C91\n\tfor <dev@dpdk.org>; Wed, 27 Feb 2019 22:46:05 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Feb 2019 13:46:05 -0800", "from sivswdev08.ir.intel.com (HELO localhost.localdomain)\n\t([10.237.217.47])\n\tby fmsmga008.fm.intel.com with ESMTP; 27 Feb 2019 13:46:03 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.58,420,1544515200\"; d=\"scan'208\";a=\"127759280\"", "From": "Ian Stokes <ian.stokes@intel.com>", "To": "dev@dpdk.org", "Cc": "stephen@networkplumber.org,\n\tIan Stokes <ian.stokes@intel.com>", "Date": "Wed, 27 Feb 2019 21:45:48 +0000", "Message-Id": "<1551303948-19746-7-git-send-email-ian.stokes@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1551303948-19746-1-git-send-email-ian.stokes@intel.com>", "References": "<1551303948-19746-1-git-send-email-ian.stokes@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 6/6] net/e1000: set min and max MTU for igb\n\tdevices", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This commit sets the min and max supported MTU values for igb devices\nvia the eth_igb_info_get() function. Min MTU supported is set to\nETHER_MIN_MTU and max mtu is calculated as the max packet length\nsupported minus the transport overhead. To aid in these calculations\na new MACRO 'E1000_ETH_OVERHEAD' has been introduced to consolidate\noverhead calculation and avoid duplication.\n\nSigned-off-by: Ian Stokes <ian.stokes@intel.com>\n---\n drivers/net/e1000/e1000_ethdev.h | 6 ++++++\n drivers/net/e1000/igb_ethdev.c | 7 +++++--\n 2 files changed, 11 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/e1000/e1000_ethdev.h b/drivers/net/e1000/e1000_ethdev.h\nindex 94edff08e..3e74cd8fe 100644\n--- a/drivers/net/e1000/e1000_ethdev.h\n+++ b/drivers/net/e1000/e1000_ethdev.h\n@@ -89,6 +89,12 @@\n \tETH_RSS_IPV6_UDP_EX)\n \n /*\n+ * The overhead from MTU to max frame size.\n+ * Considering VLAN so a tag needs to be counted.\n+ */\n+#define E1000_ETH_OVERHEAD (ETHER_HDR_LEN + ETHER_CRC_LEN + VLAN_TAG_SIZE)\n+\n+/*\n * Maximum number of Ring Descriptors.\n *\n * Since RDLEN/TDLEN should be multiple of 128 bytes, the number of ring\ndiff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c\nindex 87c9aedf2..b897e8ad4 100644\n--- a/drivers/net/e1000/igb_ethdev.c\n+++ b/drivers/net/e1000/igb_ethdev.c\n@@ -2283,6 +2283,10 @@ eth_igb_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tdev_info->speed_capa = ETH_LINK_SPEED_10M_HD | ETH_LINK_SPEED_10M |\n \t\t\tETH_LINK_SPEED_100M_HD | ETH_LINK_SPEED_100M |\n \t\t\tETH_LINK_SPEED_1G;\n+\n+\tdev_info->max_mtu = dev_info->max_rx_pktlen - E1000_ETH_OVERHEAD;\n+\tdev_info->min_mtu = ETHER_MIN_MTU;\n+\n }\n \n static const uint32_t *\n@@ -4466,8 +4470,7 @@ eth_igb_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n \tuint32_t rctl;\n \tstruct e1000_hw *hw;\n \tstruct rte_eth_dev_info dev_info;\n-\tuint32_t frame_size = mtu + (ETHER_HDR_LEN + ETHER_CRC_LEN +\n-\t\t\t\t VLAN_TAG_SIZE);\n+\tuint32_t frame_size = mtu + E1000_ETH_OVERHEAD;\n \n \thw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n", "prefixes": [ "v1", "6/6" ] }