Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50481/?format=api
{ "id": 50481, "url": "https://patches.dpdk.org/api/patches/50481/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190224233555.31304-1-darek.stojaczyk@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190224233555.31304-1-darek.stojaczyk@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190224233555.31304-1-darek.stojaczyk@gmail.com", "date": "2019-02-24T23:35:55", "name": "vhost: remove vhost-net requirements from generic vhost APIs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ec653c074dcec835612343b5f5eed95035eae845", "submitter": { "id": 1051, "url": "https://patches.dpdk.org/api/people/1051/?format=api", "name": "Dariusz Stojaczyk", "email": "darek.stojaczyk@gmail.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190224233555.31304-1-darek.stojaczyk@gmail.com/mbox/", "series": [ { "id": 3531, "url": "https://patches.dpdk.org/api/series/3531/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3531", "date": "2019-02-24T23:35:55", "name": "vhost: remove vhost-net requirements from generic vhost APIs", "version": 1, "mbox": "https://patches.dpdk.org/series/3531/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50481/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50481/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 666C62C2F;\n\tMon, 25 Feb 2019 00:36:04 +0100 (CET)", "from mail-lf1-f68.google.com (mail-lf1-f68.google.com\n\t[209.85.167.68]) by dpdk.org (Postfix) with ESMTP id E0C272A6A\n\tfor <dev@dpdk.org>; Mon, 25 Feb 2019 00:36:02 +0100 (CET)", "by mail-lf1-f68.google.com with SMTP id q11so5505818lfd.3\n\tfor <dev@dpdk.org>; Sun, 24 Feb 2019 15:36:02 -0800 (PST)", "from localhost.localdomain (89-78-174-111.dynamic.chello.pl.\n\t[89.78.174.111]) by smtp.gmail.com with ESMTPSA id\n\tt14sm2191186lft.96.2019.02.24.15.36.00\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSun, 24 Feb 2019 15:36:01 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=AWznuH4k4p8iwyjoaBx6QkMhpTICU6bfZ4HMk32eZfk=;\n\tb=l3j2umw56qF7NpFe+arXHHBL2Id+LA02Oxv6dAukN6aRndflsMRct/sX4zlP/y9/11\n\tkIgA7v3Gb4ffL0Z9TX9HzR2YL1ikkkMekiK0fa5vQBVGbliqos3VmjftvWMCNt7IPeHG\n\tgyI2YfJt75yup/cLoRiOyjZuunDKtsXcsZVOwZSVCW9rpM9214zUjWsFXjtWvNKXeehm\n\tj7y/UmSU5KuevUBirMTCrfhXckrVJEB9mEuVSabpi0lD54qO7uV3j0XiYT2crHz/SOCQ\n\tbNZDk+Zv85HkF7Ez8qxIWXsj4Y7YgKhxdXzSmV8Ms7CWgkgsFn6TE717qzfwMU45jpVj\n\tJBBw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=AWznuH4k4p8iwyjoaBx6QkMhpTICU6bfZ4HMk32eZfk=;\n\tb=BMpkG5v1hJmTbkBlvDFWR4Hykl2GS15Z++AXgyMF3zlUzUZtVOW1KDpDeAh5ebompH\n\tno0e03XIrV5P9OYMOhut59pm3Ni3lfK7ijP9dgYdDS4LZTKzpMacelW9HEVZvxZGmLhF\n\tpGjFWEdhC1LedhUQqlJtqNibUVEwRS6DvQ4l3mG4iTgKWHQtywEH7vcIEj0aIRRrh7g/\n\ttZ0EwG2602jUyHPE6J9XOIPTaIrMIw+o1Bwyt5C6UmhOOrOGdQs84JjrgDMVaAuwC4L6\n\tIHztVWSft7JgEXW+gHBX8jQYmzgFyrn34Xx0QPJfH7alG0e+3F2KfdowKp06VTTlUr0D\n\t1O1w==", "X-Gm-Message-State": "AHQUAuaPN9cgpbfG6yaSzNJK7Ce9c4993mnORasuOwVUOB/ozGlOwTXD\n\tgPvCqsjbCQh1S41qjZjOXnLpE2VqUxg=", "X-Google-Smtp-Source": "AHgI3IarYZScFfkcY/uGzwt0JJDLauAicuK87K80exBuDFevyTjvpmBxe7DQVf6IjuFkhFdt26pk5Q==", "X-Received": "by 2002:ac2:508e:: with SMTP id f14mr9225840lfm.80.1551051362019;\n\tSun, 24 Feb 2019 15:36:02 -0800 (PST)", "From": "Dariusz Stojaczyk <darek.stojaczyk@gmail.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, maxime.coquelin@redhat.com,\n\tzhihong.wang@intel.com", "Cc": "Darek Stojaczyk <dariusz.stojaczyk@intel.com>", "Date": "Mon, 25 Feb 2019 00:35:55 +0100", "Message-Id": "<20190224233555.31304-1-darek.stojaczyk@gmail.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH] vhost: remove vhost-net requirements from\n\tgeneric vhost APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Darek Stojaczyk <dariusz.stojaczyk@intel.com>\n\nThe rte_vhost API to put data into virtqueues operates\non mbufs and hence it is strictly vhost-net specific.\nExternal backends need to implement virtqueue handling\nfrom scratch and that's just not possible without APIs\nto get/set vring base addresses.\n\nThose relevant APIs are there, but they have a check that\nprevents them from working with any non-vhost-net device.\nThis patch removes those checks.\n\nrte_vhost_get_log_base() is not necessarily needed for\nexternal backends, as other, higher level vhost APIs for\nlive migration are available and could be used instead.\nWe remove the extra check from it anyway for consistency.\n\nSigned-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>\n---\n lib/librte_vhost/vhost.c | 21 ---------------------\n 1 file changed, 21 deletions(-)", "diff": "diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c\nindex 00ec58e01..e480aeac9 100644\n--- a/lib/librte_vhost/vhost.c\n+++ b/lib/librte_vhost/vhost.c\n@@ -766,13 +766,6 @@ int rte_vhost_get_log_base(int vid, uint64_t *log_base,\n \tif (!dev)\n \t\treturn -1;\n \n-\tif (unlikely(!(dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET))) {\n-\t\tRTE_LOG(ERR, VHOST_DATA,\n-\t\t\t\"(%d) %s: built-in vhost net backend is disabled.\\n\",\n-\t\t\tdev->vid, __func__);\n-\t\treturn -1;\n-\t}\n-\n \t*log_base = dev->log_base;\n \t*log_size = dev->log_size;\n \n@@ -787,13 +780,6 @@ int rte_vhost_get_vring_base(int vid, uint16_t queue_id,\n \tif (!dev)\n \t\treturn -1;\n \n-\tif (unlikely(!(dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET))) {\n-\t\tRTE_LOG(ERR, VHOST_DATA,\n-\t\t\t\"(%d) %s: built-in vhost net backend is disabled.\\n\",\n-\t\t\tdev->vid, __func__);\n-\t\treturn -1;\n-\t}\n-\n \t*last_avail_idx = dev->virtqueue[queue_id]->last_avail_idx;\n \t*last_used_idx = dev->virtqueue[queue_id]->last_used_idx;\n \n@@ -808,13 +794,6 @@ int rte_vhost_set_vring_base(int vid, uint16_t queue_id,\n \tif (!dev)\n \t\treturn -1;\n \n-\tif (unlikely(!(dev->flags & VIRTIO_DEV_BUILTIN_VIRTIO_NET))) {\n-\t\tRTE_LOG(ERR, VHOST_DATA,\n-\t\t\t\"(%d) %s: built-in vhost net backend is disabled.\\n\",\n-\t\t\tdev->vid, __func__);\n-\t\treturn -1;\n-\t}\n-\n \tdev->virtqueue[queue_id]->last_avail_idx = last_avail_idx;\n \tdev->virtqueue[queue_id]->last_used_idx = last_used_idx;\n \n", "prefixes": [] }