Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50398/?format=api
{ "id": 50398, "url": "https://patches.dpdk.org/api/patches/50398/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190220221051.7928-2-thomas@monjalon.net/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190220221051.7928-2-thomas@monjalon.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20190220221051.7928-2-thomas@monjalon.net", "date": "2019-02-20T22:10:48", "name": "[v2,1/4] ethdev: simplify port state comparisons", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "6a6ae4fbdfe9e21c83dc2959a3accc5be23aef6f", "submitter": { "id": 685, "url": "https://patches.dpdk.org/api/people/685/?format=api", "name": "Thomas Monjalon", "email": "thomas@monjalon.net" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190220221051.7928-2-thomas@monjalon.net/mbox/", "series": [ { "id": 3494, "url": "https://patches.dpdk.org/api/series/3494/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3494", "date": "2019-02-20T22:10:47", "name": "ethdev iterators for multi-ports device", "version": 2, "mbox": "https://patches.dpdk.org/series/3494/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50398/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50398/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09EE1288C;\n\tWed, 20 Feb 2019 23:11:15 +0100 (CET)", "from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com\n\t[64.147.123.25]) by dpdk.org (Postfix) with ESMTP id C701B1E34\n\tfor <dev@dpdk.org>; Wed, 20 Feb 2019 23:11:11 +0100 (CET)", "from compute1.internal (compute1.nyi.internal [10.202.2.41])\n\tby mailout.west.internal (Postfix) with ESMTP id AC7DB2FF0;\n\tWed, 20 Feb 2019 17:11:10 -0500 (EST)", "from mailfrontend2 ([10.202.2.163])\n\tby compute1.internal (MEProxy); Wed, 20 Feb 2019 17:11:11 -0500", "from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184])\n\tby mail.messagingengine.com (Postfix) with ESMTPA id 1133A10319;\n\tWed, 20 Feb 2019 17:11:08 -0500 (EST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=\n\tfrom:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding; s=mesmtp; bh=g4CkDtIqkM\n\tBWsModce2uVuQLyE8IL25kpw0P6odjEsc=; b=C8hx4ItGxwuOHqPKbq4iqBh3lC\n\tFfwFoTZNa6Rq0ABQzCv9Hum0a3vIwWdKfoIh371fgbM+NpQ5jn+D9lvWXdD7rIB4\n\t+0RInbARWNqUADemhCYLOlapsXqaiHTszOKZbJt6beY+OxVb4Xf5l1qrhs9ImunT\n\tEgKtu4uVUoPmvHeds=", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:content-transfer-encoding:date:from\n\t:in-reply-to:message-id:mime-version:references:subject:to\n\t:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=\n\tfm2; bh=g4CkDtIqkMBWsModce2uVuQLyE8IL25kpw0P6odjEsc=; b=r7BNwhYL\n\tI29C0NCfxe7qZYtakI8bvOpxBlsgvoefNeKCRCRi8odPTIuixZiaqc9/EofFLDJ6\n\tX9kK22Bwws8L/ljTLG5kQWeqqg/h0V17NSelj1suo/uJlsQp2Ovw9W1vbheMCQp/\n\t5Grga+3Bl/mY4/gSTXl6dJplryWhcpCxwsRue6tM3YHHtJQJpFoI837cCfAfdjQs\n\tFlfTw5PvLTW5jD5PxDF4MUQP91+5xm38Df+N4zZbVTkK/4AoWedDicigacOkmwWG\n\tRQr7sk/yE0Ihw55FxXyxI2Sv61G2XVZEh2e/vUGj9gQQYLzSpqx2z7Oh4xC9p88h\n\temz09kcrvs2hyg==" ], "X-ME-Sender": "<xms:fdBtXEbYHCWd75NNIAT-oH2i7GHpSl9Rf6D4aIFTtJOGUNzIBDuwEg>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgedutddrtdeigdduheekucdltddurdegtdelrddttd\n\tdmucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhht\n\tnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd\n\tenucfjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhm\n\trghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc\n\tfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht\n\thhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd", "X-ME-Proxy": "<xmx:fdBtXH1U4hRwYvluMmorLXHlDYieAwaIPXwbiFyR5uAGJg9XCQsNvg>\n\t<xmx:fdBtXPa2b2nwNblmGyglIEjTpK9EvqRQmKbSIeYtMxsiEajzbSNkYA>\n\t<xmx:fdBtXPK5L6hjKQW6HDPwGalQ8LKkGNdxSEH0y6IyD2rBlBdJGsN21g>\n\t<xmx:ftBtXFzoU3dKqMPy0be1zmgd4gWQXH5Qp0JeSHjgs1cEwy7WhK1Uyw>", "From": "Thomas Monjalon <thomas@monjalon.net>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>,\n\tAndrew Rybchenko <arybchenko@solarflare.com>", "Cc": "dev@dpdk.org", "Date": "Wed, 20 Feb 2019 23:10:48 +0100", "Message-Id": "<20190220221051.7928-2-thomas@monjalon.net>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190220221051.7928-1-thomas@monjalon.net>", "References": "<20181130002716.27325-1-thomas@monjalon.net>\n\t<20190220221051.7928-1-thomas@monjalon.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/4] ethdev: simplify port state comparisons", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "There are three states for an ethdev port.\nChecking that the port is unused looks simpler than\nchecking it is neither attached nor removed.\n\nSigned-off-by: Thomas Monjalon <thomas@monjalon.net>\n---\n lib/librte_ethdev/rte_ethdev.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c\nindex 0d192a24b2..b3b2fb1dba 100644\n--- a/lib/librte_ethdev/rte_ethdev.c\n+++ b/lib/librte_ethdev/rte_ethdev.c\n@@ -331,8 +331,7 @@ uint16_t\n rte_eth_find_next(uint16_t port_id)\n {\n \twhile (port_id < RTE_MAX_ETHPORTS &&\n-\t rte_eth_devices[port_id].state != RTE_ETH_DEV_ATTACHED &&\n-\t rte_eth_devices[port_id].state != RTE_ETH_DEV_REMOVED)\n+\t\t\trte_eth_devices[port_id].state == RTE_ETH_DEV_UNUSED)\n \t\tport_id++;\n \n \tif (port_id >= RTE_MAX_ETHPORTS)\n@@ -558,8 +557,7 @@ uint64_t\n rte_eth_find_next_owned_by(uint16_t port_id, const uint64_t owner_id)\n {\n \twhile (port_id < RTE_MAX_ETHPORTS &&\n-\t ((rte_eth_devices[port_id].state != RTE_ETH_DEV_ATTACHED &&\n-\t rte_eth_devices[port_id].state != RTE_ETH_DEV_REMOVED) ||\n+\t (rte_eth_devices[port_id].state == RTE_ETH_DEV_UNUSED ||\n \t rte_eth_devices[port_id].data->owner.id != owner_id))\n \t\tport_id++;\n \n", "prefixes": [ "v2", "1/4" ] }