Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/5034/?format=api
https://patches.dpdk.org/api/patches/5034/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1433151038-630-1-git-send-email-jblunck@infradead.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1433151038-630-1-git-send-email-jblunck@infradead.org>", "list_archive_url": "https://inbox.dpdk.org/dev/1433151038-630-1-git-send-email-jblunck@infradead.org", "date": "2015-06-01T09:30:38", "name": "[dpdk-dev,v2] log: Properly reset log_history_size in rte_log_dump_history()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "fee355b457f701c6151767d2fbbced6f3a1f7871", "submitter": { "id": 249, "url": "https://patches.dpdk.org/api/people/249/?format=api", "name": "Jan Blunck", "email": "jblunck@infradead.org" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1433151038-630-1-git-send-email-jblunck@infradead.org/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/5034/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/5034/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id D55EA5A37;\n\tMon, 1 Jun 2015 11:30:54 +0200 (CEST)", "from mail-wg0-f46.google.com (mail-wg0-f46.google.com\n\t[74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 9AF2F58C3\n\tfor <dev@dpdk.org>; Mon, 1 Jun 2015 11:30:53 +0200 (CEST)", "by wgez8 with SMTP id z8so108895340wge.0\n\tfor <dev@dpdk.org>; Mon, 01 Jun 2015 02:30:53 -0700 (PDT)", "from linux-04uu.site.eng.vyatta.net\n\t(port-92-196-73-168.dynamic.qsc.de. [92.196.73.168])\n\tby mx.google.com with ESMTPSA id\n\tjs3sm20980214wjc.5.2015.06.01.02.30.52\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tMon, 01 Jun 2015 02:30:52 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=/01MhQH12sJB3e4m1Eoc5M/ymjUsTKQNv22Hp3GFOyI=;\n\tb=tONwqUebhgO/kbr5tYwinXDG+IxpTpuPTa6ml+Y8Ypv2UaSKq6EJQ6X4RHMY1O4NMN\n\tx8GwM6k6dAzrzb5IrWV1zpVeN1Sothc0OvcFvDKoZveuKPYcrY3PqyccFzapaD/w7Gmo\n\tr/tMxlXDQyxpNVr5/nnmrKN5boGtCVjouqIN5/bQhkrh+wrGGg1cWbpITeExKYdrdJhV\n\tIro0auWURtXCswbp4QvvUbewBOowTV7zO8CwNXWn3Jl/pa/IfzH8BkefSEINpDagyBQ9\n\t8lGAM/1YH40ezwlae/vaHZm37otWFWnmmvjo2H4rTY1D6E0HHRC6rVUofZ9z5PNJQ7pn\n\t8Htg==", "X-Received": "by 10.194.3.11 with SMTP id 11mr1950155wjy.121.1433151053488;\n\tMon, 01 Jun 2015 02:30:53 -0700 (PDT)", "From": "Jan Blunck <jblunck@infradead.org>", "To": "dev@dpdk.org", "Date": "Mon, 1 Jun 2015 11:30:38 +0200", "Message-Id": "<1433151038-630-1-git-send-email-jblunck@infradead.org>", "X-Mailer": "git-send-email 2.1.4", "In-Reply-To": "<1432895688-1728-1-git-send-email-jblunck@infradead.org>", "References": "<1432895688-1728-1-git-send-email-jblunck@infradead.org>", "Subject": "[dpdk-dev] [PATCH v2] log: Properly reset log_history_size in\n\trte_log_dump_history()", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In rte_log_dump_history() the log_history list is reinitialized without\nresetting the log_history_size. In the next call to rte_log_add_in_history()\nthe log_history_size > RTE_LOG_HISTORY and the code unconditionally tries\nto remove the first entry:\n\nProgram received signal SIGSEGV, Segmentation fault.\nrte_log_add_in_history (\n buf=buf@entry=0x7f02035cd000 \"DATAPLANE: 9:dp0s7 link RTM_NEWLINK [dp0s7] <UP,BROADCAST,RUNNING,MULTICAST,LOWER_UP>\\nCAST,LOWER_UP>\\n\", size=size@entry=86)\n at /usr/src/packages/BUILD/lib/librte_eal/common/eal_common_log.c:122\n\nSigned-off-by: Jan Blunck <jblunck@infradead.org>\n---\n lib/librte_eal/common/eal_common_log.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_log.c b/lib/librte_eal/common/eal_common_log.c\nindex fe3d7d5..39d6e3f 100644\n--- a/lib/librte_eal/common/eal_common_log.c\n+++ b/lib/librte_eal/common/eal_common_log.c\n@@ -119,7 +119,10 @@ rte_log_add_in_history(const char *buf, size_t size)\n \t/* get a buffer for adding in history */\n \tif (log_history_size > RTE_LOG_HISTORY) {\n \t\thist_buf = STAILQ_FIRST(&log_history);\n-\t\tSTAILQ_REMOVE_HEAD(&log_history, next);\n+\t\tif (hist_buf) {\n+\t\t\tSTAILQ_REMOVE_HEAD(&log_history, next);\n+\t\t\tlog_history_size--;\n+\t\t}\n \t}\n \telse {\n \t\tif (rte_mempool_mc_get(log_history_mp, &obj) < 0)\n@@ -234,6 +237,7 @@ rte_log_dump_history(FILE *out)\n \trte_spinlock_lock(&log_list_lock);\n \ttmp_log_history = log_history;\n \tSTAILQ_INIT(&log_history);\n+\tlog_history_size = 0;\n \trte_spinlock_unlock(&log_list_lock);\n \n \tfor (i=0; i<RTE_LOG_HISTORY; i++) {\n", "prefixes": [ "dpdk-dev", "v2" ] }{ "id": 5034, "url": "