Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 50245,
    "url": "https://patches.dpdk.org/api/patches/50245/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190208034407.7865-4-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190208034407.7865-4-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190208034407.7865-4-stephen@networkplumber.org",
    "date": "2019-02-08T03:44:03",
    "name": "[3/7] bus/vmbus: fix check for mmap failure",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "f66da6e745587e9b62f0f985ca169999f77330e3",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190208034407.7865-4-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 3415,
            "url": "https://patches.dpdk.org/api/series/3415/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3415",
            "date": "2019-02-08T03:44:00",
            "name": "vmbus/netvsc: fix multi-process support",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/3415/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/50245/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/50245/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6C0D21B7D9;\n\tFri,  8 Feb 2019 04:44:23 +0100 (CET)",
            "from mail-pl1-f193.google.com (mail-pl1-f193.google.com\n\t[209.85.214.193]) by dpdk.org (Postfix) with ESMTP id CB2441B759\n\tfor <dev@dpdk.org>; Fri,  8 Feb 2019 04:44:20 +0100 (CET)",
            "by mail-pl1-f193.google.com with SMTP id a14so1017576plm.12\n\tfor <dev@dpdk.org>; Thu, 07 Feb 2019 19:44:20 -0800 (PST)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ti4sm873275pfj.82.2019.02.07.19.44.18\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 07 Feb 2019 19:44:18 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=ArJKO28hLj0K5VjH+0jBSnG6Yg4WWDwmTUVgCvjH65w=;\n\tb=OwKjsqoxzE1DjQ3i3SFtAKxWdFLhwHLLVg0gc55rpVNHfT5Llu9Ei/doTqg2PWjhq2\n\tOUz/JlaQa06DFP2XVLo3tOwYviI6Md0BMF2xTTJHvdTVzsSaCzI+enx4CQoWAaAhmCYv\n\tVmvJqCV1pyOm25QZDEnrPR5QSqCn40nUG9EB22k/82pXtKNthu1mFZ1OnJ6+dQ0wE3//\n\tFGieIA/JvbPuPFc4OBkz6ZpyG5iliBGGJb8OR9W/M5EeXtRTt732uwduHii4gcvLaeuk\n\tQo0c/N8cIgU6t/luIvmEYD0iJPWAMiTMKxhgPFBerzXkVS2/rrqP7ru12eEUGeNZyvmw\n\tDMkA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=ArJKO28hLj0K5VjH+0jBSnG6Yg4WWDwmTUVgCvjH65w=;\n\tb=R56/tJJpVGTnqU1RhPEAg2KIYEqbZCd5atA4AQ1zLExN2L64nb/v/WQ2sU1goEjSZF\n\tqP8Lnx0SIHB8X3EM578I5NyQcOPAEIUzOkfwC7+yBnvfyj9HT8LQBhh0TQZv7Y+FsQHr\n\trV56EgjytQC6vwchZEqtq0FAnX7AsnuqkXOw62Mple7/vsZsg+THzxl5rTKCEbD+BYoT\n\t5iR2XQgsG2+fmIVe62LOJ6WMz/vH8a0gBJc8ZPczfDch/IRFeL4vjwc6jdaD8yU26UIO\n\tlg+I/DL3RrAWn9YVaJce39ys2i2CgbtOy6Bk0AO+qDddcpYtrzv44XSm9Ukyn/t1zRdF\n\tcSmw==",
        "X-Gm-Message-State": "AHQUAuY7FFl7OMc7FQhhKuTNSbdDPVluYY8BNLKTmYtUf7SKYUJ+DRMk\n\tu9eQ0rVyJijDfBt6xabkMxY6Ad52xdM=",
        "X-Google-Smtp-Source": "AHgI3IboWsezZXt2jUW9T1YQEB3TlXlerh2SEmbx4xlZSlyYQWHNY+kFhIDOHowReaqMROsLDqpeRg==",
        "X-Received": "by 2002:a17:902:765:: with SMTP id\n\t92mr20443362pli.242.1549597459703; \n\tThu, 07 Feb 2019 19:44:19 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "stable@dpdk.org,\n\tStephen Hemminger <sthemmin@microsoft.com>",
        "Date": "Thu,  7 Feb 2019 19:44:03 -0800",
        "Message-Id": "<20190208034407.7865-4-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190208034407.7865-1-stephen@networkplumber.org>",
        "References": "<20190208034407.7865-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/7] bus/vmbus: fix check for mmap failure",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Stephen Hemminger <sthemmin@microsoft.com>\n\nThe code was testing the result of mmap incorrectly.\nI.e the test that a local pointer is not MAP_FAILED would\nalways succeed and therefore hid any potential problems.\n\nFixes: 831dba47bd36 (\"bus/vmbus: add Hyper-V virtual bus support\")\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/bus/vmbus/linux/vmbus_uio.c | 11 +++++++----\n 1 file changed, 7 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/bus/vmbus/linux/vmbus_uio.c b/drivers/bus/vmbus/linux/vmbus_uio.c\nindex 09f7efdca286..8c6bc52fd475 100644\n--- a/drivers/bus/vmbus/linux/vmbus_uio.c\n+++ b/drivers/bus/vmbus/linux/vmbus_uio.c\n@@ -202,6 +202,7 @@ static int vmbus_uio_map_subchan(const struct rte_vmbus_device *dev,\n \tchar ring_path[PATH_MAX];\n \tsize_t file_size;\n \tstruct stat sb;\n+\tvoid *mapaddr;\n \tint fd;\n \n \tsnprintf(ring_path, sizeof(ring_path),\n@@ -232,14 +233,16 @@ static int vmbus_uio_map_subchan(const struct rte_vmbus_device *dev,\n \t\treturn -EINVAL;\n \t}\n \n-\t*ring_size = file_size / 2;\n-\t*ring_buf = vmbus_map_resource(vmbus_map_addr, fd,\n-\t\t\t\t       0, sb.st_size, 0);\n+\tmapaddr = vmbus_map_resource(vmbus_map_addr, fd,\n+\t\t\t\t     0, file_size, 0);\n \tclose(fd);\n \n-\tif (ring_buf == MAP_FAILED)\n+\tif (mapaddr == MAP_FAILED)\n \t\treturn -EIO;\n \n+\t*ring_size = file_size / 2;\n+\t*ring_buf = mapaddr;\n+\n \tvmbus_map_addr = RTE_PTR_ADD(ring_buf, file_size);\n \treturn 0;\n }\n",
    "prefixes": [
        "3/7"
    ]
}