Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50228/?format=api
https://patches.dpdk.org/api/patches/50228/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1549556983-10896-38-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549556983-10896-38-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549556983-10896-38-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T16:29:42", "name": "[37/38] net/sfc/base: improve MCDI interface header inclusion", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7618c7fc6ca1703883a3efefd206f61c01e2cc16", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1549556983-10896-38-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3411, "url": "https://patches.dpdk.org/api/series/3411/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3411", "date": "2019-02-07T16:29:05", "name": "net/sfc: update base driver", "version": 1, "mbox": "https://patches.dpdk.org/series/3411/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50228/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50228/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AE191B731;\n\tThu, 7 Feb 2019 17:31:15 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id F12EA1B580\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 17:30:38 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t839F9B400AF for <dev@dpdk.org>; Thu, 7 Feb 2019 16:30:37 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 08:30:32 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 08:30:32 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17GUVLi015402 for <dev@dpdk.org>; Thu, 7 Feb 2019 16:30:31 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tED2131613EB\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 16:30:30 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 16:29:42 +0000", "Message-ID": "<1549556983-10896-38-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549556983-10896-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549556983-10896-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-4.677000-4.000000-10", "X-TMASE-MatchedRID": "E3bo5kZrbaWdXNOCtK/uyTbN0t/c2qF2G1MJZJUELLidnP2txNDmi41j\n\tAJzOtyu36Dt5NCmyuWWcdguUnFpuXBo/F4wweNBuh2VzUlo4HVMDUlZM93vMw1OitEi5p2m0cHj\n\tgiTON9jKPqQJ9fQR1zuGKEwEzyKksFzVT4QVLabJw5vTXndERpXN3sLsG0mhuQKCRBZM9eAejxY\n\tyRBa/qJShNCXvA0fw+jaPj0W1qn0SujVRFkkVsm+2L4/0y+N66ynyLum253YZKCmPA5kD2Diykl\n\teRbXHC1Za+uZbMi9sBikG6urSQhEauj+PD/B1srpd+YSVwN9Y6q30meJWKJEE+9nKAUfbd9OiMM\n\tfiztpo/4XWZPvl2TZLAodBnVXNL5WPUbFT+qSXA=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--4.677000-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549557038-FfnPmXbGq93K", "Subject": "[dpdk-dev] [PATCH 37/38] net/sfc/base: improve MCDI interface\n\theader inclusion", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Include efx_mcdi.h from main internal header efx_impl.h directly\ninstead of indirect inclusion via family-specific header.\nIt avoids duplication and fixes Medford and Medford2 cases where\nthe header inclusion is lost.\nCorrectness is still guaranteed by checks in efx_check.h which\nrequire EFSYS_OPT_MCDI for corresponding families and do not\nallow to enable the option if no family requires it.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/efx_impl.h | 3 +++\n drivers/net/sfc/base/hunt_impl.h | 1 -\n drivers/net/sfc/base/siena_impl.h | 1 -\n 3 files changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/efx_impl.h b/drivers/net/sfc/base/efx_impl.h\nindex eb2bdc959..56d293b40 100644\n--- a/drivers/net/sfc/base/efx_impl.h\n+++ b/drivers/net/sfc/base/efx_impl.h\n@@ -10,6 +10,9 @@\n #include \"efx.h\"\n #include \"efx_regs.h\"\n #include \"efx_regs_ef10.h\"\n+#if EFSYS_OPT_MCDI\n+#include \"efx_mcdi.h\"\n+#endif\t/* EFSYS_OPT_MCDI */\n \n /* FIXME: Add definition for driver generated software events */\n #ifndef\tESE_DZ_EV_CODE_DRV_GEN_EV\ndiff --git a/drivers/net/sfc/base/hunt_impl.h b/drivers/net/sfc/base/hunt_impl.h\nindex a76602d52..3c1cb6214 100644\n--- a/drivers/net/sfc/base/hunt_impl.h\n+++ b/drivers/net/sfc/base/hunt_impl.h\n@@ -10,7 +10,6 @@\n #include \"efx.h\"\n #include \"efx_regs.h\"\n #include \"efx_regs_ef10.h\"\n-#include \"efx_mcdi.h\"\n \n #ifdef\t__cplusplus\n extern \"C\" {\ndiff --git a/drivers/net/sfc/base/siena_impl.h b/drivers/net/sfc/base/siena_impl.h\nindex 4af9845fe..1adb8a437 100644\n--- a/drivers/net/sfc/base/siena_impl.h\n+++ b/drivers/net/sfc/base/siena_impl.h\n@@ -9,7 +9,6 @@\n \n #include \"efx.h\"\n #include \"efx_regs.h\"\n-#include \"efx_mcdi.h\"\n #include \"siena_flash.h\"\n \n #ifdef\t__cplusplus\n", "prefixes": [ "37/38" ] }{ "id": 50228, "url": "