Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50218/?format=api
{ "id": 50218, "url": "https://patches.dpdk.org/api/patches/50218/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1549556983-10896-34-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549556983-10896-34-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549556983-10896-34-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T16:29:38", "name": "[33/38] net/sfc/base: pass Rx buffer size to RxQ init if supported", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "48c52031b2fdc434eb067899cede3a57701f8261", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1549556983-10896-34-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3411, "url": "https://patches.dpdk.org/api/series/3411/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3411", "date": "2019-02-07T16:29:05", "name": "net/sfc: update base driver", "version": 1, "mbox": "https://patches.dpdk.org/series/3411/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50218/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50218/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id AB8DB1B767;\n\tThu, 7 Feb 2019 17:31:18 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id E263F1B57F\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 17:30:38 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t7E87EB80075 for <dev@dpdk.org>; Thu, 7 Feb 2019 16:30:37 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 08:30:32 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 08:30:31 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17GUUnj015384 for <dev@dpdk.org>; Thu, 7 Feb 2019 16:30:30 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tBB2791613EB\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 16:30:30 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 16:29:38 +0000", "Message-ID": "<1549556983-10896-34-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549556983-10896-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549556983-10896-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-0.140100-4.000000-10", "X-TMASE-MatchedRID": "i/wEjRUPNdw2jeY+Udg/IgwfhKwa9GwDQ95F2IiVUkT1gF7PCEF9bq+2\n\thuD95gk5u0Xb2K9EUeEChJtz8OKIP294Ipa1otxo7spMO3HwKCAP4vBWNr0zgd9zZd3pUn7K4uC\n\tBSJiRjIf5jzE0lPZnstpI+ulG5dSKDHHjZ4qctumiAZ3zAhQYglXXZO0BkB2ngceRYfiTlXajxY\n\tyRBa/qJcFwgTvxipFajoczmuoPCq2v1cc1cDoUL5JqKcEd9Wglyllwc4azrmtNOrSw47Ef62j0o\n\t4Hb+PtcNTIe0sQVttaosxCAi2CExxBN88sXyKPWkuuBEWTahJk3I8DUyOoaeU+wJNKvG6HQ1PNk\n\tozhRY3HUNR3AhwxI7HVCg90b4a/8", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--0.140100-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549557038-XBf7zYIu6gQV", "Subject": "[dpdk-dev] [PATCH 33/38] net/sfc/base: pass Rx buffer size to RxQ\n\tinit if supported", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Riverhead requires Rx buffer size to be specified in INIT_RXQ.\nIf the parameter is not supported (e.g. on EF10 family adapters),\nzero must be used on INIT_RXQ.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_nic.c | 10 ++++++++++\n drivers/net/sfc/base/ef10_rx.c | 15 ++++++++++-----\n drivers/net/sfc/base/efx.h | 1 +\n 3 files changed, 21 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_nic.c b/drivers/net/sfc/base/ef10_nic.c\nindex 39ca53f03..6ba2fe3b9 100644\n--- a/drivers/net/sfc/base/ef10_nic.c\n+++ b/drivers/net/sfc/base/ef10_nic.c\n@@ -1205,6 +1205,16 @@ ef10_get_datapath_caps(\n \telse\n \t\tencp->enc_no_cont_ev_mode_supported = B_FALSE;\n \n+\t/*\n+\t * Check if buffer size may and must be specified on INIT_RXQ.\n+\t * It may be always specified to efx_rx_qcreate(), but will be\n+\t * just kept libefx internal if MCDI does not support it.\n+\t */\n+\tif (CAP_FLAGS2(req, INIT_RXQ_WITH_BUFFER_SIZE))\n+\t\tencp->enc_init_rxq_with_buffer_size = B_TRUE;\n+\telse\n+\t\tencp->enc_init_rxq_with_buffer_size = B_FALSE;\n+\n \t/*\n \t * Check if firmware-verified NVRAM updates must be used.\n \t *\ndiff --git a/drivers/net/sfc/base/ef10_rx.c b/drivers/net/sfc/base/ef10_rx.c\nindex 5cb7da99b..c060d2e4d 100644\n--- a/drivers/net/sfc/base/ef10_rx.c\n+++ b/drivers/net/sfc/base/ef10_rx.c\n@@ -21,6 +21,7 @@ efx_mcdi_init_rxq(\n \t__in\t\tefsys_mem_t *esmp,\n \t__in\t\tboolean_t disable_scatter,\n \t__in\t\tboolean_t want_inner_classes,\n+\t__in\t\tuint32_t buf_size,\n \t__in\t\tuint32_t ps_bufsize,\n \t__in\t\tuint32_t es_bufs_per_desc,\n \t__in\t\tuint32_t es_max_dma_len,\n@@ -29,8 +30,8 @@ efx_mcdi_init_rxq(\n {\n \tefx_nic_cfg_t *encp = &(enp->en_nic_cfg);\n \tefx_mcdi_req_t req;\n-\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_INIT_RXQ_V3_IN_LEN,\n-\t\tMC_CMD_INIT_RXQ_V3_OUT_LEN);\n+\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_INIT_RXQ_V4_IN_LEN,\n+\t\tMC_CMD_INIT_RXQ_V4_OUT_LEN);\n \tint npages = efx_rxq_nbufs(enp, ndescs);\n \tint i;\n \tefx_qword_t *dma_addr;\n@@ -84,9 +85,9 @@ efx_mcdi_init_rxq(\n \n \treq.emr_cmd = MC_CMD_INIT_RXQ;\n \treq.emr_in_buf = payload;\n-\treq.emr_in_length = MC_CMD_INIT_RXQ_V3_IN_LEN;\n+\treq.emr_in_length = MC_CMD_INIT_RXQ_V4_IN_LEN;\n \treq.emr_out_buf = payload;\n-\treq.emr_out_length = MC_CMD_INIT_RXQ_V3_OUT_LEN;\n+\treq.emr_out_length = MC_CMD_INIT_RXQ_V4_OUT_LEN;\n \n \tMCDI_IN_SET_DWORD(req, INIT_RXQ_EXT_IN_SIZE, ndescs);\n \tMCDI_IN_SET_DWORD(req, INIT_RXQ_EXT_IN_TARGET_EVQ, eep->ee_index);\n@@ -120,6 +121,10 @@ efx_mcdi_init_rxq(\n \t\t hol_block_timeout);\n \t}\n \n+\tif (encp->enc_init_rxq_with_buffer_size)\n+\t\tMCDI_IN_SET_DWORD(req, INIT_RXQ_V4_IN_BUFFER_SIZE_BYTES,\n+\t\t buf_size);\n+\n \tdma_addr = MCDI_IN2(req, efx_qword_t, INIT_RXQ_IN_DMA_ADDR);\n \taddr = EFSYS_MEM_ADDR(esmp);\n \n@@ -1140,7 +1145,7 @@ ef10_rx_qcreate(\n \t\twant_inner_classes = B_FALSE;\n \n \tif ((rc = efx_mcdi_init_rxq(enp, ndescs, eep, label, index,\n-\t\t esmp, disable_scatter, want_inner_classes,\n+\t\t esmp, disable_scatter, want_inner_classes, erp->er_buf_size,\n \t\t ps_buf_size, es_bufs_per_desc, es_max_dma_len,\n \t\t es_buf_stride, hol_block_timeout)) != 0)\n \t\tgoto fail12;\ndiff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 35f896750..2cd2c36c3 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -1371,6 +1371,7 @@ typedef struct efx_nic_cfg_s {\n \tboolean_t\t\tenc_enhanced_set_mac_supported;\n \tboolean_t\t\tenc_init_evq_v2_supported;\n \tboolean_t\t\tenc_no_cont_ev_mode_supported;\n+\tboolean_t\t\tenc_init_rxq_with_buffer_size;\n \tboolean_t\t\tenc_rx_packed_stream_supported;\n \tboolean_t\t\tenc_rx_var_packed_stream_supported;\n \tboolean_t\t\tenc_rx_es_super_buffer_supported;\n", "prefixes": [ "33/38" ] }