Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50210/?format=api
{ "id": 50210, "url": "https://patches.dpdk.org/api/patches/50210/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1549556983-10896-17-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549556983-10896-17-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549556983-10896-17-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T16:29:21", "name": "[16/38] net/sfc/base: make max number of TxQ bufs EF10-specific", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "60607e703275187f74afe17c2d4af85a2502728e", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1549556983-10896-17-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3411, "url": "https://patches.dpdk.org/api/series/3411/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3411", "date": "2019-02-07T16:29:05", "name": "net/sfc: update base driver", "version": 1, "mbox": "https://patches.dpdk.org/series/3411/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50210/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50210/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C52FA1B5DB;\n\tThu, 7 Feb 2019 17:30:54 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[67.231.154.164]) by dpdk.org (Postfix) with ESMTP id AFF4B1B582\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 17:30:36 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id 8EA37B40144; Thu, 7 Feb 2019 16:30:35 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 08:30:31 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 08:30:31 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17GUTBI015311; Thu, 7 Feb 2019 16:30:29 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\tD930D1613E4; Thu, 7 Feb 2019 16:30:29 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "CC": "Igor Romanov <igor.romanov@oktetlabs.ru>", "Date": "Thu, 7 Feb 2019 16:29:21 +0000", "Message-ID": "<1549556983-10896-17-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549556983-10896-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549556983-10896-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-3.564500-4.000000-10", "X-TMASE-MatchedRID": "EGawMJAxUjhLah/iCBd5Vh+WEMjoO9WWTJDl9FKHbrlVhUzKT4buI1Nc\n\t7vkHlfZ4LqUyyMoguFSIukMxD7tJAZ7oe7OF0U2WngIgpj8eDcAZ1CdBJOsoY8RB0bsfrpPIcSq\n\tbxBgG0w5bj8cDmZKBTHrQ+UaUP6oMZ5cEgHx53+YbZjlYYH8WQ9BbGYHcmhOYB8iIMj42HmgOZv\n\tzriFknFALr9iGC4RD+jVlgWxJ1NyeTdSRXlCnjBIjjlF305EnAWUm8SESyzd/NBqGt1DPvvA==", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.564500-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549557036-QotVwIc4R3HO", "Subject": "[dpdk-dev] [PATCH 16/38] net/sfc/base: make max number of TxQ bufs\n\tEF10-specific", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Igor Romanov <igor.romanov@oktetlabs.ru>\n\nThe define EFX_TXQ_MAX_BUFS is used only by EF10 family implementation.\nSince the macro is not used by any drivers, it does not require\nexposed libefx interface.\nMake the define EF10-specific.\n\nSigned-off-by: Igor Romanov <igor.romanov@oktetlabs.ru>\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/base/ef10_impl.h | 3 +++\n drivers/net/sfc/base/ef10_tx.c | 5 +++--\n drivers/net/sfc/base/efx.h | 2 --\n 3 files changed, 6 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/sfc/base/ef10_impl.h b/drivers/net/sfc/base/ef10_impl.h\nindex 44f7f635d..12747f43c 100644\n--- a/drivers/net/sfc/base/ef10_impl.h\n+++ b/drivers/net/sfc/base/ef10_impl.h\n@@ -19,6 +19,9 @@ extern \"C\" {\n \n #define\tEF10_TXQ_MINNDESCS\t512\n \n+/* Maximum independent of EFX_BUG35388_WORKAROUND. */\n+#define\tEF10_TXQ_MAXNBUFS\t8\n+\n /* Number of hardware PIO buffers (for compile-time resource dimensions) */\n #define\tEF10_MAX_PIOBUF_NBUFS\t(16)\n \ndiff --git a/drivers/net/sfc/base/ef10_tx.c b/drivers/net/sfc/base/ef10_tx.c\nindex 5f3df42b9..aacf4310a 100644\n--- a/drivers/net/sfc/base/ef10_tx.c\n+++ b/drivers/net/sfc/base/ef10_tx.c\n@@ -31,7 +31,8 @@ efx_mcdi_init_txq(\n \t__in\t\tefsys_mem_t *esmp)\n {\n \tefx_mcdi_req_t req;\n-\tEFX_MCDI_DECLARE_BUF(payload, MC_CMD_INIT_TXQ_IN_LEN(EFX_TXQ_MAX_BUFS),\n+\tEFX_MCDI_DECLARE_BUF(payload,\n+\t\tMC_CMD_INIT_TXQ_IN_LEN(EF10_TXQ_MAXNBUFS),\n \t\tMC_CMD_INIT_TXQ_OUT_LEN);\n \tefx_qword_t *dma_addr;\n \tuint64_t addr;\n@@ -39,7 +40,7 @@ efx_mcdi_init_txq(\n \tint i;\n \tefx_rc_t rc;\n \n-\tEFSYS_ASSERT(EFX_TXQ_MAX_BUFS >=\n+\tEFSYS_ASSERT(EF10_TXQ_MAXNBUFS >=\n \t EFX_TXQ_NBUFS(enp->en_nic_cfg.enc_txq_max_ndescs));\n \n \tif ((esmp == NULL) || (EFSYS_MEM_SIZE(esmp) < EFX_TXQ_SIZE(ndescs))) {\ndiff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h\nindex 71500d6b8..d8914aa7c 100644\n--- a/drivers/net/sfc/base/efx.h\n+++ b/drivers/net/sfc/base/efx.h\n@@ -2649,8 +2649,6 @@ efx_tx_fini(\n #define\tEFX_TXQ_NBUFS(_ndescs)\t\t(EFX_TXQ_SIZE(_ndescs) / EFX_BUF_SIZE)\n #define\tEFX_TXQ_LIMIT(_ndescs)\t\t((_ndescs) - 16)\n \n-#define\tEFX_TXQ_MAX_BUFS 8 /* Maximum independent of EFX_BUG35388_WORKAROUND. */\n-\n #define\tEFX_TXQ_CKSUM_IPV4\t\t0x0001\n #define\tEFX_TXQ_CKSUM_TCPUDP\t\t0x0002\n #define\tEFX_TXQ_FATSOV2\t\t\t0x0004\n", "prefixes": [ "16/38" ] }