Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/502/?format=api
{ "id": 502, "url": "https://patches.dpdk.org/api/patches/502/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1411634427-746-7-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1411634427-746-7-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1411634427-746-7-git-send-email-helin.zhang@intel.com", "date": "2014-09-25T08:40:20", "name": "[dpdk-dev,v2,06/13] igb: rework of updating/querying reta", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "16f5509658cb2be84eb24d42fd537316adfd5c83", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1411634427-746-7-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/502/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/502/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0D5A3B3DE;\n\tThu, 25 Sep 2014 10:34:56 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id B04D8B3DE\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 10:34:54 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 25 Sep 2014 01:40:48 -0700", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 25 Sep 2014 01:40:47 -0700", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id s8P8eiwt002315;\n\tThu, 25 Sep 2014 16:40:44 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid s8P8egl8000823; Thu, 25 Sep 2014 16:40:44 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id s8P8egER000819; \n\tThu, 25 Sep 2014 16:40:42 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,595,1406617200\"; d=\"scan'208\";a=\"605124862\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 25 Sep 2014 16:40:20 +0800", "Message-Id": "<1411634427-746-7-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1411634427-746-1-git-send-email-helin.zhang@intel.com>", "References": "<1411634427-746-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 06/13] igb: rework of updating/querying reta", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As ethdev has been changed to support multiple sizes of\nreta, updating/querying reta should be reworked to support\nthat change.\n\nv2 changes:\n* Put rework of updating/querying igb reta to a single patch.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\nReviewed-by: Jijiang Liu <jijiang.liu@intel.com>\nReviewed-by: Cunming Liang <cunming.liang@intel.com>\nReviewed-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/librte_pmd_e1000/igb_ethdev.c | 109 ++++++++++++++++++++------------------\n 1 file changed, 56 insertions(+), 53 deletions(-)", "diff": "diff --git a/lib/librte_pmd_e1000/igb_ethdev.c b/lib/librte_pmd_e1000/igb_ethdev.c\nindex 6646029..2fd30e4 100644\n--- a/lib/librte_pmd_e1000/igb_ethdev.c\n+++ b/lib/librte_pmd_e1000/igb_ethdev.c\n@@ -126,10 +126,11 @@ static int igbvf_vlan_filter_set(struct rte_eth_dev *dev,\n static int igbvf_set_vfta(struct e1000_hw *hw, uint16_t vid, bool on);\n static void igbvf_set_vfta_all(struct rte_eth_dev *dev, bool on);\n static int eth_igb_rss_reta_update(struct rte_eth_dev *dev,\n-\t\t struct rte_eth_rss_reta *reta_conf);\n+\t\t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\t\t uint16_t reta_size);\n static int eth_igb_rss_reta_query(struct rte_eth_dev *dev,\n-\t\tstruct rte_eth_rss_reta *reta_conf);\n-\n+\t\t\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\t\t uint16_t reta_size);\n static int eth_igb_add_syn_filter(struct rte_eth_dev *dev,\n \t\t\tstruct rte_syn_filter *filter, uint16_t rx_queue);\n static int eth_igb_remove_syn_filter(struct rte_eth_dev *dev);\n@@ -2250,38 +2251,39 @@ igbvf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on)\n \n static int\n eth_igb_rss_reta_update(struct rte_eth_dev *dev,\n- struct rte_eth_rss_reta *reta_conf)\n+\t\t\tstruct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t\tuint16_t reta_size)\n {\n-\tuint8_t i,j,mask;\n-\tuint32_t reta;\n-\tstruct e1000_hw *hw =\n-\t\t\tE1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tuint8_t i, j, mask;\n+\tuint32_t reta, r;\n+\tuint16_t idx, shift;\n+\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\t/*\n-\t * Update Redirection Table RETA[n],n=0...31,The redirection table has\n-\t * 128-entries in 32 registers\n-\t */\n-\tfor(i = 0; i < ETH_RSS_RETA_NUM_ENTRIES; i += 4) {\n-\t\tif (i < ETH_RSS_RETA_NUM_ENTRIES/2)\n-\t\t\tmask = (uint8_t)((reta_conf->mask_lo >> i) & 0xF);\n+\tif (reta_size != ETH_RSS_RETA_SIZE_128) {\n+\t\tPMD_DRV_LOG(ERR, \"The size of hash lookup table configured \"\n+\t\t\t\"(%d) doesn't match the number hardware can supported \"\n+\t\t\t\"(%d)\\n\", reta_size, ETH_RSS_RETA_SIZE_128);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (i = 0; i < reta_size; i += 4) {\n+\t\tidx = i / RTE_BIT_WIDTH_64;\n+\t\tshift = i % RTE_BIT_WIDTH_64;\n+\t\tmask = (uint8_t)((reta_conf[idx].mask >> shift) & 0xf);\n+\t\tif (!mask)\n+\t\t\tcontinue;\n+\t\tif (mask == 0xf)\n+\t\t\tr = 0;\n \t\telse\n-\t\t\tmask = (uint8_t)((reta_conf->mask_hi >>\n-\t\t\t\t(i - ETH_RSS_RETA_NUM_ENTRIES/2)) & 0xF);\n-\t\tif (mask != 0) {\n-\t\t\treta = 0;\n-\t\t\t/* If all 4 entries were set,don't need read RETA register */\n-\t\t\tif (mask != 0xF)\n-\t\t\t\treta = E1000_READ_REG(hw,E1000_RETA(i >> 2));\n-\n-\t\t\tfor (j = 0; j < 4; j++) {\n-\t\t\t\tif (mask & (0x1 << j)) {\n-\t\t\t\t\tif (mask != 0xF)\n-\t\t\t\t\t\treta &= ~(0xFF << 8 * j);\n-\t\t\t\t\treta |= reta_conf->reta[i + j] << 8 * j;\n-\t\t\t\t}\n-\t\t\t}\n-\t\t\tE1000_WRITE_REG(hw, E1000_RETA(i >> 2),reta);\n+\t\t\tr = E1000_READ_REG(hw, E1000_RETA(i >> 2));\n+\t\tfor (j = 0, reta = 0; j < 4; j++) {\n+\t\t\tif (mask & (0x1 << j))\n+\t\t\t\treta |= reta_conf[idx].reta[shift + j] <<\n+\t\t\t\t\t\t\t(CHAR_BIT * j);\n+\t\t\telse\n+\t\t\t\treta |= r & (0xff << (CHAR_BIT * j));\n \t\t}\n+\t\tE1000_WRITE_REG(hw, E1000_RETA(i >> 2), reta);\n \t}\n \n \treturn 0;\n@@ -2289,31 +2291,32 @@ eth_igb_rss_reta_update(struct rte_eth_dev *dev,\n \n static int\n eth_igb_rss_reta_query(struct rte_eth_dev *dev,\n- struct rte_eth_rss_reta *reta_conf)\n+\t\t struct rte_eth_rss_reta_entry64 *reta_conf,\n+\t\t uint16_t reta_size)\n {\n-\tuint8_t i,j,mask;\n+\tuint8_t i, j, mask;\n \tuint32_t reta;\n-\tstruct e1000_hw *hw =\n-\t\t\tE1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tuint16_t idx, shift;\n+\tstruct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \n-\t/*\n-\t * Read Redirection Table RETA[n],n=0...31,The redirection table has\n-\t * 128-entries in 32 registers\n-\t */\n-\tfor(i = 0; i < ETH_RSS_RETA_NUM_ENTRIES; i += 4) {\n-\t\tif (i < ETH_RSS_RETA_NUM_ENTRIES/2)\n-\t\t\tmask = (uint8_t)((reta_conf->mask_lo >> i) & 0xF);\n-\t\telse\n-\t\t\tmask = (uint8_t)((reta_conf->mask_hi >>\n-\t\t\t\t(i - ETH_RSS_RETA_NUM_ENTRIES/2)) & 0xF);\n-\n-\t\tif (mask != 0) {\n-\t\t\treta = E1000_READ_REG(hw,E1000_RETA(i >> 2));\n-\t\t\tfor (j = 0; j < 4; j++) {\n-\t\t\t\tif (mask & (0x1 << j))\n-\t\t\t\t\treta_conf->reta[i + j] =\n-\t\t\t\t\t\t(uint8_t)((reta >> 8 * j) & 0xFF);\n-\t\t\t}\n+\tif (reta_size != ETH_RSS_RETA_SIZE_128) {\n+\t\tPMD_DRV_LOG(ERR, \"The size of hash lookup table configured \"\n+\t\t\t\"(%d) doesn't match the number hardware can supported \"\n+\t\t\t\"(%d)\\n\", reta_size, ETH_RSS_RETA_SIZE_128);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tfor (i = 0; i < reta_size; i += 4) {\n+\t\tidx = i / RTE_BIT_WIDTH_64;\n+\t\tshift = i % RTE_BIT_WIDTH_64;\n+\t\tmask = (uint8_t)((reta_conf[idx].mask >> shift) & 0xf);\n+\t\tif (!mask)\n+\t\t\tcontinue;\n+\t\treta = E1000_READ_REG(hw, E1000_RETA(i >> 2));\n+\t\tfor (j = 0; j < 4; j++) {\n+\t\t\tif (mask & (0x1 << j))\n+\t\t\t\treta_conf[idx].reta[shift + j] =\n+\t\t\t\t\t((reta >> (CHAR_BIT * j)) & 0xff);\n \t\t}\n \t}\n \n", "prefixes": [ "dpdk-dev", "v2", "06/13" ] }