Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50169/?format=api
{ "id": 50169, "url": "https://patches.dpdk.org/api/patches/50169/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1549541873-17403-12-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-12-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-12-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:34", "name": "[11/30] net/sfc: move datapath RxQ handle to shared RxQ info", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "92cb2d9aa5415872c0e1a2887f9a70980f1e86ff", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1549541873-17403-12-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "https://patches.dpdk.org/api/series/3407/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "https://patches.dpdk.org/series/3407/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50169/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50169/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 34AA41B4E2;\n\tThu, 7 Feb 2019 13:18:27 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 122361B4B0\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:15 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\tD859E600061 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:13 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:10 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:09 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI83o013241 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t97D721613E4\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:34 +0000", "Message-ID": "<1549541873-17403-12-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "No-3.347400-4.000000-10", "X-TMASE-MatchedRID": "CpBUfk8vmJsfOjKSU0pCER+WEMjoO9WWTJDl9FKHbrnuaWurQfPpTaYm\n\tf3n26fzqalyDl//i2XBNkhpxJfv8GkJH8WyQMk5uliwpJdZauwdYMtqMzbYRNsA0eOJZYj7tvlJ\n\t3+emUkhzi8zVgXoAltsIJ+4gwXrEtJ0RPnyOnrZIfCeRrCKctR4OAXlAXuAWeUQL6hgtEWgEzdf\n\tA9PWbPw80U/gfsvEKn12R8J4aRt5uAUA888eNE92WGksDODCi6n+C1jk8hv6WqFrt9xUgp+uq+T\n\t0IcdvQ1BtPt5WQTZkLauEQaIW46K6fL1/LSJ6vL", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "10--3.347400-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541894-YNkbNRCNamCP", "Subject": "[dpdk-dev] [PATCH 11/30] net/sfc: move datapath RxQ handle to\n\tshared RxQ info", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If datapath supports multi-process, it should be possible to get\nits RxQ structure by the queue index.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 8 +++-----\n drivers/net/sfc/sfc_rx.c | 16 ++++++++--------\n drivers/net/sfc/sfc_rx.h | 2 +-\n 3 files changed, 12 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 7118d2293..71be88f3e 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -415,7 +415,7 @@ sfc_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n \tif (rc != 0)\n \t\tgoto fail_rx_qinit;\n \n-\tdev->data->rx_queues[rx_queue_id] = sa->rxq_info[rx_queue_id].rxq->dp;\n+\tdev->data->rx_queues[rx_queue_id] = sa->rxq_info[rx_queue_id].dp;\n \n \tsfc_adapter_unlock(sa);\n \n@@ -1123,16 +1123,14 @@ sfc_rx_queue_count(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \tconst struct sfc_adapter_priv *sap = sfc_adapter_priv_by_eth_dev(dev);\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rxq_info *rxq_info;\n-\tstruct sfc_rxq *rxq;\n \n \tSFC_ASSERT(rx_queue_id < sa->rxq_count);\n \trxq_info = &sa->rxq_info[rx_queue_id];\n-\trxq = rxq_info->rxq;\n \n-\tif (rxq == NULL || (rxq_info->state & SFC_RXQ_STARTED) == 0)\n+\tif ((rxq_info->state & SFC_RXQ_STARTED) == 0)\n \t\treturn 0;\n \n-\treturn sap->dp_rx->qdesc_npending(rxq->dp);\n+\treturn sap->dp_rx->qdesc_npending(rxq_info->dp);\n }\n \n static int\ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex 130270dba..886a7a2fd 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -590,7 +590,7 @@ sfc_rx_qflush(struct sfc_adapter *sa, unsigned int sw_index)\n \t\t\tsfc_notice(sa, \"RxQ %u flushed\", sw_index);\n \t}\n \n-\tsa->priv.dp_rx->qpurge(rxq->dp);\n+\tsa->priv.dp_rx->qpurge(rxq_info->dp);\n }\n \n static int\n@@ -704,7 +704,7 @@ sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n \n \tefx_rx_qenable(rxq->common);\n \n-\trc = sa->priv.dp_rx->qstart(rxq->dp, evq->read_ptr);\n+\trc = sa->priv.dp_rx->qstart(rxq_info->dp, evq->read_ptr);\n \tif (rc != 0)\n \t\tgoto fail_dp_qstart;\n \n@@ -723,7 +723,7 @@ sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n \treturn 0;\n \n fail_mac_filter_default_rxq_set:\n-\tsa->priv.dp_rx->qstop(rxq->dp, &rxq->evq->read_ptr);\n+\tsa->priv.dp_rx->qstop(rxq_info->dp, &rxq->evq->read_ptr);\n \n fail_dp_qstart:\n \tsfc_rx_qflush(sa, sw_index);\n@@ -758,7 +758,7 @@ sfc_rx_qstop(struct sfc_adapter *sa, unsigned int sw_index)\n \tsa->eth_dev->data->rx_queue_state[sw_index] =\n \t\tRTE_ETH_QUEUE_STATE_STOPPED;\n \n-\tsa->priv.dp_rx->qstop(rxq->dp, &rxq->evq->read_ptr);\n+\tsa->priv.dp_rx->qstop(rxq_info->dp, &rxq->evq->read_ptr);\n \n \tif (sw_index == 0)\n \t\tefx_mac_filter_default_rxq_clear(sa->nic);\n@@ -1051,11 +1051,11 @@ sfc_rx_qinit(struct sfc_adapter *sa, unsigned int sw_index,\n \n \trc = sa->priv.dp_rx->qcreate(sa->eth_dev->data->port_id, sw_index,\n \t\t\t\t &RTE_ETH_DEV_TO_PCI(sa->eth_dev)->addr,\n-\t\t\t\t socket_id, &info, &rxq->dp);\n+\t\t\t\t socket_id, &info, &rxq_info->dp);\n \tif (rc != 0)\n \t\tgoto fail_dp_rx_qcreate;\n \n-\tevq->dp_rxq = rxq->dp;\n+\tevq->dp_rxq = rxq_info->dp;\n \n \trxq_info->state = SFC_RXQ_INITIALIZED;\n \n@@ -1096,8 +1096,8 @@ sfc_rx_qfini(struct sfc_adapter *sa, unsigned int sw_index)\n \trxq = rxq_info->rxq;\n \tSFC_ASSERT(rxq_info->state == SFC_RXQ_INITIALIZED);\n \n-\tsa->priv.dp_rx->qdestroy(rxq->dp);\n-\trxq->dp = NULL;\n+\tsa->priv.dp_rx->qdestroy(rxq_info->dp);\n+\trxq_info->dp = NULL;\n \n \trxq_info->rxq = NULL;\n \trxq_info->entries = 0;\ndiff --git a/drivers/net/sfc/sfc_rx.h b/drivers/net/sfc/sfc_rx.h\nindex be64004d0..9c946d7cb 100644\n--- a/drivers/net/sfc/sfc_rx.h\n+++ b/drivers/net/sfc/sfc_rx.h\n@@ -59,7 +59,6 @@ struct sfc_rxq {\n \tefsys_mem_t\t\tmem;\n \tunsigned int\t\thw_index;\n \tuint16_t\t\tbuf_size;\n-\tstruct sfc_dp_rxq\t*dp;\n };\n \n static inline unsigned int\n@@ -124,6 +123,7 @@ struct sfc_rxq_info {\n \tefx_rxq_type_t\t\ttype;\n \tunsigned int\t\ttype_flags;\n \tstruct sfc_rxq\t\t*rxq;\n+\tstruct sfc_dp_rxq\t*dp;\n \tboolean_t\t\tdeferred_start;\n \tboolean_t\t\tdeferred_started;\n \tunsigned int\t\trefill_threshold;\n", "prefixes": [ "11/30" ] }