Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50168/?format=api
{ "id": 50168, "url": "https://patches.dpdk.org/api/patches/50168/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1549541873-17403-5-git-send-email-arybchenko@solarflare.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549541873-17403-5-git-send-email-arybchenko@solarflare.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549541873-17403-5-git-send-email-arybchenko@solarflare.com", "date": "2019-02-07T12:17:27", "name": "[04/30] net/sfc: avoid usage of RxQ control structure in info get", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5a618f74a5210233a0576880c610b9d8a42eb4ac", "submitter": { "id": 607, "url": "https://patches.dpdk.org/api/people/607/?format=api", "name": "Andrew Rybchenko", "email": "arybchenko@solarflare.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1549541873-17403-5-git-send-email-arybchenko@solarflare.com/mbox/", "series": [ { "id": 3407, "url": "https://patches.dpdk.org/api/series/3407/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3407", "date": "2019-02-07T12:17:25", "name": "net/sfc: improve multi-process support", "version": 1, "mbox": "https://patches.dpdk.org/series/3407/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50168/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50168/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D505D1B4DD;\n\tThu, 7 Feb 2019 13:18:25 +0100 (CET)", "from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com\n\t[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 6DFFF1B4B6\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 13:18:14 +0100 (CET)", "from webmail.solarflare.com (webmail.solarflare.com\n\t[12.187.104.26])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby mx1-us3.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with\n\tESMTPS id\n\t5B769600057 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:13 +0000 (UTC)", "from ocex03.SolarFlarecom.com (10.20.40.36) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id 15.0.1395.4; Thu, 7 Feb 2019 04:18:09 -0800", "from opal.uk.solarflarecom.com (10.17.10.1) by\n\tocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server\n\t(TLS) id\n\t15.0.1395.4 via Frontend Transport; Thu, 7 Feb 2019 04:18:09 -0800", "from ukv-loginhost.uk.solarflarecom.com\n\t(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])\n\tby opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id\n\tx17CI8td013207 for <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 GMT", "from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])\n\tby ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id\n\t3B4E61613EB\n\tfor <dev@dpdk.org>; Thu, 7 Feb 2019 12:18:08 +0000 (GMT)" ], "X-Virus-Scanned": "Proofpoint Essentials engine", "From": "Andrew Rybchenko <arybchenko@solarflare.com>", "To": "<dev@dpdk.org>", "Date": "Thu, 7 Feb 2019 12:17:27 +0000", "Message-ID": "<1549541873-17403-5-git-send-email-arybchenko@solarflare.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "References": "<1549541873-17403-1-git-send-email-arybchenko@solarflare.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-TM-AS-Product-Ver": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-TM-AS-Result": "Yes-6.784900-4.000000-11", "X-TMASE-MatchedRID": "w0BN55yLmNxKwmT1RH0TueEbUg4xvs+wSoCG4sefl8Qs/uUAk6xP7Ipb\n\twG9fIuIThcnOL9mKiCagr80CieZqSo0GdWKgGbBhHcQQBuf4ZFuVCVhDx8tWMze7GDxzhb0QMCm\n\tLSFOvZt1tMbP5CeY5H80XtYxjZtjK+OKKp3hkzQjk7k9yXJiqqm5N71UY7eq8myiLZetSf8mfop\n\t0ytGwvXiq2rl3dzGQ1Js2BBIj3hlTrbK8FiJhctk+3Oivgj1i39jox0c5HuN10j2YHrLbl7TmTU\n\tIrjEmPu8rCT1hjBM4QpewbKMkSUvP7xRxritJwoS4W/MRhJ1X4=", "X-TM-AS-User-Approved-Sender": "No", "X-TM-AS-User-Blocked-Sender": "No", "X-TMASE-Result": "11-6.784900-4.000000", "X-TMASE-Version": "SMEX-12.5.0.1300-8.5.1010-24412.006", "X-MDID": "1549541894-b6D0fL3ogSpZ", "Subject": "[dpdk-dev] [PATCH 04/30] net/sfc: avoid usage of RxQ control\n\tstructure in info get", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "RxQ control structure contains primary process only data and will\nbecome primary process only. RxQ info get is supported in secondary\nprocess.\n\nSigned-off-by: Andrew Rybchenko <arybchenko@solarflare.com>\n---\n drivers/net/sfc/sfc_ethdev.c | 7 ++-----\n drivers/net/sfc/sfc_rx.c | 10 +++++-----\n drivers/net/sfc/sfc_rx.h | 4 ++--\n 3 files changed, 9 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c\nindex 10e032400..da697c134 100644\n--- a/drivers/net/sfc/sfc_ethdev.c\n+++ b/drivers/net/sfc/sfc_ethdev.c\n@@ -1067,18 +1067,15 @@ sfc_rx_queue_info_get(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n {\n \tstruct sfc_adapter *sa = dev->data->dev_private;\n \tstruct sfc_rxq_info *rxq_info;\n-\tstruct sfc_rxq *rxq;\n \n \tsfc_adapter_lock(sa);\n \n \tSFC_ASSERT(rx_queue_id < sa->rxq_count);\n \n \trxq_info = &sa->rxq_info[rx_queue_id];\n-\trxq = rxq_info->rxq;\n-\tSFC_ASSERT(rxq != NULL);\n \n-\tqinfo->mp = rxq->refill_mb_pool;\n-\tqinfo->conf.rx_free_thresh = rxq->refill_threshold;\n+\tqinfo->mp = rxq_info->refill_mb_pool;\n+\tqinfo->conf.rx_free_thresh = rxq_info->refill_threshold;\n \tqinfo->conf.rx_drop_en = 1;\n \tqinfo->conf.rx_deferred_start = rxq_info->deferred_start;\n \tqinfo->conf.offloads = dev->data->dev_conf.rxmode.offloads;\ndiff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c\nindex c792e0b2e..dcccb96b1 100644\n--- a/drivers/net/sfc/sfc_rx.c\n+++ b/drivers/net/sfc/sfc_rx.c\n@@ -688,7 +688,7 @@ sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index)\n \t\t\trxq_info->type_flags, evq->common, &rxq->common);\n \t\tbreak;\n \tcase EFX_RXQ_TYPE_ES_SUPER_BUFFER: {\n-\t\tstruct rte_mempool *mp = rxq->refill_mb_pool;\n+\t\tstruct rte_mempool *mp = rxq_info->refill_mb_pool;\n \t\tstruct rte_mempool_info mp_info;\n \n \t\trc = rte_mempool_ops_get_info(mp, &mp_info);\n@@ -1033,9 +1033,9 @@ sfc_rx_qinit(struct sfc_adapter *sa, unsigned int sw_index,\n \n \trxq->evq = evq;\n \trxq->hw_index = sw_index;\n-\trxq->refill_threshold =\n+\trxq_info->refill_threshold =\n \t\tRTE_MAX(rx_conf->rx_free_thresh, SFC_RX_REFILL_BULK);\n-\trxq->refill_mb_pool = mb_pool;\n+\trxq_info->refill_mb_pool = mb_pool;\n \trxq->buf_size = buf_size;\n \n \trc = sfc_dma_alloc(sa, \"rxq\", sw_index, EFX_RXQ_SIZE(rxq_info->entries),\n@@ -1044,9 +1044,9 @@ sfc_rx_qinit(struct sfc_adapter *sa, unsigned int sw_index,\n \t\tgoto fail_dma_alloc;\n \n \tmemset(&info, 0, sizeof(info));\n-\tinfo.refill_mb_pool = rxq->refill_mb_pool;\n+\tinfo.refill_mb_pool = rxq_info->refill_mb_pool;\n \tinfo.max_fill_level = rxq_max_fill_level;\n-\tinfo.refill_threshold = rxq->refill_threshold;\n+\tinfo.refill_threshold = rxq_info->refill_threshold;\n \tinfo.buf_size = buf_size;\n \tinfo.batch_max = encp->enc_rx_batch_max;\n \tinfo.prefix_size = encp->enc_rx_prefix_size;\ndiff --git a/drivers/net/sfc/sfc_rx.h b/drivers/net/sfc/sfc_rx.h\nindex 3fba7d8ac..7231379a6 100644\n--- a/drivers/net/sfc/sfc_rx.h\n+++ b/drivers/net/sfc/sfc_rx.h\n@@ -58,8 +58,6 @@ struct sfc_rxq {\n \tefx_rxq_t\t\t*common;\n \tefsys_mem_t\t\tmem;\n \tunsigned int\t\thw_index;\n-\tunsigned int\t\trefill_threshold;\n-\tstruct rte_mempool\t*refill_mb_pool;\n \tuint16_t\t\tbuf_size;\n \tstruct sfc_dp_rxq\t*dp;\n \tunsigned int\t\tstate;\n@@ -128,6 +126,8 @@ struct sfc_rxq_info {\n \tstruct sfc_rxq\t\t*rxq;\n \tboolean_t\t\tdeferred_start;\n \tboolean_t\t\tdeferred_started;\n+\tunsigned int\t\trefill_threshold;\n+\tstruct rte_mempool\t*refill_mb_pool;\n };\n \n int sfc_rx_configure(struct sfc_adapter *sa);\n", "prefixes": [ "04/30" ] }