Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50134/?format=api
{ "id": 50134, "url": "https://patches.dpdk.org/api/patches/50134/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1549373979-31816-1-git-send-email-hari.kumarx.vemula@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549373979-31816-1-git-send-email-hari.kumarx.vemula@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549373979-31816-1-git-send-email-hari.kumarx.vemula@intel.com", "date": "2019-02-05T13:39:39", "name": "[v3] net/bonding: fix create bonded device test failure", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "69956463ffe8452c3686502a0e4640e3e166c3de", "submitter": { "id": 1052, "url": "https://patches.dpdk.org/api/people/1052/?format=api", "name": "Hari Kumar Vemula", "email": "hari.kumarx.vemula@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1549373979-31816-1-git-send-email-hari.kumarx.vemula@intel.com/mbox/", "series": [ { "id": 3387, "url": "https://patches.dpdk.org/api/series/3387/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3387", "date": "2019-02-05T13:39:39", "name": "[v3] net/bonding: fix create bonded device test failure", "version": 3, "mbox": "https://patches.dpdk.org/series/3387/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50134/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50134/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 52D297CCA;\n\tTue, 5 Feb 2019 14:40:23 +0100 (CET)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 0B06D6833;\n\tTue, 5 Feb 2019 14:40:21 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Feb 2019 05:40:20 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga008.jf.intel.com with ESMTP; 05 Feb 2019 05:40:18 -0800", "from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com\n\t[10.102.246.100])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx15DeIjA023779; Tue, 5 Feb 2019 13:40:18 GMT", "from wgcvswdev001.ir.intel.com (localhost [127.0.0.1])\n\tby wgcvswdev001.ir.intel.com with ESMTP id x15DdhYm032146;\n\tTue, 5 Feb 2019 13:39:43 GMT", "(from hvemulax@localhost)\n\tby wgcvswdev001.ir.intel.com with ? id x15DdhYH032142;\n\tTue, 5 Feb 2019 13:39:43 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,564,1539673200\"; d=\"scan'208\";a=\"115415188\"", "From": "Hari Kumar Vemula <hari.kumarx.vemula@intel.com>", "To": "dev@dpdk.org", "Cc": "declan.doherty@intel.com, reshma.pattan@intel.com, radu.nicolau@intel.com,\n\tjananeex.m.parthasarathy@intel.com,\n\tHari Kumar Vemula <hari.kumarx.vemula@intel.com>, stable@dpdk.org", "Date": "Tue, 5 Feb 2019 13:39:39 +0000", "Message-Id": "<1549373979-31816-1-git-send-email-hari.kumarx.vemula@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<1548660533-8710-1-git-send-email-hari.kumarx.vemula@intel.com>", "References": "<1548660533-8710-1-git-send-email-hari.kumarx.vemula@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] net/bonding: fix create bonded device test\n\tfailure", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "test_create_bonded_device is failing due to improper initialisation in\nbonded device configuration. Which leads to crash while setting up queues.\n\nThe value of nb_rx_desc is checked if it is not in range of rx_desc_lim of\nbonded device which fails.\nThis is due to \"rx_desc_lim\" is set to 0 as default value of bonded device\nduring bond_alloc().\nHence nb_rx_desc (1024) is > 0 and test fails.\n\nFix is to set the default values of rx_desc_lim of bonded device to\nappropriate value.\nReceive the values from slaves configuration like done for other existing\nslave configuration\n\nFixes: 2efb58cbab6e (\"bond: new link bonding library\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>\nAcked-by: Chas Williams <chas3@att.com>\n---\nv3: Modified commit message\nv2: Bonded device desc_lim values are received from slave configuration\n---\n drivers/net/bonding/rte_eth_bond_pmd.c | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c\nindex 44deaf119..23cec2549 100644\n--- a/drivers/net/bonding/rte_eth_bond_pmd.c\n+++ b/drivers/net/bonding/rte_eth_bond_pmd.c\n@@ -2228,6 +2228,8 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \n \tuint16_t max_nb_rx_queues = UINT16_MAX;\n \tuint16_t max_nb_tx_queues = UINT16_MAX;\n+\tuint16_t max_rx_desc_lim = UINT16_MAX;\n+\tuint16_t max_tx_desc_lim = UINT16_MAX;\n \n \tdev_info->max_mac_addrs = BOND_MAX_MAC_ADDRS;\n \n@@ -2252,6 +2254,12 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \n \t\t\tif (slave_info.max_tx_queues < max_nb_tx_queues)\n \t\t\t\tmax_nb_tx_queues = slave_info.max_tx_queues;\n+\n+\t\t\tif (slave_info.rx_desc_lim.nb_max < max_rx_desc_lim)\n+\t\t\t\tmax_rx_desc_lim = slave_info.rx_desc_lim.nb_max;\n+\n+\t\t\tif (slave_info.tx_desc_lim.nb_max < max_tx_desc_lim)\n+\t\t\t\tmax_tx_desc_lim = slave_info.tx_desc_lim.nb_max;\n \t\t}\n \t}\n \n@@ -2263,10 +2271,8 @@ bond_ethdev_info(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tmemcpy(&dev_info->default_txconf, &internals->default_txconf,\n \t sizeof(dev_info->default_txconf));\n \n-\tmemcpy(&dev_info->rx_desc_lim, &internals->rx_desc_lim,\n-\t sizeof(dev_info->rx_desc_lim));\n-\tmemcpy(&dev_info->tx_desc_lim, &internals->tx_desc_lim,\n-\t sizeof(dev_info->tx_desc_lim));\n+\tdev_info->rx_desc_lim.nb_max = max_rx_desc_lim;\n+\tdev_info->tx_desc_lim.nb_max = max_tx_desc_lim;\n \n \t/**\n \t * If dedicated hw queues enabled for link bonding device in LACP mode\n", "prefixes": [ "v3" ] }