Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/50129/?format=api
{ "id": 50129, "url": "https://patches.dpdk.org/api/patches/50129/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1549265286-6217-1-git-send-email-pallantlax.poornima@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1549265286-6217-1-git-send-email-pallantlax.poornima@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1549265286-6217-1-git-send-email-pallantlax.poornima@intel.com", "date": "2019-02-04T07:28:06", "name": "vhost: fix sprintf with snprintf", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bb0dd0438fb0114bae63ef7ebe1eb0695980d77a", "submitter": { "id": 1131, "url": "https://patches.dpdk.org/api/people/1131/?format=api", "name": "Poornima, PallantlaX", "email": "pallantlax.poornima@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1549265286-6217-1-git-send-email-pallantlax.poornima@intel.com/mbox/", "series": [ { "id": 3382, "url": "https://patches.dpdk.org/api/series/3382/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3382", "date": "2019-02-04T07:28:06", "name": "vhost: fix sprintf with snprintf", "version": 1, "mbox": "https://patches.dpdk.org/series/3382/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/50129/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/50129/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 13E251B1E9;\n\tMon, 4 Feb 2019 08:28:50 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id BC2C81B129;\n\tMon, 4 Feb 2019 08:28:47 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 Feb 2019 23:28:46 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 03 Feb 2019 23:28:44 -0800", "from wgcvswdev001.ir.intel.com (wgcvswdev001.ir.intel.com\n\t[10.102.246.100])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx147ShjV020492; Mon, 4 Feb 2019 07:28:43 GMT", "from wgcvswdev001.ir.intel.com (localhost [127.0.0.1])\n\tby wgcvswdev001.ir.intel.com with ESMTP id x147S8E3006735;\n\tMon, 4 Feb 2019 07:28:08 GMT", "(from ppoornix@localhost)\n\tby wgcvswdev001.ir.intel.com with ? id x147S8wC006731;\n\tMon, 4 Feb 2019 07:28:08 GMT" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,559,1539673200\"; d=\"scan'208\";a=\"131329013\"", "From": "Pallantla Poornima <pallantlax.poornima@intel.com>", "To": "dev@dpdk.org", "Cc": "reshma.pattan@intel.com, maxime.coquelin@redhat.com, tiwei.bie@intel.com,\n\tzhihong.wang@intel.com,\n\tPallantla Poornima <pallantlax.poornima@intel.com>, stable@dpdk.org", "Date": "Mon, 4 Feb 2019 07:28:06 +0000", "Message-Id": "<1549265286-6217-1-git-send-email-pallantlax.poornima@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<y>", "References": "<y>", "Subject": "[dpdk-dev] [PATCH] vhost: fix sprintf with snprintf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "sprintf function is not secure as it doesn't check the length of string.\nMore secure function snprintf is used.\n\nFixes: d7280c9fff (\"vhost: support selective datapath\")\nCc: stable@dpdk.org\n\nSigned-off-by: Pallantla Poornima <pallantlax.poornima@intel.com>\n---\n lib/librte_vhost/vdpa.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_vhost/vdpa.c b/lib/librte_vhost/vdpa.c\nindex 02083bb8a..fcc2c73a3 100644\n--- a/lib/librte_vhost/vdpa.c\n+++ b/lib/librte_vhost/vdpa.c\n@@ -66,7 +66,7 @@ rte_vdpa_register_device(struct rte_vdpa_dev_addr *addr,\n \tif (i == MAX_VHOST_DEVICE)\n \t\treturn -1;\n \n-\tsprintf(device_name, \"vdpa-dev-%d\", i);\n+\tsnprintf(device_name, sizeof(device_name), \"vdpa-dev-%d\", i);\n \tdev = rte_zmalloc(device_name, sizeof(struct rte_vdpa_device),\n \t\t\tRTE_CACHE_LINE_SIZE);\n \tif (!dev)\n", "prefixes": [] }