Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 50062,
    "url": "https://patches.dpdk.org/api/patches/50062/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190128065549.98266-1-findtheonlyway@gmail.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190128065549.98266-1-findtheonlyway@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190128065549.98266-1-findtheonlyway@gmail.com",
    "date": "2019-01-28T06:55:49",
    "name": "vhost: fix deadlock when vhost unregister",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "2a790ddff038f74450600d7f92d6e22e54750c84",
    "submitter": {
        "id": 1203,
        "url": "https://patches.dpdk.org/api/people/1203/?format=api",
        "name": "孙文杰",
        "email": "findtheonlyway@gmail.com"
    },
    "delegate": {
        "id": 2642,
        "url": "https://patches.dpdk.org/api/users/2642/?format=api",
        "username": "mcoquelin",
        "first_name": "Maxime",
        "last_name": "Coquelin",
        "email": "maxime.coquelin@redhat.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190128065549.98266-1-findtheonlyway@gmail.com/mbox/",
    "series": [
        {
            "id": 3331,
            "url": "https://patches.dpdk.org/api/series/3331/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3331",
            "date": "2019-01-28T06:55:49",
            "name": "vhost: fix deadlock when vhost unregister",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/3331/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/50062/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/50062/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E5B4C25B3;\n\tMon, 28 Jan 2019 07:56:01 +0100 (CET)",
            "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id DD6C920BD;\n\tMon, 28 Jan 2019 07:56:00 +0100 (CET)",
            "by mail-pl1-f194.google.com with SMTP id y1so7330607plp.9;\n\tSun, 27 Jan 2019 22:56:00 -0800 (PST)",
            "from localhost.localdomain ([203.100.54.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tq199sm58661810pfc.97.2019.01.27.22.55.57\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 27 Jan 2019 22:55:58 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=FxPsiBxvWmbGkBNNsSodHFdxnuGyXJT50sm4E0g8T0w=;\n\tb=nNahWc/R1hhkqG0LWWrA4XNNzVVEeviUHgVn88Mnkiq7pXp8Yx+nGjzLD46XcQx0YU\n\tG8cVhzFgTpgMbxTvfp3NWMbUBGfEKghHiGP1uVnQYNQhVlVlkSRGqOCvy4KWAM93Furm\n\tQs6Sji9xYSa2zLPxq4WBx85pMFBz4dQLQfwyN6B1GFO0eJTg33tAF+hlZsD7gEm7Fb/3\n\tFl+iAokpf54tDeUyFVNpD1n9Z/9hP4kECn5Re9YxZZPX6DPvG1I1U1EUe95w+7fxpUh/\n\twh9XdTk/8VJw//bBQkoGY8BjIieukWWkmSNHZqQbedHB8kn6odXH8Xr9B+68/XLrG3ty\n\txVow==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=FxPsiBxvWmbGkBNNsSodHFdxnuGyXJT50sm4E0g8T0w=;\n\tb=dHFBt4yYuU6CYcMwv4/UWtLc+xuzb4ByTZIulMhBMWbyzwJVsFQ1fwcHpoGQJcUHOB\n\tb2ZSByvcCjfHqAodcQ75As2o4eYnUX8fvIbHXpwpFK/ay+74xsYD4Mi9L85Ribj6RAUW\n\tMRnwU8vGzBnLdwC6igfTgNcQrjHawyqgwDYagDMvIGB7V1WhD//Tnx9bDLxkBHK0jhmF\n\tgWnEZ958uVxSgdM9An3zodJ8zFQnxPbEsn7lCwdKpiXAc3gzUjZ6Wzt45KUgjHVHSmxf\n\tBQsHibVKmL0npklUlzY6TvXjHTZGN8D1MYnQlatZmXtLyEOvIMNaJlYtzUqnLuAaY8Ib\n\tnxmg==",
        "X-Gm-Message-State": "AJcUukdYFSqMzqXPlrBKfugEwbjhQcwxdg0pL94RAwopnVInlsC3zWLk\n\tzBpG+QJocB+v7pSXK78rn+M0tPwp",
        "X-Google-Smtp-Source": "ALg8bN4qvlYvwtbk11cYB+95qezbgQ759/qUS2TSwiIlgMNLarR4EXGtbEh4vq6R2NYY8p3QJvuB5A==",
        "X-Received": "by 2002:a17:902:7e44:: with SMTP id\n\ta4mr20718909pln.338.1548658559282; \n\tSun, 27 Jan 2019 22:55:59 -0800 (PST)",
        "From": "sunwenjie <findtheonlyway@gmail.com>",
        "To": "dev@dpdk.org",
        "Cc": "sunwenjie <findtheonlyway@gmail.com>,\n\tstable@dpdk.org",
        "Date": "Mon, 28 Jan 2019 14:55:49 +0800",
        "Message-Id": "<20190128065549.98266-1-findtheonlyway@gmail.com>",
        "X-Mailer": "git-send-email 2.20.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH] vhost: fix deadlock when vhost unregister",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When rte_vhost_driver_unregister  delete the connection fd,\nfdset_try_del will always try and donot release the\nvhostuser.mutex if the fd is busy, but the fdset_event_dispatch\nwill set the  fd to busy and call vhost_user_msg_handler to get\nvhostuser.mutex, which will  cause deadlock. Unlock the\nvhost_user.mutexif fdset_try_del fail and relock it when retry.\n\nFixes: 8b4b949144b8 (\"vhost: fix dead lock on closing in server mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: sunwenjie <findtheonlyway@gmail.com>\n---\n lib/librte_vhost/socket.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex 9cf34ad17..9883b0491 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -961,13 +961,13 @@ rte_vhost_driver_unregister(const char *path)\n \tint count;\n \tstruct vhost_user_connection *conn, *next;\n \n+again:\n \tpthread_mutex_lock(&vhost_user.mutex);\n \n \tfor (i = 0; i < vhost_user.vsocket_cnt; i++) {\n \t\tstruct vhost_user_socket *vsocket = vhost_user.vsockets[i];\n \n \t\tif (!strcmp(vsocket->path, path)) {\n-again:\n \t\t\tpthread_mutex_lock(&vsocket->conn_mutex);\n \t\t\tfor (conn = TAILQ_FIRST(&vsocket->conn_list);\n \t\t\t     conn != NULL;\n@@ -983,6 +983,7 @@ rte_vhost_driver_unregister(const char *path)\n \t\t\t\t\t\t  conn->connfd) == -1) {\n \t\t\t\t\tpthread_mutex_unlock(\n \t\t\t\t\t\t\t&vsocket->conn_mutex);\n+\t\t\t\t\tpthread_mutex_unlock(&vhost_user.mutex);\n \t\t\t\t\tgoto again;\n \t\t\t\t}\n \n",
    "prefixes": []
}