Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49952/?format=api
{ "id": 49952, "url": "https://patches.dpdk.org/api/patches/49952/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190118152326.22686-1-gage.eads@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190118152326.22686-1-gage.eads@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190118152326.22686-1-gage.eads@intel.com", "date": "2019-01-18T15:23:21", "name": "[v3,0/5] Add non-blocking ring", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 586, "url": "https://patches.dpdk.org/api/people/586/?format=api", "name": "Eads, Gage", "email": "gage.eads@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190118152326.22686-1-gage.eads@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/49952/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/49952/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 08BB32B95;\n\tFri, 18 Jan 2019 16:24:35 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id A5923288C\n\tfor <dev@dpdk.org>; Fri, 18 Jan 2019 16:24:33 +0100 (CET)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t18 Jan 2019 07:24:32 -0800", "from txasoft-yocto.an.intel.com (HELO txasoft-yocto.an.intel.com.)\n\t([10.123.72.192])\n\tby orsmga005.jf.intel.com with ESMTP; 18 Jan 2019 07:24:31 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,491,1539673200\"; d=\"scan'208\";a=\"292610260\"", "From": "Gage Eads <gage.eads@intel.com>", "To": "dev@dpdk.org", "Cc": "olivier.matz@6wind.com, arybchenko@solarflare.com,\n\tbruce.richardson@intel.com, konstantin.ananyev@intel.com,\n\tstephen@networkplumber.org", "Date": "Fri, 18 Jan 2019 09:23:21 -0600", "Message-Id": "<20190118152326.22686-1-gage.eads@intel.com>", "X-Mailer": "git-send-email 2.13.6", "In-Reply-To": "<20190115235227.14013-1-gage.eads@intel.com>", "References": "<20190115235227.14013-1-gage.eads@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 0/5] Add non-blocking ring", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For some users, the rte ring's \"non-preemptive\" constraint is not acceptable;\nfor example, if the application uses a mixture of pinned high-priority threads\nand multiplexed low-priority threads that share a mempool.\n\nThis patchset introduces a non-blocking ring, on top of which a mempool can run.\nCrucially, the non-blocking algorithm relies on a 128-bit compare-and-swap, so\nit is currently limited to x86_64 machines. This is also an experimental API,\nso RING_F_NB users must build with the ALLOW_EXPERIMENTAL_API flag.\n\nThe ring uses more compare-and-swap atomic operations than the regular rte ring:\nWith no contention, an enqueue of n pointers uses (1 + 2n) CAS operations and a\ndequeue of n pointers uses 2. This algorithm has worse average-case performance\nthan the regular rte ring (particularly a highly-contended ring with large bulk\naccesses), however:\n- For applications with preemptible pthreads, the regular rte ring's worst-case\n performance (i.e. one thread being preempted in the update_tail() critical\n section) is much worse than the non-blocking ring's.\n- Software caching can mitigate the average case performance for ring-based\n algorithms. For example, a non-blocking ring based mempool (a likely use case\n for this ring) with per-thread caching.\n\nThe non-blocking ring is enabled via a new flag, RING_F_NB. For ease-of-use,\nexisting ring enqueue/dequeue functions work with both \"regular\" and\nnon-blocking rings.\n\nThis patchset also adds non-blocking versions of ring_autotest and\nring_perf_autotest, and a non-blocking ring based mempool.\n\nThis patchset makes one API change; a deprecation notice will be posted in a\nseparate commit.\n\nThis patchset depends on the non-blocking stack patchset[1].\n\n[1] http://mails.dpdk.org/archives/dev/2019-January/123653.html\n\nv3:\n - Avoid the ABI break by putting 64-bit head and tail values in the same\n cacheline as struct rte_ring's prod and cons members.\n - Don't attempt to compile rte_atomic128_cmpset without\n ALLOW_EXPERIMENTAL_API, as this would break a large number of libraries.\n - Add a helpful warning to __rte_ring_do_nb_enqueue_mp() in case someone tries\n to use RING_F_NB without the ALLOW_EXPERIMENTAL_API flag.\n - Update the ring mempool to use experimental APIs\n - Clarify that RINB_F_NB is only limited to x86_64 currently; ARMv8.1-A builds\n can eventually support it with the CASP instruction.\n\nv2:\n - Merge separate docs commit into patch #5\n - Convert uintptr_t to size_t\n - Add a compile-time check for the size of size_t\n - Fix a space-after-typecast issue\n - Fix an unnecessary-parentheses checkpatch warning\n - Bump librte_ring's library version\n\nGage Eads (5):\n ring: add 64-bit headtail structure\n ring: add a non-blocking implementation\n test_ring: add non-blocking ring autotest\n test_ring_perf: add non-blocking ring perf test\n mempool/ring: add non-blocking ring handlers\n\n doc/guides/prog_guide/env_abstraction_layer.rst | 2 +-\n drivers/mempool/ring/Makefile | 1 +\n drivers/mempool/ring/meson.build | 2 +\n drivers/mempool/ring/rte_mempool_ring.c | 58 ++-\n lib/librte_eventdev/rte_event_ring.h | 2 +-\n lib/librte_ring/Makefile | 3 +-\n lib/librte_ring/rte_ring.c | 72 ++-\n lib/librte_ring/rte_ring.h | 574 ++++++++++++++++++++++--\n lib/librte_ring/rte_ring_generic_64.h | 152 +++++++\n lib/librte_ring/rte_ring_version.map | 7 +\n test/test/test_ring.c | 57 ++-\n test/test/test_ring_perf.c | 19 +-\n 12 files changed, 874 insertions(+), 75 deletions(-)\n create mode 100644 lib/librte_ring/rte_ring_generic_64.h", "diff": null, "prefixes": [ "v3", "0/5" ] }