Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49789/?format=api
https://patches.dpdk.org/api/patches/49789/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190114100022.14867-1-yskoh@mellanox.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190114100022.14867-1-yskoh@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190114100022.14867-1-yskoh@mellanox.com", "date": "2019-01-14T10:00:21", "name": "[1/2] app/testpmd: fix wrong pointer reference in macswap", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e6c4450b8c18d2b5a6d23130a2b9df1d2023192e", "submitter": { "id": 636, "url": "https://patches.dpdk.org/api/people/636/?format=api", "name": "Yongseok Koh", "email": "yskoh@mellanox.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190114100022.14867-1-yskoh@mellanox.com/mbox/", "series": [ { "id": 3160, "url": "https://patches.dpdk.org/api/series/3160/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3160", "date": "2019-01-14T10:00:22", "name": "[1/2] app/testpmd: fix wrong pointer reference in macswap", "version": 1, "mbox": "https://patches.dpdk.org/series/3160/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/49789/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/49789/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 190611B444;\n\tMon, 14 Jan 2019 11:00:48 +0100 (CET)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id E5C101B192\n\tfor <dev@dpdk.org>; Mon, 14 Jan 2019 11:00:43 +0100 (CET)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tyskoh@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 14 Jan 2019 12:00:39 +0200", "from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx\n\t[10.101.0.96])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x0EA0bru016885;\n\tMon, 14 Jan 2019 12:00:37 +0200" ], "From": "Yongseok Koh <yskoh@mellanox.com>", "To": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com", "Cc": "dev@dpdk.org, qi.z.zhang@intel.com, stable@dpdk.org", "Date": "Mon, 14 Jan 2019 02:00:21 -0800", "Message-Id": "<20190114100022.14867-1-yskoh@mellanox.com>", "X-Mailer": "git-send-email 2.11.0", "Subject": "[dpdk-dev] [PATCH 1/2] app/testpmd: fix wrong pointer reference in\n\tmacswap", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The pointer is misused and could set wrong MAC address. As a result, some\nof packets can be dropped in receiver side due to MAC address mismatch.\nThis can be shown as performance degradation.\n\nBugzilla ID: 188\n\nFixes: 62b52877adbe (\"app/testpmd: batch MAC swap for performance on x86\")\nCc: qi.z.zhang@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\n---\n app/test-pmd/macswap_sse.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/app/test-pmd/macswap_sse.h b/app/test-pmd/macswap_sse.h\nindex 7d268bfbb0..662fe79cf9 100644\n--- a/app/test-pmd/macswap_sse.h\n+++ b/app/test-pmd/macswap_sse.h\n@@ -76,7 +76,7 @@ do_macswap(struct rte_mbuf *pkts[], uint16_t nb,\n \t\teth_hdr[0] = rte_pktmbuf_mtod(mb[0], struct ether_hdr *);\n \n \t\t/* Swap dest and src mac addresses. */\n-\t\taddr0 = _mm_loadu_si128((__m128i *)eth_hdr);\n+\t\taddr0 = _mm_loadu_si128((__m128i *)eth_hdr[0]);\n \t\taddr0 = _mm_shuffle_epi8(addr0, shfl_msk);\n \t\t_mm_storeu_si128((__m128i *)eth_hdr[0], addr0);\n \n", "prefixes": [ "1/2" ] }{ "id": 49789, "url": "