Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49762/?format=api
{ "id": 49762, "url": "https://patches.dpdk.org/api/patches/49762/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190110050218.3081-1-findtheonlyway@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190110050218.3081-1-findtheonlyway@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190110050218.3081-1-findtheonlyway@gmail.com", "date": "2019-01-10T05:02:18", "name": "vhostuser: fix deadlock when vhost unregister", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f39b0ecfd13c1181f2f79996ea33b5f11b621918", "submitter": { "id": 1203, "url": "https://patches.dpdk.org/api/people/1203/?format=api", "name": "孙文杰", "email": "findtheonlyway@gmail.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190110050218.3081-1-findtheonlyway@gmail.com/mbox/", "series": [ { "id": 3140, "url": "https://patches.dpdk.org/api/series/3140/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3140", "date": "2019-01-10T05:02:18", "name": "vhostuser: fix deadlock when vhost unregister", "version": 1, "mbox": "https://patches.dpdk.org/series/3140/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/49762/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/49762/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 8A5B81B555;\n\tSat, 12 Jan 2019 23:18:34 +0100 (CET)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id A72111B57B\n\tfor <dev@dpdk.org>; Thu, 10 Jan 2019 06:02:26 +0100 (CET)", "by mail-pg1-f193.google.com with SMTP id m1so4321136pgq.8\n\tfor <dev@dpdk.org>; Wed, 09 Jan 2019 21:02:26 -0800 (PST)", "from localhost.localdomain ([203.100.54.194])\n\tby smtp.gmail.com with ESMTPSA id\n\tm67sm140130168pfb.25.2019.01.09.21.02.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 09 Jan 2019 21:02:24 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=MofC+7J4ke+aWtW2Raoom8QL3U3gU7uiL1eVvq7KZ2E=;\n\tb=knlidF2uC1thtBlRg6abKMcqGx52QFGYw+P3k0EU9GYwoaktuhngPbNdi1NbHqkzfx\n\tgHEhXwMbXvC/vKFOQeZRyfcdOlNjf7sjZ+oGOdMAX2DiJBJdIK8ywUcPCxbkyDZctSgH\n\t9wmBAZC00ZLvqCSDaePXuXXbaAQmg9AImiiLVJT/V1WqVbrysT0HoV54ZGiJ01udX8v7\n\tBrD2sR9yHCcW9/tc4/uUH44CuBJVTyZ/UsP6+Ol7ElCSZtbQ8JLGkVw4CDXKwYHsXIuS\n\tQKV09T3u7stnYtO3kyo2NPBQGjh1ol+4SmGaqQhwuFlGR80hhkrglEe78EzTaWnD8HUg\n\t30tQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=MofC+7J4ke+aWtW2Raoom8QL3U3gU7uiL1eVvq7KZ2E=;\n\tb=iFCRvHvZG+UvvBq4QSJuSWzBBYGpV7fZxJeZtblbJf5vCEsfALyGajkQUM3TqukbPp\n\tnCMWAKijfJE0WBrBsL68l13+VuDRN6XWEbdexL7eZjMmJn/lzfK3pFzfzzrEhheIrV4Q\n\t5NK2mwV2zRHpV7T6DjnVjfx05wkHh7cF+qzzw1k5+Cw1fHYDrVU5NrCKsnYxBh41USQl\n\tX1cGs0WA67Z3GV9r7uKtZcJZnjQO8FvAjTfsX8uOfGQ9iAnKlcnyH9WZY1wDI/PTcjbW\n\tOev9yJOjyc7qvjwneF4k4Sd63VQ3O1RAezoOPzXSAC+sBjfUmeFWH7BrkDQbYE5D8Swt\n\tYd5w==", "X-Gm-Message-State": "AJcUukfPQg7TVIg9st7vv7vHf6GQq/mARiawiExx4J5WX38/dIGZxYWj\n\tS2oYQ03ySOpjvWpRDg9YgRkNAfPP", "X-Google-Smtp-Source": "ALg8bN5JniD30AniFMR2bjNhn2BZjtE1UKjMhElcwHFMGQjXi38ykQYoeWSZzvAzZikmJ9JmqNV4eA==", "X-Received": "by 2002:a63:b649:: with SMTP id v9mr8091973pgt.436.1547096545536;\n\tWed, 09 Jan 2019 21:02:25 -0800 (PST)", "From": "sunwenjie <findtheonlyway@gmail.com>", "To": "dev@dpdk.org", "Cc": "sunwenjie <findtheonlyway@gmail.com>,\n\tsunwenjie <sunwenjie@didichuxing.com>", "Date": "Thu, 10 Jan 2019 13:02:18 +0800", "Message-Id": "<20190110050218.3081-1-findtheonlyway@gmail.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Sat, 12 Jan 2019 23:18:31 +0100", "Subject": "[dpdk-dev] [PATCH] vhostuser: fix deadlock when vhost unregister", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When rte_vhost_driver_unregister delete the connection fd, fdset_try_del will\n always try and donot release the vhostuser.mutex if the fd is busy, but the\n fdset_event_dispatch will set the fd to busy and call vhost_user_msg_handler\n to get vhostuser.mutex, which will cause deadlock. Unlock the vhost_user.mutex\n if fdset_try_del fail and relock it when retry.\n\nSigned-off-by: findtheonlway <findtheonlyway@gmail.com>\nSigned-off-by: sunwenjie <sunwenjie@didichuxing.com>\n---\n lib/librte_vhost/socket.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c\nindex 9cf34ad17..a9effa115 100644\n--- a/lib/librte_vhost/socket.c\n+++ b/lib/librte_vhost/socket.c\n@@ -961,13 +961,12 @@ rte_vhost_driver_unregister(const char *path)\n \tint count;\n \tstruct vhost_user_connection *conn, *next;\n \n+again:\n \tpthread_mutex_lock(&vhost_user.mutex);\n \n \tfor (i = 0; i < vhost_user.vsocket_cnt; i++) {\n \t\tstruct vhost_user_socket *vsocket = vhost_user.vsockets[i];\n-\n \t\tif (!strcmp(vsocket->path, path)) {\n-again:\n \t\t\tpthread_mutex_lock(&vsocket->conn_mutex);\n \t\t\tfor (conn = TAILQ_FIRST(&vsocket->conn_list);\n \t\t\t conn != NULL;\n@@ -981,6 +980,7 @@ rte_vhost_driver_unregister(const char *path)\n \t\t\t\t */\n \t\t\t\tif (fdset_try_del(&vhost_user.fdset,\n \t\t\t\t\t\t conn->connfd) == -1) {\n+\t\t\t\t\tpthread_mutex_unlock(&vhost_user.mutex);\n \t\t\t\t\tpthread_mutex_unlock(\n \t\t\t\t\t\t\t&vsocket->conn_mutex);\n \t\t\t\t\tgoto again;\n", "prefixes": [] }