Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49757/?format=api
{ "id": 49757, "url": "https://patches.dpdk.org/api/patches/49757/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20190111203520.19944-4-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190111203520.19944-4-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190111203520.19944-4-stephen@networkplumber.org", "date": "2019-01-11T20:35:16", "name": "[v2,3/7] net/tap: check interface name in kvargs", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8af6089e16b29076462f21c35e556770a6618f06", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20190111203520.19944-4-stephen@networkplumber.org/mbox/", "series": [ { "id": 3139, "url": "https://patches.dpdk.org/api/series/3139/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=3139", "date": "2019-01-11T20:35:13", "name": "net/tap: fixes and cleanups", "version": 2, "mbox": "https://patches.dpdk.org/series/3139/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/49757/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/49757/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5D49C1BBD1;\n\tFri, 11 Jan 2019 21:35:35 +0100 (CET)", "from mail-pl1-f194.google.com (mail-pl1-f194.google.com\n\t[209.85.214.194]) by dpdk.org (Postfix) with ESMTP id A71971BB69\n\tfor <dev@dpdk.org>; Fri, 11 Jan 2019 21:35:31 +0100 (CET)", "by mail-pl1-f194.google.com with SMTP id y1so7239873plp.9\n\tfor <dev@dpdk.org>; Fri, 11 Jan 2019 12:35:31 -0800 (PST)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tf32sm96610438pgf.80.2019.01.11.12.35.29\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 11 Jan 2019 12:35:29 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=sm8oylN+wibegG576IC3px05Y+1N1dPep4LHHEUGScU=;\n\tb=HK/Y6KrRe4sCA8gl0wu8dVQ/5t5TCKBRnu+RW5D+pryFh6qgt3ZA1CG8h1AG4sO58q\n\tJ2Mxbr/NzoKO1tZsztY3DTEsbc35tCLw+j+5e00wUMTMHELgxSVJD/+KC902eENzEVcz\n\tmDB4kRT4DzFM7HQQvWRhMF/9wLxPNGHNr6QEb8wdA2QppY9HvTBTndU4uKmm9Io3D6Kz\n\t7+msuFEJ1H7rgNcozf2U1Ul9MAwaAt0p41AtPsWrFygXrDmCXRBtgsl7TpqzjstZp5sC\n\tYeLdOMYwYrApCH3BJ2UYAobEfYd/f2Kd1W9bAhlbcZmPAGxYfGZtOxtVuYMpUOPYjnFp\n\t8tfA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=sm8oylN+wibegG576IC3px05Y+1N1dPep4LHHEUGScU=;\n\tb=F62lSd3glWNogqQGseV8B/fM3bdzyqWzyYcUYfjTv8In2HhBdgY0+njH7NzD/Q1jFV\n\ts2a1S83xY0i9T7WkGw4HfNDjY3xD8G7z2rJ6TSl8gOnCkI6EWWJJQaJq6fs/EHhMsd5c\n\tXRCdxEMNAVrs84KZbSFKWwOE55AcRBMtvKoJMchhIygrvr58PUaDfue/KfLYF/mRblh/\n\tZgBjSfb4iMG7GUYOYnZIOPKd8z7xFpouNRgSKTw+JoROfafV043Zq7W1cjUvlYW3+0GU\n\t8MoGCa8DG486jYh5BlhuPV8yyreEhW+Sd83+rYh+KQWx196Aw/XJ8DGBtCSS+yGctpLZ\n\tqLrg==", "X-Gm-Message-State": "AJcUukdfQQ7bJyLOYOYm6uspTIqdWgGS7z2rJ0YwfMaPCImThJIgyoqg\n\tTg+pggIAcrDVhAKl2N+JBNRN0w==", "X-Google-Smtp-Source": "ALg8bN7EzFCFmRalrkAtyM0iS/qmI5zXG65IeIj1Zp6U3SSd6g/NV3ZN/IaqFL8foHeA30e+aLEmHQ==", "X-Received": "by 2002:a17:902:e085:: with SMTP id\n\tcb5mr15880514plb.24.1547238930599; \n\tFri, 11 Jan 2019 12:35:30 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "keith.wiles@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Fri, 11 Jan 2019 12:35:16 -0800", "Message-Id": "<20190111203520.19944-4-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190111203520.19944-1-stephen@networkplumber.org>", "References": "<20190111180659.5972-1-stephen@networkplumber.org>\n\t<20190111203520.19944-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/7] net/tap: check interface name in kvargs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If interface name is passed to remote or iface then check\nthe length and for invalid characters. This avoids problems where\nname gets truncated or rejected by kernel.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nAcked-by Keith Wiles <keith.wiles@intel.com>\n---\n drivers/net/tap/rte_eth_tap.c | 38 +++++++++++++++++++++++++++++++----\n 1 file changed, 34 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 11e402e42bd0..d8e9ede7ac7c 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -37,6 +37,7 @@\n #include <linux/if_tun.h>\n #include <linux/if_ether.h>\n #include <fcntl.h>\n+#include <ctype.h>\n \n #include <tap_rss.h>\n #include <rte_eth_tap.h>\n@@ -1884,6 +1885,24 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,\n \treturn -EINVAL;\n }\n \n+/* make sure name is a possible Linux network device name */\n+static bool\n+is_valid_iface(const char *name)\n+{\n+\tif (*name == '\\0')\n+\t\treturn false;\n+\n+\tif (strnlen(name, IFNAMSIZ) == IFNAMSIZ)\n+\t\treturn false;\n+\n+\twhile (*name) {\n+\t\tif (*name == '/' || *name == ':' || isspace(*name))\n+\t\t\treturn false;\n+\t\tname++;\n+\t}\n+\treturn true;\n+}\n+\n static int\n set_interface_name(const char *key __rte_unused,\n \t\t const char *value,\n@@ -1891,12 +1910,17 @@ set_interface_name(const char *key __rte_unused,\n {\n \tchar *name = (char *)extra_args;\n \n-\tif (value)\n+\tif (value) {\n+\t\tif (!is_valid_iface(value)) {\n+\t\t\tTAP_LOG(ERR, \"TAP invalid remote interface name (%s)\",\n+\t\t\t\tvalue);\n+\t\t\treturn -1;\n+\t\t}\n \t\tstrlcpy(name, value, RTE_ETH_NAME_MAX_LEN);\n-\telse\n+\t} else {\n \t\tsnprintf(name, RTE_ETH_NAME_MAX_LEN, \"%s%d\",\n \t\t\t DEFAULT_TAP_NAME, tap_unit - 1);\n-\n+\t}\n \treturn 0;\n }\n \n@@ -1907,8 +1931,14 @@ set_remote_iface(const char *key __rte_unused,\n {\n \tchar *name = (char *)extra_args;\n \n-\tif (value)\n+\tif (value) {\n+\t\tif (!is_valid_iface(value)) {\n+\t\t\tTAP_LOG(ERR, \"TAP invalid remote interface name (%s)\",\n+\t\t\t\tvalue);\n+\t\t\treturn -1;\n+\t\t}\n \t\tstrlcpy(name, value, RTE_ETH_NAME_MAX_LEN);\n+\t}\n \n \treturn 0;\n }\n", "prefixes": [ "v2", "3/7" ] }