Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 49395,
    "url": "https://patches.dpdk.org/api/patches/49395/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1546508529-12227-1-git-send-email-phil.yang@arm.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1546508529-12227-1-git-send-email-phil.yang@arm.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1546508529-12227-1-git-send-email-phil.yang@arm.com",
    "date": "2019-01-03T09:42:09",
    "name": "eal/atomic: reimplement rte atomic APIs with atomic builtins",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "89fcb97479eb55a3c98acd8babca539e13025f38",
    "submitter": {
        "id": 833,
        "url": "https://patches.dpdk.org/api/people/833/?format=api",
        "name": "Phil Yang",
        "email": "phil.yang@arm.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1546508529-12227-1-git-send-email-phil.yang@arm.com/mbox/",
    "series": [
        {
            "id": 2995,
            "url": "https://patches.dpdk.org/api/series/2995/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2995",
            "date": "2019-01-03T09:42:09",
            "name": "eal/atomic: reimplement rte atomic APIs with atomic builtins",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/2995/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/49395/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/49395/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D59ED5911;\n\tThu,  3 Jan 2019 10:42:26 +0100 (CET)",
            "from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id 82ADA5424\n\tfor <dev@dpdk.org>; Thu,  3 Jan 2019 10:42:25 +0100 (CET)",
            "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C89E5EBD;\n\tThu,  3 Jan 2019 01:42:24 -0800 (PST)",
            "from phil-VirtualBox.shanghai.arm.com (unknown [10.169.107.181])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id\n\t4B6253F5CF; Thu,  3 Jan 2019 01:42:24 -0800 (PST)"
        ],
        "From": "Phil Yang <phil.yang@arm.com>",
        "To": "dev@dpdk.org",
        "Cc": "nd@arm.com",
        "Date": "Thu,  3 Jan 2019 17:42:09 +0800",
        "Message-Id": "<1546508529-12227-1-git-send-email-phil.yang@arm.com>",
        "X-Mailer": "git-send-email 2.7.4",
        "Subject": "[dpdk-dev] [PATCH] eal/atomic: reimplement rte atomic APIs with\n\tatomic builtins",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "'__sync' builtins are deprecated, enable '__atomic' builtins for\ngeneric atomic operations.\n\nSigned-off-by: Phil Yang <phil.yang@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\nTested-by: Phil Yang <phil.yang@arm.com>\n\n---\n lib/librte_eal/common/include/generic/rte_atomic.h | 80 ++++++++++++++++++++++\n 1 file changed, 80 insertions(+)",
    "diff": "diff --git a/lib/librte_eal/common/include/generic/rte_atomic.h b/lib/librte_eal/common/include/generic/rte_atomic.h\nindex b99ba46..260cdf3 100644\n--- a/lib/librte_eal/common/include/generic/rte_atomic.h\n+++ b/lib/librte_eal/common/include/generic/rte_atomic.h\n@@ -186,7 +186,12 @@ rte_atomic16_cmpset(volatile uint16_t *dst, uint16_t exp, uint16_t src);\n static inline int\n rte_atomic16_cmpset(volatile uint16_t *dst, uint16_t exp, uint16_t src)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_bool_compare_and_swap(dst, exp, src);\n+#else\n+\treturn __atomic_compare_exchange(dst, &exp, &src, 0, __ATOMIC_ACQUIRE,\n+\t\t\t__ATOMIC_ACQUIRE) ? 1 : 0;\n+#endif\n }\n #endif\n \n@@ -283,7 +288,11 @@ rte_atomic16_set(rte_atomic16_t *v, int16_t new_value)\n static inline void\n rte_atomic16_add(rte_atomic16_t *v, int16_t inc)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \t__sync_fetch_and_add(&v->cnt, inc);\n+#else\n+\t__atomic_fetch_add(&v->cnt, inc, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -297,7 +306,11 @@ rte_atomic16_add(rte_atomic16_t *v, int16_t inc)\n static inline void\n rte_atomic16_sub(rte_atomic16_t *v, int16_t dec)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \t__sync_fetch_and_sub(&v->cnt, dec);\n+#else\n+\t__atomic_fetch_sub(&v->cnt, dec, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -350,7 +363,11 @@ rte_atomic16_dec(rte_atomic16_t *v)\n static inline int16_t\n rte_atomic16_add_return(rte_atomic16_t *v, int16_t inc)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_add_and_fetch(&v->cnt, inc);\n+#else\n+\treturn __atomic_add_fetch(&v->cnt, inc, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -370,7 +387,11 @@ rte_atomic16_add_return(rte_atomic16_t *v, int16_t inc)\n static inline int16_t\n rte_atomic16_sub_return(rte_atomic16_t *v, int16_t dec)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_sub_and_fetch(&v->cnt, dec);\n+#else\n+\treturn __atomic_sub_fetch(&v->cnt, dec, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -389,7 +410,11 @@ static inline int rte_atomic16_inc_and_test(rte_atomic16_t *v);\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic16_inc_and_test(rte_atomic16_t *v)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_add_and_fetch(&v->cnt, 1) == 0;\n+#else\n+\treturn __atomic_add_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE) == 0;\n+#endif\n }\n #endif\n \n@@ -409,7 +434,11 @@ static inline int rte_atomic16_dec_and_test(rte_atomic16_t *v);\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic16_dec_and_test(rte_atomic16_t *v)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_sub_and_fetch(&v->cnt, 1) == 0;\n+#else\n+\treturn __atomic_sub_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE) == 0;\n+#endif\n }\n #endif\n \n@@ -469,7 +498,13 @@ rte_atomic32_cmpset(volatile uint32_t *dst, uint32_t exp, uint32_t src);\n static inline int\n rte_atomic32_cmpset(volatile uint32_t *dst, uint32_t exp, uint32_t src)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_bool_compare_and_swap(dst, exp, src);\n+#else\n+\treturn __atomic_compare_exchange(dst, &exp, &src, 0, __ATOMIC_ACQUIRE,\n+\t\t\t__ATOMIC_ACQUIRE) ? 1 : 0;\n+#endif\n+\n }\n #endif\n \n@@ -566,7 +601,11 @@ rte_atomic32_set(rte_atomic32_t *v, int32_t new_value)\n static inline void\n rte_atomic32_add(rte_atomic32_t *v, int32_t inc)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \t__sync_fetch_and_add(&v->cnt, inc);\n+#else\n+\t__atomic_fetch_add(&v->cnt, inc, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -580,7 +619,11 @@ rte_atomic32_add(rte_atomic32_t *v, int32_t inc)\n static inline void\n rte_atomic32_sub(rte_atomic32_t *v, int32_t dec)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \t__sync_fetch_and_sub(&v->cnt, dec);\n+#else\n+\t__atomic_fetch_sub(&v->cnt, dec, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -633,7 +676,11 @@ rte_atomic32_dec(rte_atomic32_t *v)\n static inline int32_t\n rte_atomic32_add_return(rte_atomic32_t *v, int32_t inc)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_add_and_fetch(&v->cnt, inc);\n+#else\n+\treturn __atomic_add_fetch(&v->cnt, inc, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -653,7 +700,11 @@ rte_atomic32_add_return(rte_atomic32_t *v, int32_t inc)\n static inline int32_t\n rte_atomic32_sub_return(rte_atomic32_t *v, int32_t dec)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_sub_and_fetch(&v->cnt, dec);\n+#else\n+\treturn __atomic_sub_fetch(&v->cnt, dec, __ATOMIC_ACQUIRE);\n+#endif\n }\n \n /**\n@@ -672,7 +723,11 @@ static inline int rte_atomic32_inc_and_test(rte_atomic32_t *v);\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic32_inc_and_test(rte_atomic32_t *v)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_add_and_fetch(&v->cnt, 1) == 0;\n+#else\n+\treturn __atomic_add_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE) == 0;\n+#endif\n }\n #endif\n \n@@ -692,7 +747,11 @@ static inline int rte_atomic32_dec_and_test(rte_atomic32_t *v);\n #ifdef RTE_FORCE_INTRINSICS\n static inline int rte_atomic32_dec_and_test(rte_atomic32_t *v)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_sub_and_fetch(&v->cnt, 1) == 0;\n+#else\n+\treturn __atomic_sub_fetch(&v->cnt, 1, __ATOMIC_ACQUIRE) == 0;\n+#endif\n }\n #endif\n \n@@ -751,7 +810,12 @@ rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t exp, uint64_t src);\n static inline int\n rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t exp, uint64_t src)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_bool_compare_and_swap(dst, exp, src);\n+#else\n+\treturn __atomic_compare_exchange(dst, &exp, &src, 0, __ATOMIC_ACQUIRE,\n+\t\t\t__ATOMIC_ACQUIRE) ? 1 : 0;\n+#endif\n }\n #endif\n \n@@ -902,7 +966,11 @@ rte_atomic64_add(rte_atomic64_t *v, int64_t inc);\n static inline void\n rte_atomic64_add(rte_atomic64_t *v, int64_t inc)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \t__sync_fetch_and_add(&v->cnt, inc);\n+#else\n+\t__atomic_fetch_add(&v->cnt, inc, __ATOMIC_ACQUIRE);\n+#endif\n }\n #endif\n \n@@ -921,7 +989,11 @@ rte_atomic64_sub(rte_atomic64_t *v, int64_t dec);\n static inline void\n rte_atomic64_sub(rte_atomic64_t *v, int64_t dec)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \t__sync_fetch_and_sub(&v->cnt, dec);\n+#else\n+\t__atomic_fetch_sub(&v->cnt, dec, __ATOMIC_ACQUIRE);\n+#endif\n }\n #endif\n \n@@ -979,7 +1051,11 @@ rte_atomic64_add_return(rte_atomic64_t *v, int64_t inc);\n static inline int64_t\n rte_atomic64_add_return(rte_atomic64_t *v, int64_t inc)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_add_and_fetch(&v->cnt, inc);\n+#else\n+\treturn __atomic_add_fetch(&v->cnt, inc, __ATOMIC_ACQUIRE);\n+#endif\n }\n #endif\n \n@@ -1003,7 +1079,11 @@ rte_atomic64_sub_return(rte_atomic64_t *v, int64_t dec);\n static inline int64_t\n rte_atomic64_sub_return(rte_atomic64_t *v, int64_t dec)\n {\n+#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70100)\n \treturn __sync_sub_and_fetch(&v->cnt, dec);\n+#else\n+\treturn __atomic_sub_fetch(&v->cnt, dec, __ATOMIC_ACQUIRE);\n+#endif\n }\n #endif\n \n",
    "prefixes": []
}