Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49248/?format=api
{ "id": 49248, "url": "https://patches.dpdk.org/api/patches/49248/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181221181808.47816-1-jeffrey.b.shaw@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181221181808.47816-1-jeffrey.b.shaw@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181221181808.47816-1-jeffrey.b.shaw@intel.com", "date": "2018-12-21T18:18:08", "name": "[v3] eal: simplify RTE_PMD_DEBUG_TRACE", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1711d6bf42e45d0b11c0de8af0d96ecce958e623", "submitter": { "id": 30, "url": "https://patches.dpdk.org/api/people/30/?format=api", "name": "Jeff Shaw", "email": "jeffrey.b.shaw@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181221181808.47816-1-jeffrey.b.shaw@intel.com/mbox/", "series": [ { "id": 2931, "url": "https://patches.dpdk.org/api/series/2931/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2931", "date": "2018-12-21T18:18:08", "name": "[v3] eal: simplify RTE_PMD_DEBUG_TRACE", "version": 3, "mbox": "https://patches.dpdk.org/series/2931/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/49248/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/49248/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E66E01BE5F;\n\tFri, 21 Dec 2018 19:22:20 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id E7EB91BDAF\n\tfor <dev@dpdk.org>; Fri, 21 Dec 2018 19:22:18 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t21 Dec 2018 10:21:40 -0800", "from ae13-28.jf.intel.com ([10.166.188.62])\n\tby orsmga001.jf.intel.com with ESMTP; 21 Dec 2018 10:21:39 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,382,1539673200\"; d=\"scan'208\";a=\"120775218\"", "From": "Jeff Shaw <jeffrey.b.shaw@intel.com>", "To": "dev@dpdk.org", "Cc": "mattias.ronnblom@ericsson.com, stephen@networkplumber.org,\n\tjeffrey.b.shaw@intel.com, ferruh.yigit@intel.com", "Date": "Fri, 21 Dec 2018 10:18:08 -0800", "Message-Id": "<20181221181808.47816-1-jeffrey.b.shaw@intel.com>", "X-Mailer": "git-send-email 2.14.3", "In-Reply-To": "<20181221181159.47304-1-jeffrey.b.shaw@intel.com>", "References": "<20181221181159.47304-1-jeffrey.b.shaw@intel.com>", "Subject": "[dpdk-dev] [PATCH v3] eal: simplify RTE_PMD_DEBUG_TRACE", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\nUse rte_log directly, eliminating no longer used rte_pmd_dev_trace\nfunction. This removes variable length array which is problem on\nWindows and other compilers not doing C99.\n\nAlso, drop unused RTE_PROC_PRIMARY macros.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nSigned-off-by: Jeff Shaw <jeffrey.b.shaw@intel.com>\n---\n\nV3:\n - Fix checkpatch error:\n ERROR:SPACING: space required before the open parenthesis '('\n\nV2:\n - Changed named variable \"args...\" to use \"...\" with ##__VA_LIST__.\n Pasting is necessary to support case where only the format string,\n with no arguments, is passed.\n\n---\n lib/librte_eal/common/include/rte_dev.h | 44 +++------------------------------\n 1 file changed, 4 insertions(+), 40 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h\nindex a9724dc91..d7b3c1576 100644\n--- a/lib/librte_eal/common/include/rte_dev.h\n+++ b/lib/librte_eal/common/include/rte_dev.h\n@@ -43,54 +43,18 @@ typedef void (*rte_dev_event_cb_fn)(const char *device_name,\n \t\t\t\t\tenum rte_dev_event_type event,\n \t\t\t\t\tvoid *cb_arg);\n \n-__attribute__((format(printf, 2, 0)))\n-static inline void\n-rte_pmd_debug_trace(const char *func_name, const char *fmt, ...)\n-{\n-\tva_list ap;\n-\n-\tva_start(ap, fmt);\n-\n-\t{\n-\t\tchar buffer[vsnprintf(NULL, 0, fmt, ap) + 1];\n-\n-\t\tva_end(ap);\n-\n-\t\tva_start(ap, fmt);\n-\t\tvsnprintf(buffer, sizeof(buffer), fmt, ap);\n-\t\tva_end(ap);\n-\n-\t\trte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, \"%s: %s\",\n-\t\t\tfunc_name, buffer);\n-\t}\n-}\n-\n /*\n * Enable RTE_PMD_DEBUG_TRACE() when at least one component relying on the\n * RTE_*_RET() macros defined below is compiled in debug mode.\n */\n #if defined(RTE_LIBRTE_EVENTDEV_DEBUG)\n-#define RTE_PMD_DEBUG_TRACE(...) \\\n-\trte_pmd_debug_trace(__func__, __VA_ARGS__)\n+#define RTE_PMD_DEBUG_TRACE(fmt, ...)\t\t\t\t\t\\\n+\trte_log(RTE_LOG_ERR, RTE_LOGTYPE_PMD, \"%s: \" fmt, __func__,\t\\\n+\t\t##__VA_ARGS__)\n #else\n-#define RTE_PMD_DEBUG_TRACE(...) (void)0\n+#define RTE_PMD_DEBUG_TRACE(...) do { } while (0)\n #endif\n \n-/* Macros for checking for restricting functions to primary instance only */\n-#define RTE_PROC_PRIMARY_OR_ERR_RET(retval) do { \\\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) { \\\n-\t\tRTE_PMD_DEBUG_TRACE(\"Cannot run in secondary processes\\n\"); \\\n-\t\treturn retval; \\\n-\t} \\\n-} while (0)\n-\n-#define RTE_PROC_PRIMARY_OR_RET() do { \\\n-\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) { \\\n-\t\tRTE_PMD_DEBUG_TRACE(\"Cannot run in secondary processes\\n\"); \\\n-\t\treturn; \\\n-\t} \\\n-} while (0)\n-\n /* Macros to check for invalid function pointers */\n #define RTE_FUNC_PTR_OR_ERR_RET(func, retval) do { \\\n \tif ((func) == NULL) { \\\n", "prefixes": [ "v3" ] }