Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/492/?format=api
{ "id": 492, "url": "https://patches.dpdk.org/api/patches/492/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/A4A7819F3AE089479B8A88B97202C75D37BE86F9@ex10-mbx-9001.ant.amazon.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<A4A7819F3AE089479B8A88B97202C75D37BE86F9@ex10-mbx-9001.ant.amazon.com>", "list_archive_url": "https://inbox.dpdk.org/dev/A4A7819F3AE089479B8A88B97202C75D37BE86F9@ex10-mbx-9001.ant.amazon.com", "date": "2014-09-25T07:46:16", "name": "[dpdk-dev] Fix for LRU corrupted returns", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "a00c4e5f768a5bb719f3063f51dabb7966ae6d09", "submitter": { "id": 77, "url": "https://patches.dpdk.org/api/people/77/?format=api", "name": "Saha, Avik (AWS)", "email": "aviksaha@amazon.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/A4A7819F3AE089479B8A88B97202C75D37BE86F9@ex10-mbx-9001.ant.amazon.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/492/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/492/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 573C8B3B1;\n\tThu, 25 Sep 2014 09:40:15 +0200 (CEST)", "from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com\n\t[207.171.189.228]) by dpdk.org (Postfix) with ESMTP id 2720CB3AD\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 09:40:12 +0200 (CEST)", "from email-inbound-relay-62001.pdx2.amazon.com ([10.241.21.123])\n\tby smtp-border-fw-out-33001.sea14.amazon.com with\n\tESMTP/TLS/DHE-RSA-AES256-SHA; 25 Sep 2014 07:46:25 +0000", "from ex10-hub-9004.ant.amazon.com\n\t(pdx2-ws-svc-lb17-vlan2.amazon.com [10.247.140.66])\n\tby email-inbound-relay-62001.pdx2.amazon.com (8.14.7/8.14.7) with\n\tESMTP id s8P7kOPX001036\n\t(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=OK)\n\tfor <dev@dpdk.org>; Thu, 25 Sep 2014 07:46:24 GMT", "from EX10-MBX-9001.ant.amazon.com ([fe80::1023:3a45:4674:52c6]) by\n\tex10-hub-9004.ant.amazon.com ([::1]) with mapi id 14.03.0181.006;\n\tThu, 25 Sep 2014 00:46:17 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209;\n\tt=1411631190; x=1443167190;\n\th=from:to:subject:date:message-id:mime-version;\n\tbh=iVPVVzXsTWkCVe/6OPy4C/aM7tRCcuil170bnpUJlOE=;\n\tb=Anq67js8RaULZX2SvHsZcfLYCEEW8lmiPUYM5LbHH6isiIo/ObOvw8XR\n\tN1xXCiNdzU/e7/4XL2mm9Vjz4om8ZqZaMTDykiO1wS3oBwbDPKA11YBxR\n\tSi6cilS6ltgpfj4w65KT6xKoGEyJ0GpbqJovQrVPOQjg+cTfRPv3FGJ+q A=;", "X-IronPort-AV": "E=Sophos;i=\"5.04,595,1406592000\"; \n\td=\"scan'208,217\";a=\"106833076\"", "From": "\"Saha, Avik (AWS)\" <aviksaha@amazon.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[dpdk-dev] [PATCH] Fix for LRU corrupted returns", "Thread-Index": "Ac/Yk7ywkHZ3u5mETg2SYiggoS84qQ==", "Date": "Thu, 25 Sep 2014 07:46:16 +0000", "Message-ID": "<A4A7819F3AE089479B8A88B97202C75D37BE86F9@ex10-mbx-9001.ant.amazon.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.184.49.70]", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "[dpdk-dev] [PATCH] Fix for LRU corrupted returns", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is a patch to a problem that I have faced (described in the thread) and this works for me.\n\n1) Since the data_size_shl was getting its value from the key_size, the table data entries were being corrupted when the calculation to shift the number of bits was being made based on the key_size (according to the document the key_size and entry_size are independently configurable) - With this fix, we get the MSB that is set in entry_size (also removes the constraint of this having to be a power of 2 - not entirely sure if this was the reason the constraint was kept though)\n2) The document does not say that the entry_size needs to be a power of 2 and this was failing silently when I was trying to bring my application up.\n\n\n-----Original Message-----\nFrom: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Saha, Avik (AWS)\nSent: Wednesday, September 24, 2014 4:12 PM\nTo: dev@dpdk.org\nSubject: [dpdk-dev] Strange behaviour with LRU table\n\n1) All the calls to add entries succeeds\n\n2) The key look up works as expected.\n\n3) The value (entry_data) that is returned is incorrect for every other entry - 1st entry data on .f_action_hit is wrong, 2nd entry_data on .f_action_hit is correct and so on.\n\nI have initialized my LRU as follows:\n\n struct rte_pipeline_table_params table_params = {\n .ops = &rte_table_hash_lru_dosig_ops,\n .arg_create = &rule_tbl_params,\n .f_action_hit = rw_pipeline_stage_2_cache_hit,\n .f_action_miss = rw_pipeline_stage_2_cache_miss,\n .arg_ah = (void *)lcore_params,\n .action_data_size = 16,\n };\n\n\nIs there something obvious I am missing - from first look it seems to be a problem with cache lines but I really am not sure.\n\nAvik", "diff": "diff --git a/DPDK/lib/librte_table/rte_table_hash_lru.c b/DPDK/lib/librte_table/rte_table_hash_lru.c\nindex d1a4984..4ec9aa4 100644\n--- a/DPDK/lib/librte_table/rte_table_hash_lru.c\n+++ b/DPDK/lib/librte_table/rte_table_hash_lru.c\n@@ -153,8 +153,10 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)\n uint32_t i;\n\n /* Check input parameters */\n- if ((check_params_create(p) != 0) ||\n- (!rte_is_power_of_2(entry_size)) ||\n+ // Commenting out the power of 2 check on the entry_size since the\n+ // Programmers Guide does not call this out and we are going to handle\n+ // the data_size_shl of the table later on (Line 197)\n+ if ((check_params_create(p) != 0) ||\n ((sizeof(struct rte_table_hash) % CACHE_LINE_SIZE) != 0) ||\n (sizeof(struct bucket) != (CACHE_LINE_SIZE / 2))) {\n return NULL;\n@@ -192,7 +194,7 @@ rte_table_hash_lru_create(void *params, int socket_id, uint32_t entry_size)\n /* Internal */\n t->bucket_mask = t->n_buckets - 1;\n t->key_size_shl = __builtin_ctzl(p->key_size);\n- t->data_size_shl = __builtin_ctzl(p->key_size);\n+ t->data_size_shl = 32 - (__builtin_clz(entry_size));\n\n /* Tables */\n table_meta_offset = 0;\n", "prefixes": [ "dpdk-dev" ] }