Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49135/?format=api
{ "id": 49135, "url": "https://patches.dpdk.org/api/patches/49135/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/6e330a2642fca7b356e361d3b913a7a55d6e6697.1545236474.git.rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<6e330a2642fca7b356e361d3b913a7a55d6e6697.1545236474.git.rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/6e330a2642fca7b356e361d3b913a7a55d6e6697.1545236474.git.rahul.lakkireddy@chelsio.com", "date": "2018-12-19T16:28:26", "name": "[v2,4/4] net/cxgbe: fix other misc build issues for Windows", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1c8332205b6f0f69a76348c22680c13b86474da3", "submitter": { "id": 241, "url": "https://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/6e330a2642fca7b356e361d3b913a7a55d6e6697.1545236474.git.rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 2875, "url": "https://patches.dpdk.org/api/series/2875/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2875", "date": "2018-12-19T16:28:22", "name": "net/cxgbe: fix build for Microsoft Windows OS support", "version": 2, "mbox": "https://patches.dpdk.org/series/2875/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/49135/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/49135/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id EF1DA1B9B2;\n\tWed, 19 Dec 2018 17:30:33 +0100 (CET)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n\tby dpdk.org (Postfix) with ESMTP id 598D51B9B2\n\tfor <dev@dpdk.org>; Wed, 19 Dec 2018 17:30:32 +0100 (CET)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id wBJGUTTk024435; \n\tWed, 19 Dec 2018 08:30:30 -0800" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "satishr@chelsio.com, indranil@chelsio.com", "Date": "Wed, 19 Dec 2018 21:58:26 +0530", "Message-Id": "<6e330a2642fca7b356e361d3b913a7a55d6e6697.1545236474.git.rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "In-Reply-To": [ "<cover.1545236474.git.rahul.lakkireddy@chelsio.com>", "<cover.1545236474.git.rahul.lakkireddy@chelsio.com>" ], "References": [ "<cover.1545236474.git.rahul.lakkireddy@chelsio.com>", "<cover.1545236474.git.rahul.lakkireddy@chelsio.com>" ], "Subject": "[dpdk-dev] [PATCH v2 4/4] net/cxgbe: fix other misc build issues\n\tfor Windows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix following build errors reported by Intel C++ compiler in Windows\nbuild.\n\nC:\\> t4_hw.c(5105): warning #147: declaration is incompatible with\n\"int t4_bar2_sge_qregs(struct adapter *, unsigned int, unsigned int,\nu64={uint64_t={unsigned __int64}} *, unsigned int *)\"\n(declared at line 524 of \"..\\..\\..\\..\\drivers\\net\\cxgbe\\base\\common.h\")\n int t4_bar2_sge_qregs(struct adapter *adapter, unsigned int qid,\n ^\n\nC:\\> cxgbe_filter.c(42): error : expected an expression\n n_user_filters = mult_frac(adap->tids.nftids,\n ^\n\nC:\\> sge.c(400): error : expression must be a pointer to a complete\nobject type\n (uint16_t)(RTE_PTR_ALIGN((char *)mbuf->buf_addr +\n ^\n\nBuild Environment:\n1. Target OS: Microsoft Windows Server 2016\n2. Compiler: Intel C++ Compiler from Intel Parallel Studio XE 2019 [1]\n3. Development Tools:\n 3.1 Microsoft Visual Studio 2017 Professional\n 3.2 Windows Software Development Kit (SDK) v10.0.17763\n 3.3 Windows Driver Kit (WDK) v10.0.17763\n\n[1] https://software.intel.com/en-us/parallel-studio-xe\n\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\nv2:\n- Add more info in commit message regarding Windows build.\n\n drivers/net/cxgbe/base/common.h | 2 +-\n drivers/net/cxgbe/cxgbe_compat.h | 14 +++++++-------\n drivers/net/cxgbe/sge.c | 3 ++-\n 3 files changed, 10 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/base/common.h b/drivers/net/cxgbe/base/common.h\nindex 84311fc95..973d4d7dd 100644\n--- a/drivers/net/cxgbe/base/common.h\n+++ b/drivers/net/cxgbe/base/common.h\n@@ -522,7 +522,7 @@ void t4_read_rss_key(struct adapter *adap, u32 *key);\n \n enum t4_bar2_qtype { T4_BAR2_QTYPE_EGRESS, T4_BAR2_QTYPE_INGRESS };\n int t4_bar2_sge_qregs(struct adapter *adapter, unsigned int qid,\n-\t\t unsigned int qtype, u64 *pbar2_qoffset,\n+\t\t enum t4_bar2_qtype qtype, u64 *pbar2_qoffset,\n \t\t unsigned int *pbar2_qid);\n \n int t4_init_sge_params(struct adapter *adapter);\ndiff --git a/drivers/net/cxgbe/cxgbe_compat.h b/drivers/net/cxgbe/cxgbe_compat.h\nindex 686ca6e0a..edc8ea57d 100644\n--- a/drivers/net/cxgbe/cxgbe_compat.h\n+++ b/drivers/net/cxgbe/cxgbe_compat.h\n@@ -276,12 +276,12 @@ static inline void writel_relaxed(unsigned int val, volatile void __iomem *addr)\n * Multiplies an integer by a fraction, while avoiding unnecessary\n * overflow or loss of precision.\n */\n-#define mult_frac(x, numer, denom)( \\\n-{ \\\n-\ttypeof(x) quot = (x) / (denom); \\\n-\ttypeof(x) rem = (x) % (denom); \\\n-\t(quot * (numer)) + ((rem * (numer)) / (denom)); \\\n-} \\\n-)\n+static inline unsigned int mult_frac(unsigned int x, unsigned int numer,\n+\t\t\t\t unsigned int denom)\n+{\n+\tunsigned int quot = x / denom;\n+\tunsigned int rem = x % denom;\n \n+\treturn (quot * numer) + ((rem * numer) / denom);\n+}\n #endif /* _CXGBE_COMPAT_H_ */\ndiff --git a/drivers/net/cxgbe/sge.c b/drivers/net/cxgbe/sge.c\nindex bf0afb138..673c4fbb3 100644\n--- a/drivers/net/cxgbe/sge.c\n+++ b/drivers/net/cxgbe/sge.c\n@@ -397,7 +397,8 @@ static unsigned int refill_fl_usembufs(struct adapter *adap, struct sge_fl *q,\n \n \t\trte_mbuf_refcnt_set(mbuf, 1);\n \t\tmbuf->data_off =\n-\t\t\t(uint16_t)(RTE_PTR_ALIGN((char *)mbuf->buf_addr +\n+\t\t\t(uint16_t)((char *)\n+\t\t\t\t RTE_PTR_ALIGN((char *)mbuf->buf_addr +\n \t\t\t\t\t\t RTE_PKTMBUF_HEADROOM,\n \t\t\t\t\t\t adap->sge.fl_align) -\n \t\t\t\t (char *)mbuf->buf_addr);\n", "prefixes": [ "v2", "4/4" ] }