Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/49110/?format=api
https://patches.dpdk.org/api/patches/49110/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181219082113.24455-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181219082113.24455-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181219082113.24455-4-maxime.coquelin@redhat.com", "date": "2018-12-19T08:21:12", "name": "[v2,3/4] vhost: prefetch descriptor after the read barrier", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8293ca75265a1fc4cf0fa3f1941618742b7298c0", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181219082113.24455-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 2863, "url": "https://patches.dpdk.org/api/series/2863/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2863", "date": "2018-12-19T08:21:09", "name": "vhost: add missing barriers, move prefetching", "version": 2, "mbox": "https://patches.dpdk.org/series/2863/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/49110/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/49110/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3223A1BC7B;\n\tWed, 19 Dec 2018 09:21:35 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id DE73A1BC73;\n\tWed, 19 Dec 2018 09:21:33 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 3DD764E920;\n\tWed, 19 Dec 2018 08:21:33 +0000 (UTC)", "from localhost.localdomain (ovpn-112-26.ams2.redhat.com\n\t[10.36.112.26])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 42D0B67E68;\n\tWed, 19 Dec 2018 08:21:30 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, i.maximets@samsung.com, tiwei.bie@intel.com,\n\tzhihong.wang@intel.com, jasowang@redhat.com, mst@redhat.com", "Cc": "stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Wed, 19 Dec 2018 09:21:12 +0100", "Message-Id": "<20181219082113.24455-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181219082113.24455-1-maxime.coquelin@redhat.com>", "References": "<20181219082113.24455-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]); Wed, 19 Dec 2018 08:21:33 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v2 3/4] vhost: prefetch descriptor after the read\n\tbarrier", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch moves the prefetch after the available index\nis read to avoid prefetching a descriptor not available yet.\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/librte_vhost/virtio_net.c | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c\nindex a9b1bc55f..a9be633de 100644\n--- a/lib/librte_vhost/virtio_net.c\n+++ b/lib/librte_vhost/virtio_net.c\n@@ -755,7 +755,6 @@ virtio_dev_rx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \tstruct buf_vector buf_vec[BUF_VECTOR_MAX];\n \tuint16_t avail_head;\n \n-\trte_prefetch0(&vq->avail->ring[vq->last_avail_idx & (vq->size - 1)]);\n \tavail_head = *((volatile uint16_t *)&vq->avail->idx);\n \n \t/*\n@@ -764,6 +763,8 @@ virtio_dev_rx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t */\n \trte_smp_rmb();\n \n+\trte_prefetch0(&vq->avail->ring[vq->last_avail_idx & (vq->size - 1)]);\n+\n \tfor (pkt_idx = 0; pkt_idx < count; pkt_idx++) {\n \t\tuint32_t pkt_len = pkts[pkt_idx]->pkt_len + dev->vhost_hlen;\n \t\tuint16_t nr_vec = 0;\n@@ -1339,8 +1340,6 @@ virtio_dev_tx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t\t}\n \t}\n \n-\trte_prefetch0(&vq->avail->ring[vq->last_avail_idx & (vq->size - 1)]);\n-\n \tfree_entries = *((volatile uint16_t *)&vq->avail->idx) -\n \t\t\tvq->last_avail_idx;\n \tif (free_entries == 0)\n@@ -1352,6 +1351,8 @@ virtio_dev_tx_split(struct virtio_net *dev, struct vhost_virtqueue *vq,\n \t */\n \trte_smp_rmb();\n \n+\trte_prefetch0(&vq->avail->ring[vq->last_avail_idx & (vq->size - 1)]);\n+\n \tVHOST_LOG_DEBUG(VHOST_DATA, \"(%d) %s\\n\", dev->vid, __func__);\n \n \tcount = RTE_MIN(count, MAX_PKT_BURST);\n", "prefixes": [ "v2", "3/4" ] }{ "id": 49110, "url": "