Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48929/?format=api
{ "id": 48929, "url": "https://patches.dpdk.org/api/patches/48929/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181214193552.12408-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181214193552.12408-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20181214193552.12408-1-stephen@networkplumber.org", "date": "2018-12-14T19:35:52", "name": "net/failsafe: remove unnecessary debug messages", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "96566204e5798cdb5004b210154f77d26473ddb3", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181214193552.12408-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 2806, "url": "https://patches.dpdk.org/api/series/2806/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2806", "date": "2018-12-14T19:35:52", "name": "net/failsafe: remove unnecessary debug messages", "version": 1, "mbox": "https://patches.dpdk.org/series/2806/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/48929/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/48929/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9E6F61B9D1;\n\tFri, 14 Dec 2018 20:36:03 +0100 (CET)", "from mail-pf1-f195.google.com (mail-pf1-f195.google.com\n\t[209.85.210.195]) by dpdk.org (Postfix) with ESMTP id 45DE21B9C8\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 20:36:02 +0100 (CET)", "by mail-pf1-f195.google.com with SMTP id i12so3294738pfo.7\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 11:36:02 -0800 (PST)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\te86sm7629773pfb.6.2018.12.14.11.35.59\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tFri, 14 Dec 2018 11:36:00 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=5X4LtEChoOPz5hR0pFSzydjY9m5viVq+SmkUQNnUIFg=;\n\tb=g0OSUz1Bbh/oPq7zzXNThpT5vRGwfi35EocdGMjQZDws9bCBxZyxP+OhQKko9dMUQf\n\tPVYbJmtshMQLySKMwzG2tsC/w2/H5GSQRSCXcIC8jNiKqzq81+lrLyMVMzJ2lizjMI4f\n\tFMD6TybT/aCNSyK9nN6ERZfGQusmsfzDZVU3GG2wFxy4D9SWoCmcQgA5iY/MHk4tXUxl\n\tAr4/TXTgK605kAe1B+a/k8GJaiTkYZ+ZaHyz5Pw5Iqax4oPOsaSftouv98IKYbiv9E33\n\tUjJp5yHVo05gQK/eULa6dDQwrqzxuGy0nHFO6veoseY7hTZpP71Z6KxZ7xa9aJbr5yrd\n\t3x5w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=5X4LtEChoOPz5hR0pFSzydjY9m5viVq+SmkUQNnUIFg=;\n\tb=qCWWJ4ckWfnOSlX78Y6wOBb1iWsemdguZoB6EK5GZDssGfrA5xm+3/DjL7JrHZHx6u\n\tHLQa90RRXU1ZdvKhcsVYbmEztJwEfsAADZAToWTh26ntud6+nOysxPiKhFo75xhNvxGE\n\t2OlT9gLrXcHxgMVs7tC2AjJgKguvRD7WZM/6260pz3ykiw1c+fqfU81m5AxF6YDAHQVc\n\tnONip1JwrZ9u0oj0rPpeQoHxPFbiPuySGNLGjUqMQYr1z7mYvFG7/pkpX2hoxT/nVZO9\n\tg09ZkUU62Yd4nf1IdPLmy2GDzLIlksWJrb7GVlZb3JBPgUWvzloeiitjqjtsOHyXqXvg\n\tC7eQ==", "X-Gm-Message-State": "AA+aEWaAvHa//wAWcnKrJnMtN97yd93KlMIGVdkKxEpwlwSg5plwCJ3Z\n\tj72kWtcp1ByV3D2WVjiVPGV1jA==", "X-Google-Smtp-Source": "AFSGD/WIDF3/YAKw8Ia0r7fhknzLrnV/fNMsjyMX+vgFl62lyzr0YYEcyCcHGA9zFKVBV4kkNB4r5A==", "X-Received": "by 2002:a62:5d0c:: with SMTP id r12mr4194121pfb.0.1544816161274; \n\tFri, 14 Dec 2018 11:36:01 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "gaetan.rivet@6wind.com", "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Fri, 14 Dec 2018 11:35:52 -0800", "Message-Id": "<20181214193552.12408-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.19.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/failsafe: remove unnecessary debug messages", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The failsafe driver spews messages every time it is polling\nmaking debugging other things more difficult. Just remove it.\n\nExample:\nnet_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm\nnet_failsafe: Hot-plug mutex was locked by thread 140182066431744 by the hot-plug alarm\n...\n\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/failsafe/failsafe_private.h | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe_private.h b/drivers/net/failsafe/failsafe_private.h\nindex 7e3189685901..0dfea65c2a3c 100644\n--- a/drivers/net/failsafe/failsafe_private.h\n+++ b/drivers/net/failsafe/failsafe_private.h\n@@ -399,9 +399,6 @@ fs_lock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \t\t\treturn ret;\n \t\t}\n \t}\n-\tDEBUG(\"Hot-plug mutex was locked by thread %\" FS_THREADID_FMT \"%s\",\n-\t (FS_THREADID_TYPE)pthread_self(),\n-\t PRIV(dev)->alarm_lock ? \" by the hot-plug alarm\" : \"\");\n \treturn ret;\n }\n \n@@ -413,7 +410,6 @@ static inline void\n fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)\n {\n \tint ret;\n-\tunsigned int prev_alarm_lock = PRIV(dev)->alarm_lock;\n \n \tif (is_alarm) {\n \t\tRTE_ASSERT(PRIV(dev)->alarm_lock == 1);\n@@ -422,10 +418,6 @@ fs_unlock(struct rte_eth_dev *dev, unsigned int is_alarm)\n \tret = pthread_mutex_unlock(&PRIV(dev)->hotplug_mutex);\n \tif (ret)\n \t\tERROR(\"Cannot unlock hot-plug mutex(%s)\", strerror(ret));\n-\telse\n-\t\tDEBUG(\"Hot-plug mutex was unlocked by thread %\" FS_THREADID_FMT \"%s\",\n-\t\t (FS_THREADID_TYPE)pthread_self(),\n-\t\t prev_alarm_lock ? \" by the hot-plug alarm\" : \"\");\n }\n \n /*\n", "prefixes": [] }