Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48889/?format=api
{ "id": 48889, "url": "https://patches.dpdk.org/api/patches/48889/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181214155916.1142-1-jfreimann@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181214155916.1142-1-jfreimann@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181214155916.1142-1-jfreimann@redhat.com", "date": "2018-12-14T15:59:06", "name": "[v13,00/10] implement packed virtqueues", "commit_ref": null, "pull_url": null, "state": null, "archived": false, "hash": null, "submitter": { "id": 745, "url": "https://patches.dpdk.org/api/people/745/?format=api", "name": "Jens Freimann", "email": "jfreimann@redhat.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181214155916.1142-1-jfreimann@redhat.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/48889/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/48889/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4AA891B9B0;\n\tFri, 14 Dec 2018 16:59:25 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 95AA31B9B0\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 16:59:23 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id B2923307DADC;\n\tFri, 14 Dec 2018 15:59:22 +0000 (UTC)", "from localhost (ovpn-117-84.ams2.redhat.com [10.36.117.84])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 1500A600C5;\n\tFri, 14 Dec 2018 15:59:17 +0000 (UTC)" ], "From": "Jens Freimann <jfreimann@redhat.com>", "To": "dev@dpdk.org", "Cc": "tiwei.bie@intel.com,\n\tmaxime.coquelin@redhat.com,\n\tGavin.Hu@arm.com", "Date": "Fri, 14 Dec 2018 16:59:06 +0100", "Message-Id": "<20181214155916.1142-1-jfreimann@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.42]); Fri, 14 Dec 2018 15:59:22 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v13 00/10] implement packed virtqueues", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This is a basic implementation of packed virtqueues as specified in the\nVirtio 1.1 draft. A compiled version of the current draft is available\nat https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at\nhttps://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf\n\nA packed virtqueue is different from a split virtqueue in that it\nconsists of only a single descriptor ring that replaces available and\nused ring, index and descriptor pointers.\n\nEach descriptor is readable and writable and has a flags field. These flags\nwill mark if a descriptor is available or used. To detect new available descriptors\neven after the ring has wrapped, device and driver each have a\nsingle-bit wrap counter that is flipped from 0 to 1 and vice versa every time\nthe last descriptor in the ring is used/made available.\n\nWith this patch set I see performance equal or slightly better (+2-3%) in a PVP\nscenario compared to split virtqueues (v18.11 in host) \n\nregards,\nJens \n\nv12->v13:\n * re-order patches 1-3 to address Maximes comment. Move all defines and\n data structures to patch one, all helpers to patch 2. \n * build-tested and ran checkpatch on all patches again\n * add split/packed versions for virtio_enable_intr()\n * remove redundant changes from split vq code\n * just return -1 when cq is enabled for packed vqs in virtio-user \n\nv11->v12:\n * add a patch to disable control vq when packed vq is enabled.\n I have a patch to support this but it needs a bit more work\n and I think it shouldn't stop this series from being applied\n * rework mergeable receive buffer code to be more efficient, by\n batching descriptor refill, similar to what Maxime proposed for\n split virtqueues\n * removed unnecessary checks in virtio_recv_mergeable_pkts_packed\n (Maxime) \n * Did not merge receive functions as Maxime suggested because it seemed\n to cause a small performance regression\n * Move event_flags_shadow from patch 3 to 1 (Maxime)\n * Did not merge xmit functions and call _split/_packed functions from\n there because it seemed to cause small performance drop (-0.5%)\n (Maxime)\n\nv10-v11:\n * this version includes some fixes from Tiwei, so I added his\n Signed-off-by to some of the patches\n * fix hang with mergable rx buffers (Tiwei)\n * clean-up code and simplify buffer handling (Tiwei)\n * rebase to current virtio-next master branch\n\nv9-v10:\n * don't mix index into buffer list and descriptors\n * whitespace and formatting issues\n * remove \"VQ:\" in dump virtqueue patch\n * add extra packed vring struct to virtqueue and change function\n prototypes and code accordingly\n * move wrap_counters to virtqueue\n * make if-conditions for packed and !packed more clear in\n set_rxtx_funcs()\n * initialize wrap counters in first patch, instead of rx and tx\n implementation patch\n * make virtio-user not supported with packed virtqueues, to\n be fixed in other patch set?\n\nv8-v9:\n * fix virtio_ring_free_chain_packed() to handle descriptors\n correctly in case of out-of-order\n * fix check in virtqueue_xmit_cleanup_packed() to improve performance\n\nv7->v8:\n * move desc_is_used change to correct patch\n * remove trailing newline\n * correct xmit code, flags update and memory barrier\n * move packed desc init to dedicated function, split\n and packed variant\n\n\nJens Freimann (9):\n net/virtio: add packed virtqueue defines\n net/virtio: add packed virtqueue helpers\n net/virtio: vring init for packed queues\n net/virtio: dump packed virtqueue data\n net/virtio: implement transmit path for packed queues\n net/virtio: implement receive path for packed queues\n net/virtio: add virtio send command packed queue support\n net/virtio-user: fail if q used with packed vq\n net/virtio: enable packed virtqueues by default\n\nYuanhan Liu (1):\n net/virtio-user: add option to use packed queues\n\n drivers/net/virtio/virtio_ethdev.c | 221 +++++--\n drivers/net/virtio/virtio_ethdev.h | 8 +\n drivers/net/virtio/virtio_pci.h | 7 +\n drivers/net/virtio/virtio_ring.h | 64 +-\n drivers/net/virtio/virtio_rxtx.c | 611 +++++++++++++++++-\n .../net/virtio/virtio_user/virtio_user_dev.c | 27 +-\n .../net/virtio/virtio_user/virtio_user_dev.h | 2 +-\n drivers/net/virtio/virtio_user_ethdev.c | 14 +-\n drivers/net/virtio/virtqueue.c | 43 +-\n drivers/net/virtio/virtqueue.h | 128 +++-\n 10 files changed, 1059 insertions(+), 66 deletions(-)", "diff": null, "prefixes": [ "v13", "00/10" ] }