Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48855/?format=api
https://patches.dpdk.org/api/patches/48855/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1544789507-31067-1-git-send-email-tomaszx.jozwiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1544789507-31067-1-git-send-email-tomaszx.jozwiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1544789507-31067-1-git-send-email-tomaszx.jozwiak@intel.com", "date": "2018-12-14T12:11:47", "name": "compress/qat: fix error counter in dequeue errors", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cbbe910025dd925e16ca6725c8796d353dc4c04b", "submitter": { "id": 949, "url": "https://patches.dpdk.org/api/people/949/?format=api", "name": "Tomasz Jozwiak", "email": "tomaszx.jozwiak@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1544789507-31067-1-git-send-email-tomaszx.jozwiak@intel.com/mbox/", "series": [ { "id": 2780, "url": "https://patches.dpdk.org/api/series/2780/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2780", "date": "2018-12-14T12:11:47", "name": "compress/qat: fix error counter in dequeue errors", "version": 1, "mbox": "https://patches.dpdk.org/series/2780/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/48855/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/48855/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E7B8E1BA64;\n\tFri, 14 Dec 2018 13:15:50 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id 3DC191BA5D;\n\tFri, 14 Dec 2018 13:15:49 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Dec 2018 04:15:48 -0800", "from tjozwiax-mobl.ger.corp.intel.com (HELO\n\ttojo-Virtual-Machine.mshome.net) ([10.103.104.47])\n\tby fmsmga001.fm.intel.com with ESMTP; 14 Dec 2018 04:15:46 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,352,1539673200\"; d=\"scan'208\";a=\"129934413\"", "From": "Tomasz Jozwiak <tomaszx.jozwiak@intel.com>", "To": "dev@dpdk.org, fiona.trahe@intel.com, tomaszx.jozwiak@intel.com,\n\takhil.goyal@nxp.com, stable@dpdk.org", "Date": "Fri, 14 Dec 2018 13:11:47 +0100", "Message-Id": "<1544789507-31067-1-git-send-email-tomaszx.jozwiak@intel.com>", "X-Mailer": "git-send-email 2.7.4", "Subject": "[dpdk-dev] [PATCH] compress/qat: fix error counter in dequeue errors", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch increments error counter (stats.dequeue_err_count)\nin case of any error detection during qat_comp_process_response\nfunction.\n\nFixes: 3cc14fc48e35 (\"compress/qat: check that correct firmware is in use\")\nFixes: 32842f2a6d7d (\"compress/qat: create FW request and process response\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\n---\n drivers/common/qat/qat_qp.c | 6 ++++--\n drivers/common/qat/qat_qp.h | 3 ++-\n drivers/compress/qat/qat_comp.c | 4 +++-\n drivers/compress/qat/qat_comp.h | 4 ++--\n 4 files changed, 11 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c\nindex 79f6a01..f0386ac 100644\n--- a/drivers/common/qat/qat_qp.c\n+++ b/drivers/common/qat/qat_qp.c\n@@ -654,7 +654,8 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)\n \t\tif (tmp_qp->service_type == QAT_SERVICE_SYMMETRIC)\n \t\t\tqat_sym_process_response(ops, resp_msg);\n \t\telse if (tmp_qp->service_type == QAT_SERVICE_COMPRESSION)\n-\t\t\tqat_comp_process_response(ops, resp_msg);\n+\t\t\tqat_comp_process_response(ops, resp_msg,\n+\t\t\t\t\t&tmp_qp->stats.dequeue_err_count);\n \n \t\thead = adf_modulo(head + rx_queue->msg_size,\n \t\t\t\t rx_queue->modulo_mask);\n@@ -682,7 +683,8 @@ qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)\n }\n \n __rte_weak int\n-qat_comp_process_response(void **op __rte_unused, uint8_t *resp __rte_unused)\n+qat_comp_process_response(void **op __rte_unused, uint8_t *resp __rte_unused,\n+\t\t\t uint64_t *dequeue_err_count __rte_unused)\n {\n \treturn 0;\n }\ndiff --git a/drivers/common/qat/qat_qp.h b/drivers/common/qat/qat_qp.h\nindex 6f1525e..9833bcb 100644\n--- a/drivers/common/qat/qat_qp.h\n+++ b/drivers/common/qat/qat_qp.h\n@@ -107,6 +107,7 @@ qat_qps_per_service(const struct qat_qp_hw_data *qp_hw_data,\n \n /* Needed for weak function*/\n int\n-qat_comp_process_response(void **op __rte_unused, uint8_t *resp __rte_unused);\n+qat_comp_process_response(void **op __rte_unused, uint8_t *resp __rte_unused,\n+\t\t\t uint64_t *dequeue_err_count);\n \n #endif /* _QAT_QP_H_ */\ndiff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c\nindex 2754742..342d2f7 100644\n--- a/drivers/compress/qat/qat_comp.c\n+++ b/drivers/compress/qat/qat_comp.c\n@@ -106,7 +106,7 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,\n }\n \n int\n-qat_comp_process_response(void **op, uint8_t *resp)\n+qat_comp_process_response(void **op, uint8_t *resp, uint64_t *dequeue_err_count)\n {\n \tstruct icp_qat_fw_comp_resp *resp_msg =\n \t\t\t(struct icp_qat_fw_comp_resp *)resp;\n@@ -132,6 +132,7 @@ qat_comp_process_response(void **op, uint8_t *resp)\n \t\t\trx_op->debug_status = ERR_CODE_QAT_COMP_WRONG_FW;\n \t\t\t*op = (void *)rx_op;\n \t\t\tQAT_DP_LOG(ERR, \"QAT has wrong firmware\");\n+\t\t\t++(*dequeue_err_count);\n \t\t\treturn 0;\n \t\t}\n \t}\n@@ -149,6 +150,7 @@ qat_comp_process_response(void **op, uint8_t *resp)\n \t\t\tQAT_DP_LOG(ERR, \"QAT intermediate buffer may be too \"\n \t\t\t \"small for output, try configuring a larger size\");\n \n+\t\t++(*dequeue_err_count);\n \t\trx_op->status = RTE_COMP_OP_STATUS_ERROR;\n \t\trx_op->debug_status =\n \t\t\t*((uint16_t *)(&resp_msg->comn_resp.comn_error));\ndiff --git a/drivers/compress/qat/qat_comp.h b/drivers/compress/qat/qat_comp.h\nindex 99a4462..19f48df 100644\n--- a/drivers/compress/qat/qat_comp.h\n+++ b/drivers/compress/qat/qat_comp.h\n@@ -60,8 +60,8 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg, void *op_cookie,\n \t\t enum qat_device_gen qat_dev_gen __rte_unused);\n \n int\n-qat_comp_process_response(void **op, uint8_t *resp);\n-\n+qat_comp_process_response(void **op, uint8_t *resp,\n+\t\t\t uint64_t *dequeue_err_count);\n \n int\n qat_comp_private_xform_create(struct rte_compressdev *dev,\n", "prefixes": [] }{ "id": 48855, "url": "