Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48843/?format=api
https://patches.dpdk.org/api/patches/48843/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1544786371-29799-2-git-send-email-tomaszx.jozwiak@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1544786371-29799-2-git-send-email-tomaszx.jozwiak@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1544786371-29799-2-git-send-email-tomaszx.jozwiak@intel.com", "date": "2018-12-14T11:19:31", "name": "compress/qat: fix status return on error building request", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6979e0d31282f8b316fa1e747f64991a157765b3", "submitter": { "id": 949, "url": "https://patches.dpdk.org/api/people/949/?format=api", "name": "Tomasz Jozwiak", "email": "tomaszx.jozwiak@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1544786371-29799-2-git-send-email-tomaszx.jozwiak@intel.com/mbox/", "series": [ { "id": 2776, "url": "https://patches.dpdk.org/api/series/2776/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2776", "date": "2018-12-14T11:19:31", "name": "compress/qat: fix status return on error building request", "version": 1, "mbox": "https://patches.dpdk.org/series/2776/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/48843/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/48843/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6440B1B96B;\n\tFri, 14 Dec 2018 12:23:36 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 7E9151B92D;\n\tFri, 14 Dec 2018 12:23:34 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t14 Dec 2018 03:23:34 -0800", "from tjozwiax-mobl.ger.corp.intel.com (HELO\n\ttojo-Virtual-Machine.mshome.net) ([10.103.104.47])\n\tby fmsmga001.fm.intel.com with ESMTP; 14 Dec 2018 03:23:32 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,352,1539673200\"; d=\"scan'208\";a=\"129926214\"", "From": "Tomasz Jozwiak <tomaszx.jozwiak@intel.com>", "To": "dev@dpdk.org, fiona.trahe@intel.com, tomaszx.jozwiak@intel.com,\n\takhil.goyal@nxp.com, stable@dpdk.org", "Date": "Fri, 14 Dec 2018 12:19:31 +0100", "Message-Id": "<1544786371-29799-2-git-send-email-tomaszx.jozwiak@intel.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1544786371-29799-1-git-send-email-tomaszx.jozwiak@intel.com>", "References": "<1544786371-29799-1-git-send-email-tomaszx.jozwiak@intel.com>", "Subject": "[dpdk-dev] [PATCH] compress/qat: fix status return on error\n\tbuilding request", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patch fixes error status which should be set inside\nqat_comp_build_request function in case any errors are detected.\nIn these cases op.status is set to\nRTE_COMP_OP_STATUS_INVALID_ARGS to help application debug.\n\nFixes: 1947bd18580b (\"compress/qat: support scatter-gather buffers\")\nCc: stable@dpdk.org\n\nSigned-off-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>\n---\n drivers/compress/qat/qat_comp.c | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c\nindex 2754742..8a6fad0 100644\n--- a/drivers/compress/qat/qat_comp.c\n+++ b/drivers/compress/qat/qat_comp.c\n@@ -36,6 +36,7 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,\n \t\tQAT_DP_LOG(ERR, \"QAT PMD only supports stateless compression \"\n \t\t\t\t\"operation requests, op (%p) is not a \"\n \t\t\t\t\"stateless operation.\", op);\n+\t\top->status = RTE_COMP_OP_STATUS_INVALID_ARGS;\n \t\treturn -EINVAL;\n \t}\n \n@@ -61,6 +62,7 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,\n \t\t\t\tRTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS);\n \t\tif (ret) {\n \t\t\tQAT_DP_LOG(ERR, \"QAT PMD Cannot fill source sgl array\");\n+\t\t\top->status = RTE_COMP_OP_STATUS_INVALID_ARGS;\n \t\t\treturn ret;\n \t\t}\n \n@@ -71,6 +73,7 @@ qat_comp_build_request(void *in_op, uint8_t *out_msg,\n \t\t\t\tRTE_PMD_QAT_COMP_SGL_MAX_SEGMENTS);\n \t\tif (ret) {\n \t\t\tQAT_DP_LOG(ERR, \"QAT PMD Cannot fill dest. sgl array\");\n+\t\t\top->status = RTE_COMP_OP_STATUS_INVALID_ARGS;\n \t\t\treturn ret;\n \t\t}\n \n", "prefixes": [] }{ "id": 48843, "url": "