Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48795/?format=api
{ "id": 48795, "url": "https://patches.dpdk.org/api/patches/48795/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181214012621.15213-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181214012621.15213-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20181214012621.15213-2-stephen@networkplumber.org", "date": "2018-12-14T01:26:19", "name": "[1/3] net/netvsc: support receive without vlan strip", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8490ab142f0dd787ab2fa924c98f1ec519671fbc", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181214012621.15213-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 2769, "url": "https://patches.dpdk.org/api/series/2769/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2769", "date": "2018-12-14T01:26:18", "name": "net/netvsc: misc fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/2769/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/48795/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/48795/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3D0091B5F4;\n\tFri, 14 Dec 2018 02:26:28 +0100 (CET)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id C42C41B5EF\n\tfor <dev@dpdk.org>; Fri, 14 Dec 2018 02:26:26 +0100 (CET)", "by mail-pg1-f194.google.com with SMTP id z10so1889952pgp.7\n\tfor <dev@dpdk.org>; Thu, 13 Dec 2018 17:26:26 -0800 (PST)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ti21sm3379085pgm.17.2018.12.13.17.26.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 13 Dec 2018 17:26:24 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dbuCE0Kt+GIqtvQH+YGxpAhxNVD8MDmPhvpZIQ6xXcc=;\n\tb=wAp1Tn/1pOFVC1vhpigWuVphtNGndOdDKr6lMav6JprjkZPYS+C8nW/X7tcbZY2O/v\n\tkwa2an2AurFOmEbURoRSodWBp0xCiPl3UcSJGKq1dCJPCNLh6vNT3m4/OSG8EWh35oL3\n\tWjxJLJt3uvRjHDiQPbHbzNz/W5XPD7nhGeqa3zHgbkaxgNFMG22bbhVCL3ccchmX+Gx9\n\tJwA3glu+CuFDLMRtOU4+Ex2wuYB4xQxIBdEAFYQqTgTGFImzKiGt7LiSoIr9Sh4a2ed/\n\tqMM4AcVqR+IRnwUk9TSdGzpEnZimV1o8WAE694nOfwwGpKmmO0tJ+ImtMhI8Eg3IDoal\n\tfwdg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dbuCE0Kt+GIqtvQH+YGxpAhxNVD8MDmPhvpZIQ6xXcc=;\n\tb=MPdixC5X9cF4hPV37SaraRDAJJ1p9jOrLdjipTt6mc2HJvH769hCSTH3S6LcCWnIz1\n\tWuMgQUiXvbxEEuXVpaA0HQUiSlN15+UQZ53cMZhuoh2skgSnP4e1bSEZRtzt1Ol3dTRk\n\tj5dbH/wSXnuyeqGAZ6MASFByJYrqlsoR5G6xvfeLv/72POYzd0JyecVzuTfFZRiXvg1f\n\t1S619D6/zvpazhg5m9FMlpOvixKXeJhIg1lWFUmnOfUsmQh5NS4ENypBHF4tK28dTXTK\n\t2uFofwhDrM0cfnN/hPrEvgCaoL+uyRdCoAoXBJRlyw7HbFqDWMjm3Pa7MMPct3HGGOD7\n\tW72g==", "X-Gm-Message-State": "AA+aEWb/sNs4jvTBQQR4zcG9CL56K+pwUeuMskkBwK+17lc3nfERgS7K\n\tAxPKaFSH6N3KDgNFOry9zubiNHSJjaM=", "X-Google-Smtp-Source": "AFSGD/VpTL4PtBsR66QiirYYlVZFmah1bRarZTpVdYalXyBP30f46EO6lAx6Npx3gsbpKCTrlKix8Q==", "X-Received": "by 2002:a63:e348:: with SMTP id o8mr965004pgj.158.1544750785565; \n\tThu, 13 Dec 2018 17:26:25 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Thu, 13 Dec 2018 17:26:19 -0800", "Message-Id": "<20181214012621.15213-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.19.2", "In-Reply-To": "<20181214012621.15213-1-stephen@networkplumber.org>", "References": "<20181214012621.15213-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] net/netvsc: support receive without vlan\n\tstrip", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In some cases, VLAN stripping is not desireable. If necessary\nre-insert stripped vlan tag.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/netvsc/hn_ethdev.c | 2 ++\n drivers/net/netvsc/hn_rxtx.c | 8 ++++++++\n drivers/net/netvsc/hn_var.h | 5 +++--\n 3 files changed, 13 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c\nindex b330bf3d7255..d7ac0c7320b0 100644\n--- a/drivers/net/netvsc/hn_ethdev.c\n+++ b/drivers/net/netvsc/hn_ethdev.c\n@@ -378,6 +378,8 @@ static int hn_dev_configure(struct rte_eth_dev *dev)\n \t\treturn -EINVAL;\n \t}\n \n+\thv->vlan_strip = !!(rxmode->offloads & DEV_RX_OFFLOAD_VLAN_STRIP);\n+\n \terr = hn_rndis_conf_offload(hv, txmode->offloads,\n \t\t\t\t rxmode->offloads);\n \tif (err) {\ndiff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c\nindex f4a36641b6c3..622a83983e10 100644\n--- a/drivers/net/netvsc/hn_rxtx.c\n+++ b/drivers/net/netvsc/hn_rxtx.c\n@@ -501,6 +501,14 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb,\n \tif (info->vlan_info != HN_NDIS_VLAN_INFO_INVALID) {\n \t\tm->vlan_tci = info->vlan_info;\n \t\tm->ol_flags |= PKT_RX_VLAN_STRIPPED | PKT_RX_VLAN;\n+\n+\t\t/* NDIS always strips tag, put it back if necessary */\n+\t\tif (!hv->vlan_strip && rte_vlan_insert(&m)) {\n+\t\t\tPMD_DRV_LOG(DEBUG, \"vlan insert failed\");\n+\t\t\t++rxq->stats.errors;\n+\t\t\trte_pktmbuf_free(m);\n+\t\t\treturn;\n+\t\t}\n \t}\n \n \tif (info->csum_info != HN_NDIS_RXCSUM_INFO_INVALID) {\ndiff --git a/drivers/net/netvsc/hn_var.h b/drivers/net/netvsc/hn_var.h\nindex e1072c7cfa55..cd173f6af942 100644\n--- a/drivers/net/netvsc/hn_var.h\n+++ b/drivers/net/netvsc/hn_var.h\n@@ -97,8 +97,9 @@ struct hn_data {\n \tstruct rte_eth_dev *vf_dev;\t\t/* Subordinate device */\n \trte_spinlock_t vf_lock;\n \tuint16_t\tport_id;\n-\tbool\t\tclosed;\n-\tbool\t\tvf_present;\n+\tuint8_t\t\tclosed;\n+\tuint8_t\t\tvf_present;\n+\tuint8_t\t\tvlan_strip;\n \tuint32_t\tlink_status;\n \tuint32_t\tlink_speed;\n \n", "prefixes": [ "1/3" ] }