Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48783/?format=api
https://patches.dpdk.org/api/patches/48783/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com", "date": "2018-12-13T15:02:11", "name": "[2/4] net/cxgbe: fix macros related to logs for Windows", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0dc7fa699a464900bcf95a9fc7b1b9c0671bf9d2", "submitter": { "id": 241, "url": "https://patches.dpdk.org/api/people/241/?format=api", "name": "Rahul Lakkireddy", "email": "rahul.lakkireddy@chelsio.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com/mbox/", "series": [ { "id": 2763, "url": "https://patches.dpdk.org/api/series/2763/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2763", "date": "2018-12-13T15:02:09", "name": "net/cxgbe: fix build for Microsoft Windows OS support", "version": 1, "mbox": "https://patches.dpdk.org/series/2763/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/48783/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/48783/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E9CCB1B569;\n\tThu, 13 Dec 2018 16:04:05 +0100 (CET)", "from stargate.chelsio.com (stargate.chelsio.com [12.32.117.8])\n\tby dpdk.org (Postfix) with ESMTP id 870FD1B565\n\tfor <dev@dpdk.org>; Thu, 13 Dec 2018 16:04:04 +0100 (CET)", "from localhost (scalar.blr.asicdesigners.com [10.193.185.94])\n\tby stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id wBDF40Ru007181; \n\tThu, 13 Dec 2018 07:04:01 -0800" ], "From": "Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>", "To": "dev@dpdk.org", "Cc": "satishr@chelsio.com, indranil@chelsio.com", "Date": "Thu, 13 Dec 2018 20:32:11 +0530", "Message-Id": "<1544713333-32239-3-git-send-email-rahul.lakkireddy@chelsio.com>", "X-Mailer": "git-send-email 2.5.3", "In-Reply-To": "<1544713333-32239-1-git-send-email-rahul.lakkireddy@chelsio.com>", "References": "<1544713333-32239-1-git-send-email-rahul.lakkireddy@chelsio.com>", "Subject": "[dpdk-dev] [PATCH 2/4] net/cxgbe: fix macros related to logs for\n\tWindows", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Replace \"args...\" with \"fmt, ...\" and directly use __VA_ARGS__.\n\nSigned-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>\n---\n drivers/net/cxgbe/cxgbe_compat.h | 40 ++++++++++++++++++--------------\n 1 file changed, 22 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/cxgbe/cxgbe_compat.h b/drivers/net/cxgbe/cxgbe_compat.h\nindex 5d47c5f3d..ce4662d54 100644\n--- a/drivers/net/cxgbe/cxgbe_compat.h\n+++ b/drivers/net/cxgbe/cxgbe_compat.h\n@@ -19,41 +19,45 @@\n #include <rte_log.h>\n #include <rte_io.h>\n \n-#define dev_printf(level, fmt, args...) \\\n-\tRTE_LOG(level, PMD, \"rte_cxgbe_pmd: \" fmt, ## args)\n+#define dev_printf(level, fmt, ...) \\\n+\tRTE_LOG(level, PMD, \"rte_cxgbe_pmd: \" fmt, ##__VA_ARGS__)\n \n-#define dev_err(x, args...) dev_printf(ERR, args)\n-#define dev_info(x, args...) dev_printf(INFO, args)\n-#define dev_warn(x, args...) dev_printf(WARNING, args)\n+#define dev_err(x, fmt, ...) dev_printf(ERR, fmt, ##__VA_ARGS__)\n+#define dev_info(x, fmt, ...) dev_printf(INFO, fmt, ##__VA_ARGS__)\n+#define dev_warn(x, fmt, ...) dev_printf(WARNING, fmt, ##__VA_ARGS__)\n \n #ifdef RTE_LIBRTE_CXGBE_DEBUG\n-#define dev_debug(x, args...) dev_printf(DEBUG, args)\n+#define dev_debug(x, fmt, ...) dev_printf(INFO, fmt, ##__VA_ARGS__)\n #else\n-#define dev_debug(x, args...) do { } while (0)\n+#define dev_debug(x, fmt, ...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_CXGBE_DEBUG_REG\n-#define CXGBE_DEBUG_REG(x, args...) dev_printf(DEBUG, \"REG:\" args)\n+#define CXGBE_DEBUG_REG(x, fmt, ...) \\\n+\tdev_printf(INFO, \"REG:\" fmt, ##__VA_ARGS__)\n #else\n-#define CXGBE_DEBUG_REG(x, args...) do { } while (0)\n+#define CXGBE_DEBUG_REG(x, fmt, ...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_CXGBE_DEBUG_MBOX\n-#define CXGBE_DEBUG_MBOX(x, args...) dev_printf(DEBUG, \"MBOX:\" args)\n+#define CXGBE_DEBUG_MBOX(x, fmt, ...) \\\n+\tdev_printf(INFO, \"MBOX:\" fmt, ##__VA_ARGS__)\n #else\n-#define CXGBE_DEBUG_MBOX(x, args...) do { } while (0)\n+#define CXGBE_DEBUG_MBOX(x, fmt, ...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_CXGBE_DEBUG_TX\n-#define CXGBE_DEBUG_TX(x, args...) dev_printf(DEBUG, \"TX:\" args)\n+#define CXGBE_DEBUG_TX(x, fmt, ...) \\\n+\tdev_printf(INFO, \"TX:\" fmt, ##__VA_ARGS__)\n #else\n-#define CXGBE_DEBUG_TX(x, args...) do { } while (0)\n+#define CXGBE_DEBUG_TX(x, fmt, ...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_CXGBE_DEBUG_RX\n-#define CXGBE_DEBUG_RX(x, args...) dev_printf(DEBUG, \"RX:\" args)\n+#define CXGBE_DEBUG_RX(x, fmt, ...) \\\n+\tdev_printf(INFO, \"RX:\" fmt, ##__VA_ARGS__)\n #else\n-#define CXGBE_DEBUG_RX(x, args...) do { } while (0)\n+#define CXGBE_DEBUG_RX(x, fmt, ...) do { } while (0)\n #endif\n \n #ifdef RTE_LIBRTE_CXGBE_DEBUG\n@@ -63,9 +67,9 @@\n #define CXGBE_FUNC_TRACE() do { } while (0)\n #endif\n \n-#define pr_err(y, args...) dev_err(0, y, ##args)\n-#define pr_warn(y, args...) dev_warn(0, y, ##args)\n-#define pr_info(y, args...) dev_info(0, y, ##args)\n+#define pr_err(fmt, ...) dev_err(0, fmt, ##__VA_ARGS__)\n+#define pr_warn(fmt, ...) dev_warn(0, fmt, ##__VA_ARGS__)\n+#define pr_info(fmt, ...) dev_info(0, fmt, ##__VA_ARGS__)\n #define BUG() pr_err(\"BUG at %s:%d\", __func__, __LINE__)\n \n #define ASSERT(x) do {\\\n", "prefixes": [ "2/4" ] }{ "id": 48783, "url": "