Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48778/?format=api
{ "id": 48778, "url": "https://patches.dpdk.org/api/patches/48778/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181213123453.15035-10-jfreimann@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181213123453.15035-10-jfreimann@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181213123453.15035-10-jfreimann@redhat.com", "date": "2018-12-13T12:34:52", "name": "[v12,09/10] net/virtio-user: ctrl virtqueue not supported with packed vqs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3fb5de49386866426ff9da024e8761aa3f51e28f", "submitter": { "id": 745, "url": "https://patches.dpdk.org/api/people/745/?format=api", "name": "Jens Freimann", "email": "jfreimann@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181213123453.15035-10-jfreimann@redhat.com/mbox/", "series": [ { "id": 2761, "url": "https://patches.dpdk.org/api/series/2761/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2761", "date": "2018-12-13T12:34:43", "name": "implement packed virtqueues", "version": 12, "mbox": "https://patches.dpdk.org/series/2761/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/48778/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/48778/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B42D01B55A;\n\tThu, 13 Dec 2018 13:36:28 +0100 (CET)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id A885A1B54B\n\tfor <dev@dpdk.org>; Thu, 13 Dec 2018 13:36:27 +0100 (CET)", "from smtp.corp.redhat.com\n\t(int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 11B03C0669A3;\n\tThu, 13 Dec 2018 12:36:27 +0000 (UTC)", "from localhost (unknown [10.36.118.169])\n\tby smtp.corp.redhat.com (Postfix) with ESMTPS id 105C3614E6;\n\tThu, 13 Dec 2018 12:36:16 +0000 (UTC)" ], "From": "Jens Freimann <jfreimann@redhat.com>", "To": "dev@dpdk.org", "Cc": "tiwei.bie@intel.com,\n\tmaxime.coquelin@redhat.com,\n\tGavin.Hu@arm.com", "Date": "Thu, 13 Dec 2018 13:34:52 +0100", "Message-Id": "<20181213123453.15035-10-jfreimann@redhat.com>", "In-Reply-To": "<20181213123453.15035-1-jfreimann@redhat.com>", "References": "<20181213123453.15035-1-jfreimann@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.13", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.32]); Thu, 13 Dec 2018 12:36:27 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v12 09/10] net/virtio-user: ctrl virtqueue not\n\tsupported with packed vqs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Until we have support for ctrl virtqueues let's disable it and\nexit if specified as a parameter.\n\nSigned-off-by: Jens Freimann <jfreimann@redhat.com>\n---\n drivers/net/virtio/virtio_user/virtio_user_dev.c | 8 ++++++--\n 1 file changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c\nindex 697ba4ae8..f9b83c423 100644\n--- a/drivers/net/virtio/virtio_user/virtio_user_dev.c\n+++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c\n@@ -467,10 +467,14 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues,\n \tif (!in_order)\n \t\tdev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER);\n \n-\tif (packed_vq)\n+\tif (packed_vq) {\n+\t\tif (cq)\n+\t\t\trte_exit(EXIT_FAILURE,\n+\t\t\t\t\"control vq not supported with packed virtqueues\\n\");\n \t\tdev->device_features |= (1ull << VIRTIO_F_RING_PACKED);\n-\telse\n+\t} else {\n \t\tdev->device_features &= ~(1ull << VIRTIO_F_RING_PACKED);\n+\t}\n \n \tif (dev->mac_specified) {\n \t\tdev->device_features |= (1ull << VIRTIO_NET_F_MAC);\n", "prefixes": [ "v12", "09/10" ] }