Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/48741/?format=api
{ "id": 48741, "url": "https://patches.dpdk.org/api/patches/48741/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181213124928.25154-1-zhirun.yan@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181213124928.25154-1-zhirun.yan@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181213124928.25154-1-zhirun.yan@intel.com", "date": "2018-12-13T12:49:28", "name": "[v2] net/i40e: remove redundant code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "cccf8d39fb21337eb0d0048cc9c1cf1ab74eee52", "submitter": { "id": 1154, "url": "https://patches.dpdk.org/api/people/1154/?format=api", "name": "Yan, Zhirun", "email": "zhirun.yan@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181213124928.25154-1-zhirun.yan@intel.com/mbox/", "series": [ { "id": 2751, "url": "https://patches.dpdk.org/api/series/2751/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2751", "date": "2018-12-13T12:49:28", "name": "[v2] net/i40e: remove redundant code", "version": 2, "mbox": "https://patches.dpdk.org/series/2751/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/48741/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/48741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id A52E11B484;\n\tThu, 13 Dec 2018 06:12:09 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id BB5D21B476\n\tfor <dev@dpdk.org>; Thu, 13 Dec 2018 06:12:07 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Dec 2018 21:12:07 -0800", "from dpdk-server.sh.intel.com ([10.67.110.170])\n\tby orsmga001.jf.intel.com with ESMTP; 12 Dec 2018 21:12:05 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.56,347,1539673200\"; d=\"scan'208\";a=\"118397796\"", "From": "Zhirun Yan <zhirun.yan@intel.com>", "To": "dev@dpdk.org,\n\tqi.z.zhang@intel.com", "Cc": "Zhirun Yan <zhirun.yan@intel.com>,\n\tHaiyue Wang <haiyue.wang@intel.com>", "Date": "Thu, 13 Dec 2018 12:49:28 +0000", "Message-Id": "<20181213124928.25154-1-zhirun.yan@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20181210133205.70401-1-zhirun.yan@intel.com>", "References": "<20181210133205.70401-1-zhirun.yan@intel.com>", "Subject": "[dpdk-dev] [PATCH v2] net/i40e: remove redundant code", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Before this patch, there are two functions will call\ni40e_dev_free_queues to free queues. For rte_eth_dev_close(), its\nredundant because of duplication. For rte_eth_dev_reset() its\nredundant because of not necessary, since following dev_configure\nis required after dev_reset and it will be updated correctly.\n\nThis patch removes redundant code in i40e_dev_free_queues().\n\nFixes: 6b4537128394 (\"i40e: free queue memory when closing\")\n\nSigned-off-by: Zhirun Yan <zhirun.yan@intel.com>\nSigned-off-by: Haiyue Wang <haiyue.wang@intel.com>\n---\n drivers/net/i40e/i40e_rxtx.c | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex e1152ff0e..cc953ad58 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -2753,7 +2753,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)\n \t\ti40e_dev_rx_queue_release(dev->data->rx_queues[i]);\n \t\tdev->data->rx_queues[i] = NULL;\n \t}\n-\tdev->data->nb_rx_queues = 0;\n \n \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n \t\tif (!dev->data->tx_queues[i])\n@@ -2761,7 +2760,6 @@ i40e_dev_free_queues(struct rte_eth_dev *dev)\n \t\ti40e_dev_tx_queue_release(dev->data->tx_queues[i]);\n \t\tdev->data->tx_queues[i] = NULL;\n \t}\n-\tdev->data->nb_tx_queues = 0;\n }\n \n #define I40E_FDIR_NUM_TX_DESC I40E_MIN_RING_DESC\n", "prefixes": [ "v2" ] }