Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 47905,
    "url": "https://patches.dpdk.org/api/patches/47905/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181106193005.5383-5-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181106193005.5383-5-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181106193005.5383-5-stephen@networkplumber.org",
    "date": "2018-11-06T19:30:05",
    "name": "[4/4] net/tap: fix warning about comparison of fd",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "9a9f0d738bafa08464254b001441b38e8118328f",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181106193005.5383-5-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 2301,
            "url": "https://patches.dpdk.org/api/series/2301/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2301",
            "date": "2018-11-06T19:30:01",
            "name": "Coverity issue fixes",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/2301/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/47905/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/47905/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 3F84F4CE4;\n\tTue,  6 Nov 2018 20:30:17 +0100 (CET)",
            "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 695FA3238\n\tfor <dev@dpdk.org>; Tue,  6 Nov 2018 20:30:12 +0100 (CET)",
            "by mail-pg1-f196.google.com with SMTP id 32-v6so6259758pgu.2\n\tfor <dev@dpdk.org>; Tue, 06 Nov 2018 11:30:12 -0800 (PST)",
            "from localhost.localdomain ([167.220.105.115])\n\tby smtp.gmail.com with ESMTPSA id\n\ta18sm9638633pgj.30.2018.11.06.11.30.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 06 Nov 2018 11:30:10 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=6oBUCv7+phmIrDPpenUTh9zTN/opx5QeamKgnOqn6Ys=;\n\tb=cJLT08XP0VIStdikPSak071xLx0CHbTR0/3TIfM2yuSHBfAtrgjObPIeAa8NGDGZzP\n\ttgBt00YbnIHN5CfqKhpeyG+L7V3FOcXuZI5nEtAXdtIcR0MjX7Ru+9a602rOcofEeZUM\n\tV9c1J6cNKX69WP/ay5nJUKtKFeYH0YRYvjx0+yt3CLD9bghlcmUj8AL+0blfGahZhRi3\n\txkpTHvV06xMcOREfRFqnzpFCgzCc3/LomWbkWM5LbuzasspDIAl6YLcSdFgnNlNxCkEH\n\tfVk18Z0y8H9rQqKkZxwFwAzQK1HXdHPMc8BLu09Iv9wfIV//AeXlpdmciLwIq4IuFewj\n\t5NLA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=6oBUCv7+phmIrDPpenUTh9zTN/opx5QeamKgnOqn6Ys=;\n\tb=ZhHxoqXZ05fWyIj0ol4rhM8lczycP70IQgZytQUzDPEc56JAxNwkYyIHNWhWUtm02G\n\t4tWZ1cNGuL7ymfsmuBY6dT5Gbcc6ZYVrHTdhmgcQf0xJnqqxMNKzacHLkeVhu7EDjrha\n\tw39HEzz8RE21kMmH0wKts4vSPKMkMqqi8gaMe0dteX01fL9gjrcLufmQN+p3+Rq3rbKT\n\t4JVWIg1Hi4I/tzBPQKNqxCu4xjSU9Ie6U4p89IKWIaoHJ5RTGvmy5mGisodqp0tjljJN\n\tg9t0qYutaCP5sZZ/x8lKSXlbvPuGQemLwl/O3Idhl/jgB9XlLY6Kp1t7JPt4wTM2E5IA\n\tEdwQ==",
        "X-Gm-Message-State": "AGRZ1gKvXQa8IqyI/eOT8wcd6Fbftd8lb9LVnAfZWIDJzEtNKLJCVacr\n\t2U89nqIc5Eiyq8Zeu1jtovxHHMFKNdE=",
        "X-Google-Smtp-Source": "AJdET5fGUm1Do8xV1K/it+gGfI0WKyFmh/w5GtkJVZTBJmUd33Cf2hYuwcMwY9ltgv5/we6hs3MF0A==",
        "X-Received": "by 2002:a63:fd09:: with SMTP id\n\td9-v6mr25288789pgh.164.1541532611165; \n\tTue, 06 Nov 2018 11:30:11 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Tue,  6 Nov 2018 11:30:05 -0800",
        "Message-Id": "<20181106193005.5383-5-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20181106193005.5383-1-stephen@networkplumber.org>",
        "References": "<20181106193005.5383-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH 4/4] net/tap: fix warning about comparison of fd",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Static analysis tools don't like the fact that fd could be zero\nin the error path. This won't happen in real world because\nstdin would have to be closed, then other error occurring.\n\nCoverity issue: 14079\nFixes: 02f96a0a82d1 (\"net/tap: add TUN/TAP device PMD\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/tap/rte_eth_tap.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 84aaf241019a..f7087222b319 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -231,7 +231,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive)\n \treturn fd;\n \n error:\n-\tif (fd > 0)\n+\tif (fd >= 0)\n \t\tclose(fd);\n \treturn -1;\n }\n",
    "prefixes": [
        "4/4"
    ]
}