Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47799/?format=api
https://patches.dpdk.org/api/patches/47799/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181105070447.67700-1-dariusz.stojaczyk@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181105070447.67700-1-dariusz.stojaczyk@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181105070447.67700-1-dariusz.stojaczyk@intel.com", "date": "2018-11-05T07:04:45", "name": "[1/3] bus/pci: update device devargs on each rescan", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "c0c562431f2e6c27f24a64d611a27b2c1b0ece1c", "submitter": { "id": 1123, "url": "https://patches.dpdk.org/api/people/1123/?format=api", "name": "Stojaczyk, Dariusz", "email": "dariusz.stojaczyk@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181105070447.67700-1-dariusz.stojaczyk@intel.com/mbox/", "series": [ { "id": 2249, "url": "https://patches.dpdk.org/api/series/2249/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2249", "date": "2018-11-05T07:04:45", "name": "[1/3] bus/pci: update device devargs on each rescan", "version": 1, "mbox": "https://patches.dpdk.org/series/2249/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/47799/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/47799/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6CBD54CE4;\n\tMon, 5 Nov 2018 08:08:15 +0100 (CET)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id 69AD64CA2\n\tfor <dev@dpdk.org>; Mon, 5 Nov 2018 08:08:13 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Nov 2018 23:08:12 -0800", "from violet.igk.intel.com ([10.102.54.137])\n\tby fmsmga001.fm.intel.com with ESMTP; 04 Nov 2018 23:08:08 -0800" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,467,1534834800\"; d=\"scan'208\";a=\"105308426\"", "From": "Darek Stojaczyk <dariusz.stojaczyk@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Darek Stojaczyk <dariusz.stojaczyk@intel.com>,\n\tqi.z.zhang@intel.com", "Date": "Mon, 5 Nov 2018 08:04:45 +0100", "Message-Id": "<20181105070447.67700-1-dariusz.stojaczyk@intel.com>", "X-Mailer": "git-send-email 2.17.1", "Subject": "[dpdk-dev] [PATCH 1/3] bus/pci: update device devargs on each rescan", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Bus rescan is done e.g. during the device hotplug,\nwhere devargs are re-allocated. By not updating the\nrte_device->devargs pointer we potentially make it\na dangling one, as previous devargs could have been\n(or will be soon) freed.\n\nFixes: 55e411b301c3 (\"bus/pci: fix resource mapping override\")\nCc: qi.z.zhang@intel.com\n\nSigned-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>\n---\n drivers/bus/pci/linux/pci.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c\nindex f87533c5c..f3172960e 100644\n--- a/drivers/bus/pci/linux/pci.c\n+++ b/drivers/bus/pci/linux/pci.c\n@@ -349,10 +349,10 @@ pci_scan_one(const char *dirname, const struct rte_pci_addr *addr)\n \t\t\tif (ret < 0) {\n \t\t\t\trte_pci_insert_device(dev2, dev);\n \t\t\t} else { /* already registered */\n+\t\t\t\tpci_name_set(dev2);\n \t\t\t\tif (!rte_dev_is_probed(&dev2->device)) {\n \t\t\t\t\tdev2->kdrv = dev->kdrv;\n \t\t\t\t\tdev2->max_vfs = dev->max_vfs;\n-\t\t\t\t\tpci_name_set(dev2);\n \t\t\t\t\tmemmove(dev2->mem_resource,\n \t\t\t\t\t\tdev->mem_resource,\n \t\t\t\t\t\tsizeof(dev->mem_resource));\n", "prefixes": [ "1/3" ] }{ "id": 47799, "url": "