Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47542/?format=api
{ "id": 47542, "url": "https://patches.dpdk.org/api/patches/47542/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181028043542.87350-1-ferruh.yigit@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181028043542.87350-1-ferruh.yigit@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181028043542.87350-1-ferruh.yigit@intel.com", "date": "2018-10-28T04:35:42", "name": "net/bnxt: fix uninitialized variable access", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9af66d6822b5ec17724b27379b931f7082f85c90", "submitter": { "id": 324, "url": "https://patches.dpdk.org/api/people/324/?format=api", "name": "Ferruh Yigit", "email": "ferruh.yigit@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181028043542.87350-1-ferruh.yigit@intel.com/mbox/", "series": [ { "id": 2143, "url": "https://patches.dpdk.org/api/series/2143/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2143", "date": "2018-10-28T04:35:42", "name": "net/bnxt: fix uninitialized variable access", "version": 1, "mbox": "https://patches.dpdk.org/series/2143/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/47542/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/47542/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09DB52C4F;\n\tSun, 28 Oct 2018 04:36:03 +0100 (CET)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id B861B1E2B;\n\tSun, 28 Oct 2018 04:36:01 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Oct 2018 20:36:00 -0700", "from silpixa00399752.ir.intel.com (HELO\n\tsilpixa00399752.ger.corp.intel.com) ([10.237.222.212])\n\tby orsmga008.jf.intel.com with ESMTP; 27 Oct 2018 20:35:58 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.54,434,1534834800\"; d=\"scan'208\";a=\"85035028\"", "From": "Ferruh Yigit <ferruh.yigit@intel.com>", "To": "Ajit Khaparde <ajit.khaparde@broadcom.com>,\n\tSomnath Kotur <somnath.kotur@broadcom.com>", "Cc": "dev@dpdk.org,\n\tFerruh Yigit <ferruh.yigit@intel.com>,\n\tstable@dpdk.org", "Date": "Sun, 28 Oct 2018 04:35:42 +0000", "Message-Id": "<20181028043542.87350-1-ferruh.yigit@intel.com>", "X-Mailer": "git-send-email 2.17.2", "Subject": "[dpdk-dev] [PATCH] net/bnxt: fix uninitialized variable access", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "ag_cons is used uninitialized, it is used when DEBUG enabled, remove\ndebug code.\n\nFixes: 0958d8b6435d (\"net/bnxt: support LRO\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ferruh Yigit <ferruh.yigit@intel.com>\n---\n drivers/net/bnxt/bnxt_rxr.c | 24 ------------------------\n 1 file changed, 24 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c\nindex c7bc88481..1bfc63d93 100644\n--- a/drivers/net/bnxt/bnxt_rxr.c\n+++ b/drivers/net/bnxt/bnxt_rxr.c\n@@ -102,25 +102,6 @@ static inline void bnxt_reuse_rx_mbuf(struct bnxt_rx_ring_info *rxr,\n \trxr->rx_prod = prod;\n }\n \n-#ifdef BNXT_DEBUG\n-static void bnxt_reuse_ag_mbuf(struct bnxt_rx_ring_info *rxr, uint16_t cons,\n-\t\t\t struct rte_mbuf *mbuf)\n-{\n-\tuint16_t prod = rxr->ag_prod;\n-\tstruct bnxt_sw_rx_bd *prod_rx_buf;\n-\tstruct rx_prod_pkt_bd *prod_bd, *cons_bd;\n-\n-\tprod_rx_buf = &rxr->ag_buf_ring[prod];\n-\n-\tprod_rx_buf->mbuf = mbuf;\n-\n-\tprod_bd = &rxr->ag_desc_ring[prod];\n-\tcons_bd = &rxr->ag_desc_ring[cons];\n-\n-\tprod_bd->address = cons_bd->addr;\n-}\n-#endif\n-\n static inline\n struct rte_mbuf *bnxt_consume_rx_buf(struct bnxt_rx_ring_info *rxr,\n \t\t\t\t uint16_t cons)\n@@ -377,9 +358,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,\n \tuint32_t tmp_raw_cons = *raw_cons;\n \tuint16_t cons, prod, cp_cons =\n \t RING_CMP(cpr->cp_ring_struct, tmp_raw_cons);\n-#ifdef BNXT_DEBUG\n-\tuint16_t ag_cons;\n-#endif\n \tstruct rte_mbuf *mbuf;\n \tint rc = 0;\n \tuint8_t agg_buf = 0;\n@@ -482,8 +460,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt,\n \tif (rxcmp1->errors_v2 & RX_CMP_L2_ERRORS) {\n \t\t/* Re-install the mbuf back to the rx ring */\n \t\tbnxt_reuse_rx_mbuf(rxr, cons, mbuf);\n-\t\tif (agg_buf)\n-\t\t\tbnxt_reuse_ag_mbuf(rxr, ag_cons, mbuf);\n \n \t\trc = -EIO;\n \t\tgoto next_rx;\n", "prefixes": [] }