Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 47521,
    "url": "https://patches.dpdk.org/api/patches/47521/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181027091750.17254-13-harry.van.haaren@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181027091750.17254-13-harry.van.haaren@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181027091750.17254-13-harry.van.haaren@intel.com",
    "date": "2018-10-27T09:17:50",
    "name": "[v10,12/12] build: add dependency on telemetry to apps in meson",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "3bc72c11d4cd642569e3555c53ba1facfce496a9",
    "submitter": {
        "id": 317,
        "url": "https://patches.dpdk.org/api/people/317/?format=api",
        "name": "Van Haaren, Harry",
        "email": "harry.van.haaren@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181027091750.17254-13-harry.van.haaren@intel.com/mbox/",
    "series": [
        {
            "id": 2132,
            "url": "https://patches.dpdk.org/api/series/2132/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2132",
            "date": "2018-10-27T09:17:38",
            "name": "Introduce Telemetry Library",
            "version": 10,
            "mbox": "https://patches.dpdk.org/series/2132/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/47521/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/47521/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 44AC35F24;\n\tSat, 27 Oct 2018 11:20:36 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 31D0358FE\n\tfor <dev@dpdk.org>; Sat, 27 Oct 2018 11:19:54 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t27 Oct 2018 02:19:53 -0700",
            "from silpixa00399779.ir.intel.com (HELO\n\tsilpixa00399779.ger.corp.intel.com) ([10.237.223.188])\n\tby orsmga008.jf.intel.com with ESMTP; 27 Oct 2018 02:19:51 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,431,1534834800\"; d=\"scan'208\";a=\"84903924\"",
        "From": "Harry van Haaren <harry.van.haaren@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "thomas@monjalon.net, bruce.richardson@intel.com,\n\tstephen@networkplumber.org, gaetan.rivet@6wind.com,\n\tshreyansh.jain@nxp.com, \n\tmattias.ronnblom@ericsson.com, Kevin Laatz <kevin.laatz@intel.com>,\n\tRadu Nicolau <radu.nicolau@intel.com>",
        "Date": "Sat, 27 Oct 2018 10:17:50 +0100",
        "Message-Id": "<20181027091750.17254-13-harry.van.haaren@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20181027091750.17254-1-harry.van.haaren@intel.com>",
        "References": "<20181026235933.79779-1-harry.van.haaren@intel.com>\n\t<20181027091750.17254-1-harry.van.haaren@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v10 12/12] build: add dependency on telemetry to\n\tapps in meson",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Kevin Laatz <kevin.laatz@intel.com>\n\nThis patch adds telemetry as a dependecy to all applications. Without these\nchanges, the --telemetry flag will not be recognised and applications will\nfail to run if they want to enable telemetry.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: Kevin Laatz <kevin.laatz@intel.com>\nSigned-off-by: Radu Nicolau <radu.nicolau@intel.com>\nAcked-by: Harry van Haaren <harry.van.haaren@intel.com>\n---\n app/meson.build                  | 4 ++--\n app/pdump/meson.build            | 2 +-\n app/proc-info/meson.build        | 2 +-\n app/test-bbdev/meson.build       | 2 +-\n app/test-crypto-perf/meson.build | 2 +-\n app/test-pmd/meson.build         | 2 +-\n config/meson.build               | 3 +++\n lib/librte_telemetry/meson.build | 1 +\n lib/meson.build                  | 1 +\n meson.build                      | 2 ++\n 10 files changed, 14 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/app/meson.build b/app/meson.build\nindex e68d949e9..a9a026bbf 100644\n--- a/app/meson.build\n+++ b/app/meson.build\n@@ -29,7 +29,7 @@ foreach app:apps\n \t# use \"deps\" for internal DPDK dependencies, and \"ext_deps\" for\n \t# external package/library requirements\n \text_deps = []\n-\tdeps = []\n+\tdeps = dpdk_app_link_libraries\n \n \tsubdir(name)\n \n@@ -43,7 +43,7 @@ foreach app:apps\n \n \t\tlink_libs = []\n \t\tif get_option('default_library') == 'static'\n-\t\t\tlink_libs = dpdk_drivers\n+\t\t\tlink_libs = dpdk_static_libraries + dpdk_drivers\n \t\tendif\n \n \t\tif allow_experimental_apis\ndiff --git a/app/pdump/meson.build b/app/pdump/meson.build\nindex 988cb4eb2..116c27f02 100644\n--- a/app/pdump/meson.build\n+++ b/app/pdump/meson.build\n@@ -3,4 +3,4 @@\n \n sources = files('main.c')\n allow_experimental_apis = true\n-deps = ['ethdev', 'kvargs', 'pdump']\n+deps += ['ethdev', 'kvargs', 'pdump']\ndiff --git a/app/proc-info/meson.build b/app/proc-info/meson.build\nindex 9c148e36e..a52b2ee4a 100644\n--- a/app/proc-info/meson.build\n+++ b/app/proc-info/meson.build\n@@ -3,4 +3,4 @@\n \n sources = files('main.c')\n allow_experimental_apis = true\n-deps = ['ethdev', 'metrics']\n+deps += ['ethdev', 'metrics']\ndiff --git a/app/test-bbdev/meson.build b/app/test-bbdev/meson.build\nindex 653907ded..eb8cc0499 100644\n--- a/app/test-bbdev/meson.build\n+++ b/app/test-bbdev/meson.build\n@@ -6,4 +6,4 @@ sources = files('main.c',\n \t\t'test_bbdev_perf.c',\n \t\t'test_bbdev_vector.c')\n allow_experimental_apis = true\n-deps = ['bbdev', 'bus_vdev']\n+deps += ['bbdev', 'bus_vdev']\ndiff --git a/app/test-crypto-perf/meson.build b/app/test-crypto-perf/meson.build\nindex eacd7a0f5..d735b186f 100644\n--- a/app/test-crypto-perf/meson.build\n+++ b/app/test-crypto-perf/meson.build\n@@ -12,4 +12,4 @@ sources = files('cperf_ops.c',\n \t\t'cperf_test_vectors.c',\n \t\t'cperf_test_verify.c',\n \t\t'main.c')\n-deps = ['cryptodev']\n+deps += ['cryptodev']\ndiff --git a/app/test-pmd/meson.build b/app/test-pmd/meson.build\nindex cd66618e9..6006c60f9 100644\n--- a/app/test-pmd/meson.build\n+++ b/app/test-pmd/meson.build\n@@ -24,7 +24,7 @@ sources = files('cmdline.c',\n \t'txonly.c',\n \t'util.c')\n \n-deps = ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'meter', 'bus_pci']\n+deps += ['ethdev', 'gro', 'gso', 'cmdline', 'metrics', 'meter', 'bus_pci']\n if dpdk_conf.has('RTE_LIBRTE_PDUMP')\n \tdeps += 'pdump'\n endif\ndiff --git a/config/meson.build b/config/meson.build\nindex 6f9228c87..275f00b60 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -21,6 +21,9 @@ toolchain = cc.get_id()\n dpdk_conf.set_quoted('RTE_TOOLCHAIN', toolchain)\n dpdk_conf.set('RTE_TOOLCHAIN_' + toolchain.to_upper(), 1)\n \n+add_project_link_arguments('-Wl,--no-as-needed', language: 'c')\n+dpdk_extra_ldflags += '-Wl,--no-as-needed'\n+\n # use pthreads\n add_project_link_arguments('-pthread', language: 'c')\n dpdk_extra_ldflags += '-pthread'\ndiff --git a/lib/librte_telemetry/meson.build b/lib/librte_telemetry/meson.build\nindex b3bbf5bd0..9492f544e 100644\n--- a/lib/librte_telemetry/meson.build\n+++ b/lib/librte_telemetry/meson.build\n@@ -9,6 +9,7 @@ cflags += '-DALLOW_EXPERIMENTAL_API'\n jansson = cc.find_library('jansson', required: false)\n if jansson.found()\n \text_deps += jansson\n+\tdpdk_app_link_libraries += ['telemetry']\n else\n \tbuild = false\n endif\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 9d1f353d2..c0cc2d86e 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -132,6 +132,7 @@ foreach l:libraries\n \t\t\t\t\tdependencies: shared_deps)\n \n \t\t\tdpdk_libraries = [shared_lib] + dpdk_libraries\n+\t\t\tdpdk_static_libraries = [static_lib] + dpdk_static_libraries\n \t\tendif # sources.length() > 0\n \n \t\tset_variable('shared_' + libname, shared_dep)\ndiff --git a/meson.build b/meson.build\nindex c9af33532..b1e6eab6a 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -12,8 +12,10 @@ project('DPDK', 'C',\n cc = meson.get_compiler('c')\n dpdk_conf = configuration_data()\n dpdk_libraries = []\n+dpdk_static_libraries = []\n dpdk_drivers = []\n dpdk_extra_ldflags = []\n+dpdk_app_link_libraries = []\n \n driver_install_path = join_paths(get_option('libdir'), 'dpdk/drivers')\n eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)\n",
    "prefixes": [
        "v10",
        "12/12"
    ]
}