Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 47418,
    "url": "https://patches.dpdk.org/api/patches/47418/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181025104735.137381-1-dariusz.stojaczyk@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181025104735.137381-1-dariusz.stojaczyk@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181025104735.137381-1-dariusz.stojaczyk@intel.com",
    "date": "2018-10-25T10:47:35",
    "name": "vdev: fix rte_mp_request_sync() memleak on scan",
    "commit_ref": null,
    "pull_url": null,
    "state": "not-applicable",
    "archived": true,
    "hash": "7eb237ba9758df22575bf3edea42790a06b90871",
    "submitter": {
        "id": 1123,
        "url": "https://patches.dpdk.org/api/people/1123/?format=api",
        "name": "Stojaczyk, Dariusz",
        "email": "dariusz.stojaczyk@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181025104735.137381-1-dariusz.stojaczyk@intel.com/mbox/",
    "series": [
        {
            "id": 2093,
            "url": "https://patches.dpdk.org/api/series/2093/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2093",
            "date": "2018-10-25T10:47:35",
            "name": "vdev: fix rte_mp_request_sync() memleak on scan",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/2093/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/47418/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/47418/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 653AF4C99;\n\tThu, 25 Oct 2018 12:48:42 +0200 (CEST)",
            "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 07F074C95;\n\tThu, 25 Oct 2018 12:48:40 +0200 (CEST)",
            "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Oct 2018 03:48:40 -0700",
            "from violet.igk.intel.com ([10.102.54.177])\n\tby orsmga003.jf.intel.com with ESMTP; 25 Oct 2018 03:48:37 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.54,424,1534834800\"; d=\"scan'208\";a=\"94908948\"",
        "From": "Darek Stojaczyk <dariusz.stojaczyk@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "anatoly.burakov@intel.com, Darek Stojaczyk <dariusz.stojaczyk@intel.com>,\n\tjianfeng.tan@intel.com, qi.z.zhang@intel.com, stable@dpdk.org,\n\tPaul Luse <paul.e.luse@intel.com>",
        "Date": "Thu, 25 Oct 2018 12:47:35 +0200",
        "Message-Id": "<20181025104735.137381-1-dariusz.stojaczyk@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH] vdev: fix rte_mp_request_sync() memleak on scan",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "rte_mp_request_sync() says that the caller is responsible\nfor freeing one of its parameters afterwards. vdev didn't\ndo that, causing a memory leak.\n\nFixes: cdb068f031c6 (\"bus/vdev: scan by multi-process channel\")\nCc: jianfeng.tan@intel.com\nCc: qi.z.zhang@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Paul Luse <paul.e.luse@intel.com>\nSigned-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>\n---\n drivers/bus/vdev/vdev.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c\nindex 688e31c21..685cc4e78 100644\n--- a/drivers/bus/vdev/vdev.c\n+++ b/drivers/bus/vdev/vdev.c\n@@ -425,6 +425,7 @@ vdev_scan(void)\n \t\t\tmp_rep = &mp_reply.msgs[0];\n \t\t\tresp = (struct vdev_param *)mp_rep->param;\n \t\t\tVDEV_LOG(INFO, \"Received %d vdevs\", resp->num);\n+\t\t\tfree(mp_reply.msgs);\n \t\t} else\n \t\t\tVDEV_LOG(ERR, \"Failed to request vdev from primary\");\n \n",
    "prefixes": []
}