Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/47271/?format=api
{ "id": 47271, "url": "https://patches.dpdk.org/api/patches/47271/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1540344746-29045-4-git-send-email-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1540344746-29045-4-git-send-email-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1540344746-29045-4-git-send-email-honnappa.nagarahalli@arm.com", "date": "2018-10-24T01:32:24", "name": "[v6,3/5] hash: fix key store element alignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3de7382e683c079ec14863caa1437183aadac652", "submitter": { "id": 1045, "url": "https://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1540344746-29045-4-git-send-email-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 2045, "url": "https://patches.dpdk.org/api/series/2045/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=2045", "date": "2018-10-24T01:32:21", "name": "Address reader-writer concurrency in rte_hash", "version": 6, "mbox": "https://patches.dpdk.org/series/2045/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/47271/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/47271/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 57D0C1B0FB;\n\tWed, 24 Oct 2018 03:32:46 +0200 (CEST)", "from foss.arm.com (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])\n\tby dpdk.org (Postfix) with ESMTP id EB4AE5F3B\n\tfor <dev@dpdk.org>; Wed, 24 Oct 2018 03:32:39 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])\n\tby usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1B67815BE;\n\tTue, 23 Oct 2018 18:32:39 -0700 (PDT)", "from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com\n\t[10.118.14.139])\n\tby usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id\n\tAA0F83F627; Tue, 23 Oct 2018 18:32:38 -0700 (PDT)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "bruce.richardson@intel.com,\n\tpablo.de.lara.guarch@intel.com", "Cc": "dev@dpdk.org, yipeng1.wang@intel.com, honnappa.nagarahalli@arm.com,\n\tdharmik.thakkar@arm.com, gavin.hu@arm.com, nd@arm.com", "Date": "Tue, 23 Oct 2018 20:32:24 -0500", "Message-Id": "<1540344746-29045-4-git-send-email-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.7.4", "In-Reply-To": "<1540344746-29045-1-git-send-email-honnappa.nagarahalli@arm.com>", "References": "<1540344746-29045-1-git-send-email-honnappa.nagarahalli@arm.com>", "Subject": "[dpdk-dev] [PATCH v6 3/5] hash: fix key store element alignment", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Fix the key store array element alignment such that every array\nelement is aligned on KEY_ALIGNMENT boundary. This is required to\nmake 'pdata' in 'struct rte_hash_key' align on its natural boundary\nfor atomic load/store.\n\nFixes: 473d1bebce43 (\"hash: allow to store data in hash table\")\nCc: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <gavin.hu@arm.com>\nReviewed-by: Ola Liljedahl <ola.liljedahl@arm.com>\nReviewed-by: Steve Capper <steve.capper@arm.com>\nReviewed-by: Yipeng Wang <yipeng1.wang@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_hash/rte_cuckoo_hash.c | 4 +++-\n lib/librte_hash/rte_cuckoo_hash.h | 2 +-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c\nindex e087393..d79ba68 100644\n--- a/lib/librte_hash/rte_cuckoo_hash.c\n+++ b/lib/librte_hash/rte_cuckoo_hash.c\n@@ -279,7 +279,9 @@ rte_hash_create(const struct rte_hash_parameters *params)\n \t\t\trte_ring_sp_enqueue(r_ext, (void *)((uintptr_t) i));\n \t}\n \n-\tconst uint32_t key_entry_size = sizeof(struct rte_hash_key) + params->key_len;\n+\tconst uint32_t key_entry_size =\n+\t\tRTE_ALIGN(sizeof(struct rte_hash_key) + params->key_len,\n+\t\t\t KEY_ALIGNMENT);\n \tconst uint64_t key_tbl_size = (uint64_t) key_entry_size * num_key_slots;\n \n \tk = rte_zmalloc_socket(NULL, key_tbl_size,\ndiff --git a/lib/librte_hash/rte_cuckoo_hash.h b/lib/librte_hash/rte_cuckoo_hash.h\nindex ff95181..601b2ce 100644\n--- a/lib/librte_hash/rte_cuckoo_hash.h\n+++ b/lib/librte_hash/rte_cuckoo_hash.h\n@@ -123,7 +123,7 @@ struct rte_hash_key {\n \t};\n \t/* Variable key size */\n \tchar key[0];\n-} __attribute__((aligned(KEY_ALIGNMENT)));\n+};\n \n /* All different signature compare functions */\n enum rte_hash_sig_compare_function {\n", "prefixes": [ "v6", "3/5" ] }