Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 46814,
    "url": "https://patches.dpdk.org/api/patches/46814/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181015082352.81673-1-shahafs@mellanox.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20181015082352.81673-1-shahafs@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20181015082352.81673-1-shahafs@mellanox.com",
    "date": "2018-10-15T08:23:52",
    "name": "net/mlx5: fix compilation issue on ARM SOC",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "744957044b8bef17fce5444380e9f7d901ed506e",
    "submitter": {
        "id": 634,
        "url": "https://patches.dpdk.org/api/people/634/?format=api",
        "name": "Shahaf Shuler",
        "email": "shahafs@mellanox.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181015082352.81673-1-shahafs@mellanox.com/mbox/",
    "series": [
        {
            "id": 1895,
            "url": "https://patches.dpdk.org/api/series/1895/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1895",
            "date": "2018-10-15T08:23:52",
            "name": "net/mlx5: fix compilation issue on ARM SOC",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/1895/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/46814/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/46814/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 37C3023D;\n\tMon, 15 Oct 2018 10:24:11 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id E05FB239\n\tfor <dev@dpdk.org>; Mon, 15 Oct 2018 10:24:09 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tshahafs@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 15 Oct 2018 10:29:04 +0200",
            "from unicorn01.mtl.labs.mlnx. (unicorn01.mtl.labs.mlnx\n\t[10.7.12.62])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w9F8O7xV024544;\n\tMon, 15 Oct 2018 11:24:07 +0300"
        ],
        "From": "Shahaf Shuler <shahafs@mellanox.com>",
        "To": "yskoh@mellanox.com",
        "Cc": "dev@dpdk.org, orika@mellanox.com, xuemingl@mellanox.com",
        "Date": "Mon, 15 Oct 2018 11:23:52 +0300",
        "Message-Id": "<20181015082352.81673-1-shahafs@mellanox.com>",
        "X-Mailer": "git-send-email 2.12.0",
        "Subject": "[dpdk-dev] [PATCH] net/mlx5: fix compilation issue on ARM SOC",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "On some ARM environment, the below compilation error will be seen\n\ndpdk/drivers/net/mlx5/mlx5_flow_dv.c: In function\n'flow_dv_translate_item_nvgre':\n/tmp/dpdk/drivers/net/mlx5/mlx5_flow_dv.c:785:22: error: pointer targets\nin initialization differ in signedness [-Werror=pointer-sign]\n  const char *tni_v = nvgre_v->tni;\n\nThe reason for this error is that nvgre_v->tni is defined as byte array\nin size of 3B. However the code in the function iterate till the 4B in\norder to copy/set also the subsequent field after it (flow_id)\n\nFixing by pointing to this struct from a different pointer.\n\nFixes: fc2c498ccb94 (\"net/mlx5: add Direct Verbs translate items\")\nCc: orika@mellanox.com\nCc: xuemingl@mellanox.com\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex a013201eab..05df8d51a4 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -780,6 +780,7 @@ flow_dv_translate_item_nvgre(void *matcher, void *key,\n \tconst struct rte_flow_item_nvgre *nvgre_v = item->spec;\n \tvoid *misc_m = MLX5_ADDR_OF(fte_match_param, matcher, misc_parameters);\n \tvoid *misc_v = MLX5_ADDR_OF(fte_match_param, key, misc_parameters);\n+\tconst char *tni_v = (const char *)&nvgre_v->tni;\n \tchar *gre_key_m;\n \tchar *gre_key_v;\n \tint size;\n@@ -794,7 +795,7 @@ flow_dv_translate_item_nvgre(void *matcher, void *key,\n \tgre_key_v = MLX5_ADDR_OF(fte_match_set_misc, misc_v, gre_key_h);\n \tmemcpy(gre_key_m, nvgre_m->tni, size);\n \tfor (i = 0; i < size; ++i)\n-\t\tgre_key_v[i] = gre_key_m[i] & ((const char *)(nvgre_v->tni))[i];\n+\t\tgre_key_v[i] = gre_key_m[i] & tni_v[i];\n \tflow_dv_translate_item_gre(matcher, key, item, inner);\n }\n \n",
    "prefixes": []
}