Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46654/?format=api
{ "id": 46654, "url": "https://patches.dpdk.org/api/patches/46654/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181011175940.6800-1-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181011175940.6800-1-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20181011175940.6800-1-stephen@networkplumber.org", "date": "2018-10-11T17:59:40", "name": "ethdev: add function name to log message", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "8a0d8a52985d8d990f92a3ef830e049b71bed082", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181011175940.6800-1-stephen@networkplumber.org/mbox/", "series": [ { "id": 1849, "url": "https://patches.dpdk.org/api/series/1849/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1849", "date": "2018-10-11T17:59:40", "name": "ethdev: add function name to log message", "version": 1, "mbox": "https://patches.dpdk.org/series/1849/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/46654/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/46654/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E3E771B5CD;\n\tThu, 11 Oct 2018 19:59:49 +0200 (CEST)", "from mail-pg1-f196.google.com (mail-pg1-f196.google.com\n\t[209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 2E20F1B5BB\n\tfor <dev@dpdk.org>; Thu, 11 Oct 2018 19:59:49 +0200 (CEST)", "by mail-pg1-f196.google.com with SMTP id v133-v6so4540785pgb.2\n\tfor <dev@dpdk.org>; Thu, 11 Oct 2018 10:59:49 -0700 (PDT)", "from xeon-e3.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\tr65-v6sm38904283pfj.5.2018.10.11.10.59.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 11 Oct 2018 10:59:47 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=212b/Qvrzx9UQ/UVf/Y3Vkrq16rLOUCqWkRCvHV32fQ=;\n\tb=QnzhtDMt2NgTecvBMmnNkju1B3sJGhpxBYc7K1OYIUHmyi9gqA6SWUBKkH8d4c8R3v\n\tDB345drhOylWU2betYweeA9gA+a843DRrD/iiP7RrL6l7veeupflw9E6Voy9wKv+1l2N\n\tRHHkgUUwhQTCuTctxtIiclYbHKgcWJYWgIjx8u4F9lU4IFVmfcD/sCc17EINI7XnspXd\n\t8Yh64U9BLKPc6uFRJ1IrjfMTCcx6a/OEku4rQqPR7dAjiCMsWnPHb8ni3SNWpg8No5Ar\n\tjIw6b1X7aKUSlYAuXObZ/PQOuoLAfH3nDHKgX/v+8iO/A74a42NgZRtfJEESRjeprY4T\n\tgEdw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=212b/Qvrzx9UQ/UVf/Y3Vkrq16rLOUCqWkRCvHV32fQ=;\n\tb=K0IiaKv53sAyvL31JXjBh5XFdnWsNb7x76eIXv6CyyQjFVu0mDt9fOEJcHQ+xOydRH\n\trc/4QxQaV7IxW9NKJdTkdfJoG3eate2UDxudgUJZmec11WjSClVhBxIui5enaLwJ/3r9\n\t1B3UaFfJUOwCZvwhXklGba4dslWI8dSWtyihX6CWvlCE7ix/ZG/HCGhMrF55w3XFLPHY\n\tzYB1854KO0xxYmOOizeM/PHht1783qw7USUd6xfwgucVYv68fJ+QlnuggHVVLua8i6mh\n\t7+CUT3YKjueiVpm9TB+hI6mzwLr6g2+s2hK/uPR6Gs/NO0/PK0bIyGUXes9TKxib8oGN\n\tLr4Q==", "X-Gm-Message-State": "ABuFfojAt3a/ZhNuDlCuDbsVF1P/WyZWNknTgiKHESFS8zwSf5wWsWJx\n\tb3xRi6vIj+j+FRGicr1v5VHV2wUn8KI=", "X-Google-Smtp-Source": "ACcGV60RwHo/DUjM1w9/G63Nkdjw9wz8blW6TiyuCFt9hbVkacxXcQq0fEQIdSlP/lHsUSG3RAp9VQ==", "X-Received": "by 2002:a65:64d5:: with SMTP id\n\tt21-v6mr2360756pgv.428.1539280788249; \n\tThu, 11 Oct 2018 10:59:48 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "thomas@monjalon.net,\n\tferruh.yigit@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Thu, 11 Oct 2018 10:59:40 -0700", "Message-Id": "<20181011175940.6800-1-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.19.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] ethdev: add function name to log message", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "While debugging some virtio driver issues, saw:\n\tInvalid port_id=3\nbut it was not clear which function was logging this because the\nsame log is being done in multiple places in ethdev.\n\nTrivial fix is to prefix with function name as is done in other\ndrivers.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/failsafe/failsafe.c | 1 -\n lib/librte_ethdev/rte_ethdev.h | 5 +++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c\nindex c3999f0265b2..3830ed33dba2 100644\n--- a/drivers/net/failsafe/failsafe.c\n+++ b/drivers/net/failsafe/failsafe.c\n@@ -2,7 +2,6 @@\n * Copyright 2017 6WIND S.A.\n * Copyright 2017 Mellanox Technologies, Ltd\n */\n-\n #include <rte_alarm.h>\n #include <rte_malloc.h>\n #include <rte_ethdev_driver.h>\ndiff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h\nindex 012577b0ab22..9632c67b929b 100644\n--- a/lib/librte_ethdev/rte_ethdev.h\n+++ b/lib/librte_ethdev/rte_ethdev.h\n@@ -161,8 +161,9 @@ extern \"C\" {\n \n extern int rte_eth_dev_logtype;\n \n-#define RTE_ETHDEV_LOG(level, ...) \\\n-\trte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, \"\" __VA_ARGS__)\n+#define RTE_ETHDEV_LOG(level, fmt, ...)\t\t\\\n+\trte_log(RTE_LOG_ ## level, rte_eth_dev_logtype, \\\n+\t\t\"%s():\" fmt, __func__, ## __VA_ARGS__)\n \n struct rte_mbuf;\n \n", "prefixes": [] }