Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/46546/?format=api
{ "id": 46546, "url": "https://patches.dpdk.org/api/patches/46546/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20181011092432.22275-4-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181011092432.22275-4-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181011092432.22275-4-maxime.coquelin@redhat.com", "date": "2018-10-11T09:24:16", "name": "[v6,03/19] vhost: clarify reply-ack in case a reply was already sent", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "83a89e75388d630c526d30efe9ef50b1f6ae3a72", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20181011092432.22275-4-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 1825, "url": "https://patches.dpdk.org/api/series/1825/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=1825", "date": "2018-10-11T09:24:13", "name": "vhost: add postcopy live-migration support", "version": 6, "mbox": "https://patches.dpdk.org/series/1825/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/46546/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/46546/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 18DC31B16F;\n\tThu, 11 Oct 2018 11:24:58 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 37B0F5F19;\n\tThu, 11 Oct 2018 11:24:56 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 84D193004424;\n\tThu, 11 Oct 2018 09:24:55 +0000 (UTC)", "from localhost.localdomain (ovpn-112-55.ams2.redhat.com\n\t[10.36.112.55])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id E4DAE60472;\n\tThu, 11 Oct 2018 09:24:51 +0000 (UTC)" ], "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,\n\tjfreimann@redhat.com, nicknickolaev@gmail.com, i.maximets@samsung.com,\n\tbruce.richardson@intel.com, alejandro.lucero@netronome.com", "Cc": "dgilbert@redhat.com, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>", "Date": "Thu, 11 Oct 2018 11:24:16 +0200", "Message-Id": "<20181011092432.22275-4-maxime.coquelin@redhat.com>", "In-Reply-To": "<20181011092432.22275-1-maxime.coquelin@redhat.com>", "References": "<20181011092432.22275-1-maxime.coquelin@redhat.com>", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.11", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.49]); Thu, 11 Oct 2018 09:24:55 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v6 03/19] vhost: clarify reply-ack in case a\n\treply was already sent", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "For messages that require a reply, a second ack should not be\nsent when reply-ack protocol feature is negotiated, even if\nthe corresponding flag is set in the message.\n\nThe code is compliant with the spec but it isn't clear it is,\nso this patch adds a comment to make it explicit.\n\nSuggested-by: Ilya Maximets <i.maximets@samsung.com>\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nAcked-by: Ilya Maximets <i.maximets@samsung.com>\nReviewed-by: Tiwei Bie <tiwei.bie@intel.com>\n---\n lib/librte_vhost/vhost_user.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c\nindex 09a90a20b..a7729990d 100644\n--- a/lib/librte_vhost/vhost_user.c\n+++ b/lib/librte_vhost/vhost_user.c\n@@ -1783,6 +1783,11 @@ vhost_user_msg_handler(int vid, int fd)\n \tif (unlock_required)\n \t\tvhost_user_unlock_all_queue_pairs(dev);\n \n+\t/*\n+\t * If the request required a reply that was already sent,\n+\t * this optional reply-ack won't be sent as the\n+\t * VHOST_USER_NEED_REPLY was cleared in send_vhost_reply().\n+\t */\n \tif (msg.flags & VHOST_USER_NEED_REPLY) {\n \t\tmsg.payload.u64 = ret == VH_RESULT_ERR;\n \t\tmsg.size = sizeof(msg.payload.u64);\n", "prefixes": [ "v6", "03/19" ] }