Patch Comment List
List patch comments
GET /api/patches/465/comments/?format=api
[ { "id": 1645, "web_url": "https://patches.dpdk.org/comment/1645/", "msgid": "<1581482.OfWWpU8tO6@xps13>", "list_archive_url": "https://inbox.dpdk.org/dev/1581482.OfWWpU8tO6@xps13", "date": "2014-10-14T14:25:04", "subject": "Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "content": "2014-09-23 21:14, Chen Jing D:\n> +\t\tPMD_DRV_LOG(ERR, \"VMDQ not %s, can't set mac to pool %u\\n\",\n> +\t\t\tpf->flags | I40E_FLAG_VMDQ ? \"configured\" : \"enabled\",\n> +\t\t\tpool);\n[...]\n> -\tif (ret != I40E_SUCCESS) {\n> -\t\tPMD_DRV_LOG(ERR, \"Failed to write mac address\");\n> +\tif (pool > pf->nb_cfg_vmdq_vsi) {\n> +\t\tPMD_DRV_LOG(ERR, \"Pool number %u invalid. Max pool is %u\\n\",\n> +\t\t\t\tpool, pf->nb_cfg_vmdq_vsi);\n[...]\n> -\t\tPMD_DRV_LOG(ERR, \"Failed to add MACVLAN filter\");\n> +\t\tPMD_DRV_LOG(ERR, \"Failed to add MACVLAN filter\\n\");\n[...]\n> +\t\t\t\tPMD_DRV_LOG(ERR, \"Failed to remove MACVLAN filter\\n\");\n\nI'm pretty sure you rebased this patch and solved the conflicts without\nupdating your patch accordingly. Indeed carriage returns have been removed\nfrom logs recently.\nHint: rebase conflicts are really often meaningful ;)", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 610007E8B;\n\tTue, 14 Oct 2014 16:17:40 +0200 (CEST)", "from mail-wi0-f173.google.com (mail-wi0-f173.google.com\n\t[209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 680347E72\n\tfor <dev@dpdk.org>; Tue, 14 Oct 2014 16:17:39 +0200 (CEST)", "by mail-wi0-f173.google.com with SMTP id fb4so10321234wid.0\n\tfor <dev@dpdk.org>; Tue, 14 Oct 2014 07:25:23 -0700 (PDT)", "from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])\n\tby mx.google.com with ESMTPSA id\n\tfm10sm8241354wib.21.2014.10.14.07.25.22 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 14 Oct 2014 07:25:23 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:organization\n\t:user-agent:in-reply-to:references:mime-version\n\t:content-transfer-encoding:content-type;\n\tbh=IjyYp6QFaA/cLvCKs/G+eSU1Vn5pnFdrkz9O9hjdGew=;\n\tb=mV+HJCav3ZSK9R+fu6XBqoVfkXt1aI9LEsD3QKBfay4k629Y0Ut6HRnUJZ6aafJjKZ\n\tYLLyzacQFxxuepwU59cVoCZyh6DTqfCLjhr7Zc7qvQWFVetaGsWIMffMz+lr/IZeWAxJ\n\tSmR+rFpLtpp14Db2Y2VkW+aHTbHfpaAieWAHQnyPenUnT/IrTuQT0i3E6zDybos5WHIy\n\tHFUERgBMJqFsfsqC6cD9e5bgHLFK85thsSDaBm4Ph0STEEXVLUkccf1v4fqk2kcrIcBK\n\t2AXnOk+siZDpmpjoXPMIqANlwZOcys8lrBaNJaf1fJ46aZdyyhqetRtuqxi8yS4K8JBJ\n\tjbqA==", "X-Gm-Message-State": "ALoCoQnK9hNkEI3hDde5CyxnYUL6a8XmvvCcG8yWyXq8IqmcH6lC/U/Rgc1hZHNZW1h3iIzRMXPZ", "X-Received": "by 10.194.92.12 with SMTP id ci12mr5521162wjb.6.1413296723875;\n\tTue, 14 Oct 2014 07:25:23 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "\"Chen Jing D(Mark)\" <jing.d.chen@intel.com>", "Date": "Tue, 14 Oct 2014 16:25:04 +0200", "Message-ID": "<1581482.OfWWpU8tO6@xps13>", "Organization": "6WIND", "User-Agent": "KMail/4.14.1 (Linux/3.16.4-1-ARCH; KDE/4.14.1; x86_64; ; )", "In-Reply-To": "<1411478047-1251-6-git-send-email-jing.d.chen@intel.com>", "References": "<1411478047-1251-1-git-send-email-jing.d.chen@intel.com>\n\t<1411478047-1251-6-git-send-email-jing.d.chen@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7Bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 1660, "web_url": "https://patches.dpdk.org/comment/1660/", "msgid": "<4341B239C0EFF9468EE453F9E9F4604D015F3618@shsmsx102.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/4341B239C0EFF9468EE453F9E9F4604D015F3618@shsmsx102.ccr.corp.intel.com", "date": "2014-10-15T07:01:02", "subject": "Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement", "submitter": { "id": 40, "url": "https://patches.dpdk.org/api/people/40/?format=api", "name": "Chen, Jing D", "email": "jing.d.chen@intel.com" }, "content": "> -----Original Message-----\n> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]\n> Sent: Tuesday, October 14, 2014 10:25 PM\n> To: Chen, Jing D\n> Cc: dev@dpdk.org\n> Subject: Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement\n> \n> 2014-09-23 21:14, Chen Jing D:\n> > +\t\tPMD_DRV_LOG(ERR, \"VMDQ not %s, can't set mac to\n> pool %u\\n\",\n> > +\t\t\tpf->flags | I40E_FLAG_VMDQ ? \"configured\" :\n> \"enabled\",\n> > +\t\t\tpool);\n> [...]\n> > -\tif (ret != I40E_SUCCESS) {\n> > -\t\tPMD_DRV_LOG(ERR, \"Failed to write mac address\");\n> > +\tif (pool > pf->nb_cfg_vmdq_vsi) {\n> > +\t\tPMD_DRV_LOG(ERR, \"Pool number %u invalid. Max pool\n> is %u\\n\",\n> > +\t\t\t\tpool, pf->nb_cfg_vmdq_vsi);\n> [...]\n> > -\t\tPMD_DRV_LOG(ERR, \"Failed to add MACVLAN filter\");\n> > +\t\tPMD_DRV_LOG(ERR, \"Failed to add MACVLAN filter\\n\");\n> [...]\n> > +\t\t\t\tPMD_DRV_LOG(ERR, \"Failed to remove\n> MACVLAN filter\\n\");\n> \n> I'm pretty sure you rebased this patch and solved the conflicts without\n> updating your patch accordingly. Indeed carriage returns have been removed\n> from logs recently.\n> Hint: rebase conflicts are really often meaningful ;)\n> \n\nThanks for your suggestion.\n\n> --\n> Thomas", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B29E17E7F;\n\tWed, 15 Oct 2014 08:53:20 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 354697E74\n\tfor <dev@dpdk.org>; Wed, 15 Oct 2014 08:53:18 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga103.fm.intel.com with ESMTP; 14 Oct 2014 23:51:05 -0700", "from fmsmsx103.amr.corp.intel.com ([10.18.124.201])\n\tby fmsmga001.fm.intel.com with ESMTP; 15 Oct 2014 00:01:04 -0700", "from fmsmsx112.amr.corp.intel.com (10.18.116.6) by\n\tFMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 15 Oct 2014 00:01:05 -0700", "from shsmsx151.ccr.corp.intel.com (10.239.6.50) by\n\tFMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server\n\t(TLS) id 14.3.195.1; Wed, 15 Oct 2014 00:01:04 -0700", "from shsmsx102.ccr.corp.intel.com ([169.254.2.192]) by\n\tSHSMSX151.ccr.corp.intel.com ([169.254.3.172]) with mapi id\n\t14.03.0195.001; Wed, 15 Oct 2014 15:01:03 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.04,722,1406617200\"; d=\"scan'208\";a=\"605585233\"", "From": "\"Chen, Jing D\" <jing.d.chen@intel.com>", "To": "Thomas Monjalon <thomas.monjalon@6wind.com>", "Thread-Topic": "[dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement", "Thread-Index": "AQHP1zBXpINK7wOEJkO7ZMHxDR5/NZwvQM0AgAGcA/A=", "Date": "Wed, 15 Oct 2014 07:01:02 +0000", "Message-ID": "<4341B239C0EFF9468EE453F9E9F4604D015F3618@shsmsx102.ccr.corp.intel.com>", "References": "<1411478047-1251-1-git-send-email-jing.d.chen@intel.com>\n\t<1411478047-1251-6-git-send-email-jing.d.chen@intel.com>\n\t<1581482.OfWWpU8tO6@xps13>", "In-Reply-To": "<1581482.OfWWpU8tO6@xps13>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [PATCH 5/6] i40e: macaddr add/del enhancement", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]